adam/shoc-pr-review-runner
1
0
Fork 0
mirror of https://github.com/Sea-Haven-Industries/shoc-pr-review-runner.git synced 2026-09-30 07:13:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
shoc-pr-review-runner/tests/fixtures/reviews/valid-request-changes.md
Adam Moussa c3cd8f7765
feat: SHOC PR review runner, phase 1 
Manually-dispatched GitHub Actions workflow that reviews SHOC pull requests in
a clean environment: exact-head checkout of shoc-frontend-new and shoc-backend,
clean build/test gates, a truthful evidence report, a single-shot Fireworks
review, deterministic output validation, and published artifacts. The runner
never writes to the product repositories or their pull requests.

The review checklists move here from the reviewers' local Cursor commands so
the instructions live outside both product repos.

Phase 1 does not provision a database, start either application, or run live
browser flows; the evidence report records those as NOT_RUN so a review cannot
claim them.

Security architecture: building a PR executes its author's code, so the
workflow is split. The gates job runs that code holding no Fireworks key and
revokes its App token first; the review job holds the key, executes no product
code, and re-checks out this repo fresh. Product checkouts live outside the
workspace, the App token is downscoped at mint time, gate results fail closed
on any duplicate key, changed files are read from git objects rather than the
filesystem, and the validator re-checks every claim against the gate table.
2026-07-29 12:05:38 -04:00

707 B
Raw Blame History

1. Overall Verdict

REQUEST_CHANGES - The overdue filter sends a type value the backend rejects.

2. Overall Review Comment

Reviewed at abc1234. The board work is close, but the overdue filter still maps to types=99, which the backend binds to a real enum member and silently returns the wrong rows.

3. Inline Comments

src/api/api-paths.ts:42 - blocker

The overdue filter sends types=99; the backend expects overdue=true and binds 99 to WorkOrderType.Other, so the board silently shows wrong results.

Fix: Send overdue=true and drop the sentinel 99 from the types list. Test: A unit test asserting the overdue filter produces overdue=true with no types param.