adam/shoc-frontend-new
1
0
Fork 0
mirror of https://github.com/Sea-Haven-Industries/shoc-frontend-new.git synced 2026-10-04 21:52:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
384 commits 13 branches 2 tags 29 MiB
Commit graph

16 commits

Author SHA1 Message Date
arthur.bassi
0182345ba3 refactor(work-orders): address SH-114 review naming and utils placement 2026-08-19 09:28:32 -03:00
arthur.bassi
ce6e19ebaa Merge remote-tracking branch 'origin/dev' into feature/sh-114-wo-closability-gate 
# Conflicts:
#	src/app/(protected)/workorders/_components/list/table/cells/status-cell.tsx
#	src/domain/work-orders/utils/wo-closability.ts
#	src/test/domain/work-orders/utils/wo-closability.test.ts
 2026-08-18 21:18:49 -03:00
Codex Review Integration
14ff8c5481 style(work-orders): format SH-114 closability test 2026-08-18 17:56:29 -03:00
Codex Review Integration
4449e49149 fix(work-orders): align detail type mapping with Add-On indicator (SH-114) 
Merging dev broke this branch: SH-126/SH-184 made Add-On a backend-authoritative
indicator (isAddOn) and removed it from the WOType union, but
read-detail-closability-fields still accepted "Add-On" and mapped "AddOn" onto
it, so tsc failed on both the mapper and the closability test.

Drop Add-On from the detail type set so a legacy payload normalizes to "", and
cover the normalization directly instead of asserting it through
detailToClosabilityInput, which only forwards the already-typed value.
 2026-08-18 17:53:41 -03:00
arthur.bassi
a109a68f40 fix(work-orders): keep SH-188 tooltip when mixed with other gaps 
Stop copying WO lifecycle status into uplift primaryStatus on flat board rows.
 2026-08-18 17:28:14 -03:00
arthur.bassi
37a6098ecb fix(work-orders): require company not technician for Completed (SH-183) 2026-08-17 13:54:05 -03:00
Arthur Bassi
5d7ac297e4 fix(work-orders): drop vendor string from Completed closability (SH-114) 2026-08-14 10:55:06 -03:00
Arthur Bassi
1835a5939a fix(work-orders): dedupe completedDate and gate Completed on technician (SH-188) 
Refresh onto current dev and resolve exact-head review blockers:

- Remove duplicate WorkOrderBoardRowApi.completedDate after merge with dev

- Add SH-114 Technician closability gate alongside company/vendor check

- Update wo-closability regressions for missing technician
 2026-08-13 15:21:16 -03:00
arthur.bassi
dd60b1d72e fix(work-orders): allow comp-doc generate without existing completion document 
canGenerateCompDoc now ignores the completion-document closability gap so PM/Overdue drafts can enter generation.

Co-authored-by: Cursor <cursoragent@cursor.com>
 2026-08-11 15:28:00 -03:00
arthur.bassi
67c4ee8119 fix(work-orders): only block Completed on evidenced pending uplift 
Absence of optional uplift fields means no pending, per SH-188.
 2026-08-11 15:28:00 -03:00
arthur.bassi
a3e9a20477 fix(work-orders): fail closed on unknown uplift status 2026-08-11 15:28:00 -03:00
arthur.bassi
6b415f732c fix(work-orders): unify closability with sh-114 and pending uplift 2026-08-11 15:26:21 -03:00
arthur.bassi
f5414e4b14 feat(work-orders): block completed when uplift is pending 2026-08-11 15:26:21 -03:00
arthur.bassi
5e3b7b8057 fix(work-orders): use authoritative type/doc/media for detail closability 
Stop treating integration source as WorkOrderType.
Enrich detail from board detail for SH-114/SH-183 gates.

Co-authored-by: Cursor <cursoragent@cursor.com>
 2026-08-11 14:06:54 -03:00
arthur.bassi
8cd6d92ba7 fix(work-orders): map detail problem and source into closability 
detailToClosabilityInput now uses WorkOrderDetail.problem as pm and source as WO type so Done is not permanently blocked by a false Service gap.

Co-authored-by: Cursor <cursoragent@cursor.com>
 2026-08-10 19:11:35 -03:00
Arthur Bassi
c850be2aeb fix(work-orders): compare completion labels via string helper 
[recover] remove malicious eslint payload (was 19dfa0f9)
 2026-08-10 17:12:14 -03:00