adam/shoc-frontend-new
1
0
Fork 0
mirror of https://github.com/Sea-Haven-Industries/shoc-frontend-new.git synced 2026-10-02 10:53:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

fix(work-orders): drop vendor string from Completed closability (SH-114)

Browse source
This commit is contained in:
Arthur Bassi 2026-08-14 10:55:06 -03:00
parent 3c914f4e57
commit 5d7ac297e4
2 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/domain/work-orders/utils/wo-closability.ts
View file

@ -73,9 +73,6 @@ export function getClosabilityGaps(row: WoClosabilityInput): string[] {
if (!row.tech.trim()) {
gaps.push("Technician");
}
if (!row.company.trim()) {
gaps.push("Company / vendor");
}
if (!row.completedDate.trim()) {
gaps.push("Completed Date");
}

5
src/test/domain/work-orders/utils/wo-closability.test.ts
View file

@ -64,8 +64,8 @@ describe("getClosabilityGaps", () => {
expect(getClosabilityGaps(makeInput({ tech: "" }))).toEqual(["Technician"]);
});
it("does not let a technician satisfy a missing company requirement", () => {
expect(getClosabilityGaps(makeInput({ company: "" }))).toEqual(["Company / vendor"]);
it("does not block Completed when vendor/company is empty if technician is assigned", () => {
expect(getClosabilityGaps(makeInput({ company: "" }))).toEqual([]);
});
it("lists field gaps before uplift and document gaps", () => {
@ -87,7 +87,6 @@ describe("getClosabilityGaps", () => {
).toEqual([
"Dispatcher",
"Technician",
"Company / vendor",
"Completed Date",
"WO number",
"Service",