mirror of
https://github.com/Sea-Haven-Industries/shoc-frontend-new.git
synced 2026-10-03 11:33:22 +00:00
25837171a4
* docs(work-orders): add pending BE contract checklist for design parity gaps * feat(work-orders): confirm dialog when duplicate wo number detected * fix(work-orders): show duplicate wo number dialog on wizard create * docs(work-orders): align pr description with jira and qa residuals * style(work-orders): prettier wizard duplicate dialog files * refactor(workorders): extract wizard state hook and list overlays * fix(work-orders): check duplicate numbers globally * fix(work-orders): exhaust fuzzy pages for exact WO number lookup Prevent accepting duplicates that fall outside the first fuzzy search page. * style(work-orders): format editable WO number cell for Prettier gate * fix(work-orders): 0-based WO search page and stale duplicate guard * fix(work-orders): sync draft WO# ref in effect for duplicate guard [SH-189] * fix(work-orders): extract WO number editor under max-lines gate Co-authored-by: Cursor <cursoragent@cursor.com> * fix(work-orders): harden duplicate WO number checks [SH-189] * fix(work-orders): sync wizard refs in effects and exhaust duplicate WO lookup Co-authored-by: Cursor <cursoragent@cursor.com> * fix(work-orders): extract hooks to satisfy max-lines governance gate Co-authored-by: Cursor <cursoragent@cursor.com> * style(work-orders): format wizard state hook for Prettier gate Co-authored-by: Cursor <cursoragent@cursor.com> * fix(work-orders): search one-character WO numbers for duplicates --------- Co-authored-by: Cursor <cursoragent@cursor.com>
26 lines
1.2 KiB
Markdown
26 lines
1.2 KiB
Markdown
## Jira
|
|
|
|
- [SH-189](https://luby-us.atlassian.net/browse/SH-189)
|
|
|
|
## QA residual
|
|
|
|
- P0 done: duplicate dialog also on **wizard create** (not only table cell).
|
|
- P1 polish: Cancel / View Existing copy tweaks.
|
|
|
|
## Summary
|
|
|
|
- Show a confirmation dialog when inline WO number editing **or wizard create** detects a duplicate instead of navigating immediately to the existing work order.
|
|
- Dialog title: **Duplicate Work Order Number**; actions: **View existing** (opens the existing WO via slide-over route) and **Dismiss** (closes the dialog and keeps the current row editable).
|
|
- Duplicate scan logic shared via `find-duplicate-wo-number-row`.
|
|
|
|
## Test plan
|
|
|
|
- [ ] Edit a WO number in the table to match an existing row → dialog opens with the duplicate number in the message.
|
|
- [ ] Click **Dismiss** → dialog closes; edited row keeps its original number.
|
|
- [ ] Repeat duplicate entry → click **View existing** → navigates to `/workorders/{id}` for the existing row.
|
|
- [ ] Wizard create with duplicate WO number → same dialog; **View existing** closes wizard and opens `/workorders/{id}`.
|
|
|
|
## Out of scope
|
|
|
|
- Server-side uniqueness (422) handling
|
|
- SH provisional numbering
|