adam/shoc-frontend-new
1
0
Fork 0
mirror of https://github.com/Sea-Haven-Industries/shoc-frontend-new.git synced 2026-09-30 10:23:11 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2
shoc-frontend-new/tmp/pr-descriptions/pr2-severity-wizard.md
Arthur Bassi b4cb9d0288
Some checks failed
CI / ci (push) Has been cancelled
Details
CI / governance (push) Has been cancelled
Details
CI / vendor-visual-regression (push) Has been cancelled
Details
Deploy / deploy (push) Has been cancelled
Details
feat(work-orders): severity gates and wizard type/WO# parity (SH-192) (#106) 
* fix(work-orders): allow blank WO number in wizard create path

[recover] remove malicious eslint payload (was d0d08508)

* fix(work-orders): emit severity before type in board scalar PATCH ops

Co-authored-by: Cursor <cursoragent@cursor.com>

* chore(work-orders): drop vendor collateral from SH-192 lane

* fix(work-orders): add severity to unscheduled highlight fixture after dev merge

* refactor(work-orders): extract inline type/severity cell under function line cap

* fix(work-orders): add severity to comp-doc and media fixtures after dev merge

PR #45 introduced completion-doc, media and table-mutation fixtures that predate the required severity field, so the integrated head failed tsc. Fill severity on those row builders (null for PM, SEV 1 for the Emergency fixture) and type the mutation BASE_ROW instead of asserting it.

* test(work-orders): align merge fixes with severity field and WO# placeholder

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Arthur Bassi <bassi-arthurr@users.noreply.github.com>
Co-authored-by: Alexandre Brandizzi <alex_brandizzi@hotmail.com>
2026-08-14 11:59:52 -03:00

1.5 KiB
Raw Blame History

Jira

  • SH-192 — severity on Emergency/Reactive
  • Related: SH-107 (WO# provisional SH…), SH-108 (POC)

QA residual

  • P0 wizard fixed: Type optional (default PM); WO# alphanumeric / SH provisional (not digits-only).
  • P1: COL_HELP tooltips, Scheduled-requires-date — follow-up.

Summary

  • Add SEV 1–5 domain field on board row/create/patch and Type cell modal for Emergency/Reactive.
  • Wizard gates: required WO# (alphanumeric/SH ok), Type optional (defaults PM), severity when E/R, POC name/phone on step 2 with error UX.

Scope

In

  • severity on WorkOrderBoardRowApi / create payload / editable field / table row / wizard draft
  • Type cell popover + TypeSeverityModal + SeverityBadge
  • Wizard step1/step2 validation + footer attempt-continue errors
  • Unit tests for canContinue* and severity patch mapping

Out (follow-up PRs)

  • Advanced filter severity facet (PR5)
  • Uplift UI, Completed Date column, multi-POC, SH auto-numbering beyond wizard gate

API / BE

  • Contract assumed: severity on GET board/search row, POST create, and PATCH field severity
  • Blocked on BE: none for FE wiring; 422 if severity missing for E/R should be handled by BE

Test plan

  • Board: pick Emergency/Reactive → severity modal required; badge shows SEV
  • Wizard: cannot continue step1 without WO#; E/R without severity; step2 without POC
  • npm run verify green locally

Base

  • Base branch: dev