adam/seahaven-external-dev-baseline
Archived
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

INFRA-136: add standard labeler caller #11

Merged
amoussa1229 merged 2 commits from INFRA-136-ci-standardization into main 2026-07-08 20:36:40 +00:00
Conversation 0 Commits 2 Files changed 1 +11
amoussa1229 commented 2026-07-08 20:29:47 +00:00 (Migrated from github.com)
Copy link

Summary

CI standardization hygiene (INFRA-136, agents 12a/12b). Adds the org standard callable-labeler thin caller, missing on this repo (present on 26/28 repos) — for the baseline repo this is another symptom of the skipped provisioning checklist. Without it PRs go unlabeled, breaking org-wide triage/reporting consistency.

Copied verbatim from the standard caller (Stub 3); all three permission grants (contents: read, pull-requests: write, issues: write) are load-bearing — omitting one causes a silent startup_failure. Uses the @main reusable ref to match this repo's existing ci.yaml/deploy.yaml idiom.

Refs INFRA-136.

## Summary CI standardization hygiene (INFRA-136, agents 12a/12b). Adds the org standard `callable-labeler` thin caller, missing on this repo (present on 26/28 repos) — for the baseline repo this is another symptom of the skipped provisioning checklist. Without it PRs go unlabeled, breaking org-wide triage/reporting consistency. Copied verbatim from the standard caller (Stub 3); all three permission grants (`contents: read`, `pull-requests: write`, `issues: write`) are load-bearing — omitting one causes a silent `startup_failure`. Uses the `@main` reusable ref to match this repo's existing ci.yaml/deploy.yaml idiom. Refs INFRA-136.
seahaven-openswe[bot] (Migrated from github.com) reviewed 2026-07-08 20:30:37 +00:00
seahaven-openswe[bot] (Migrated from github.com) left a comment

Open SWE Review found 1 potential issue.

Open in Web

**Open SWE Review** found 1 potential issue. [Open in Web](https://openswe.seahaven.com/agents/reviews/Sea-Haven-Industries/seahaven-external-dev-baseline/11) <!-- open-swe-reviewer pr=11 -->
.github/workflows/labeler.yaml
@ -0,0 +1,11 @@
name: Labeler
seahaven-openswe[bot] (Migrated from github.com) commented 2026-07-08 20:30:37 +00:00

🟡 Reusable workflow pinned to floating @main

The caller workflow references Sea-Haven-Industries/.github/.github/workflows/callable-labeler.yaml@main. The repo's existing ci.yaml and deploy.yaml pin the reusable workflow to a specific SHA (fd60e4c...) with a # main comment, but this new file uses a floating ref. This contradicts the established pattern and allows the callable workflow to change without a corresponding PR in this repo, causing non-reproducible builds and potentially breaking labeler permissions/silently failing on a future upstream update. The PR description says it uses @main to match the existing idiom, but the existing files actually pin to SHA. If main is the intended idiom, ci.yaml/deploy.yaml should be updated too; otherwise this file should pin to the same SHA as the others.

(Refers to line 11)

Your feedback helps Open SWE learn. React with 👍 or 👎 to tell us if this review comment was useful.

    uses: Sea-Haven-Industries/.github/.github/workflows/callable-labeler.yaml@fd60e4c9041784f666ac0fdefb9bec3c7fbf5143 # main
<!-- open-swe-review-comment {"id":"f_b557002f35","file_path":".github/workflows/labeler.yaml","start_line":11,"end_line":11,"side":"RIGHT"} --> 🟡 **Reusable workflow pinned to floating @main** The caller workflow references `Sea-Haven-Industries/.github/.github/workflows/callable-labeler.yaml@main`. The repo's existing `ci.yaml` and `deploy.yaml` pin the reusable workflow to a specific SHA (`fd60e4c...`) with a `# main` comment, but this new file uses a floating ref. This contradicts the established pattern and allows the callable workflow to change without a corresponding PR in this repo, causing non-reproducible builds and potentially breaking labeler permissions/silently failing on a future upstream update. The PR description says it uses `@main` to match the existing idiom, but the existing files actually pin to SHA. If `main` is the intended idiom, `ci.yaml`/`deploy.yaml` should be updated too; otherwise this file should pin to the same SHA as the others. *(Refers to line 11)* --- *Your feedback helps Open SWE learn. React with 👍 or 👎 to tell us if this review comment was useful.* ```suggestion uses: Sea-Haven-Industries/.github/.github/workflows/callable-labeler.yaml@fd60e4c9041784f666ac0fdefb9bec3c7fbf5143 # main ```
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
ci

   
dependencies

Pull requests that update a dependency file

  
docs

   
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
infra

Infrastructure / IaC changes

  
invalid

This doesn't seem right

  
javascript

Pull requests that update javascript code

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
ci
dependencies
docs
documentation
duplicate
enhancement
good first issue
help wanted
infra
invalid
javascript
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: adam/seahaven-external-dev-baseline#11
No description provided.
Delete branch "INFRA-136-ci-standardization"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?