mirror of
https://github.com/Sea-Haven-Industries/procurement-ingest.git
synced 2026-10-07 16:08:54 +00:00
Adam Moussa
ffa8a625a7
/sh-security-review of PR #105 (5 fresh-context detectors + proof-or-kill verifier) confirmed two diff-introduced findings; both fixed here. F3 (medium, real PII in new fixtures): the harvest scrub replaced header tokens but left real third-party PII in message BODIES -- an Amazon contact's name/phone/personal email in non-coupa-02.eml and an internal t.corp.amazon.com ticket URL in comment-02.eml, plus real submitter/attn names recurring across the new_po corpus. Replaced every personal name, phone, personal email, and internal URL with synthetic placeholders (QP-soft-wrap aware) across both .eml bodies and expected goldens. Extended test_fixture_hygiene to scan BODIES (phone shapes, corp URLs, the leaked tokens), closing the header-only gap that let this through. F1 (medium, cancellation gate): _CANCELLATION_SUBJECT was unanchored and matched with .search(), unlike the anchored new_po pattern -- a subject merely ending with the cancellation phrase could be routed to the sticky- Cancelled write. Fully anchored it and switched to .match, and added a body-corroboration gate (the real Coupa body independently restates 'Purchase Order #<po> ... has been cancelled'); a near-miss/misrouted subject whose body does not corroborate now fails closed to the LLM (new reason code cancellation_body_unconfirmed). Pre-existing (advisory, not this PR): the LLM-fallback else->save_new_po dispatch and undelimited extraction prompt (issue #101 family) are byte-identical to main and unchanged here. 401 tests pass; ruff/format clean; cdk synth po-ingest clean. |
||
|---|---|---|
| .. | ||
| cancellation-01.json | ||
| cancellation-02.json | ||
| cancellation-03.json | ||
| cancellation-04.json | ||
| cancellation-05.json | ||
| cancellation-06.json | ||
| cancellation-07.json | ||
| cancellation-08.json | ||
| new-po-01.json | ||
| new-po-02.json | ||
| new-po-03.json | ||
| new-po-04.json | ||
| new-po-08.json | ||
| new-po-09.json | ||
| new-po-10.json | ||
| new-po-11.json | ||
| new-po-12.json | ||
| new-po-13.json | ||
| new-po-14.json | ||
| new-po-15.json | ||
| new-po-16.json | ||
| new-po-17.json | ||
| new-po-18.json | ||
| new-po-19.json | ||
| new-po-20.json | ||