adam/procurement-ingest
1
0
Fork 0
mirror of https://github.com/Sea-Haven-Industries/procurement-ingest.git synced 2026-10-06 08:41:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Drop NEEDS ADAM SIGN-OFF wording from alarm comments

Browse source 
Duration alarm thresholds are owner-approved; remove the sign-off flag
from po_stack.py and wo_stack.py comments. Threshold values, eval config,
and orphan-delete notes are unchanged.
This commit is contained in:
Adam Moussa 2026-06-17 14:38:05 -04:00
parent c5f1bcb038
commit 719acd3e49
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
cdk/po_stack.py
View file

@ -229,7 +229,7 @@ class PoIngestStack(Stack):
# --- Duration alarm: po-email-processor (orphan adoption) --- # --- Duration alarm: po-email-processor (orphan adoption) ---
# Adopts the orphaned CLI alarm Lambda-Duration-po-email-processor under # Adopts the orphaned CLI alarm Lambda-Duration-po-email-processor under
# the repo's <fn>-duration naming (NEW logical name → no deploy collision; # the repo's <fn>-duration naming (NEW logical name → no deploy collision;
# delete the orphan post-deploy). NEEDS ADAM SIGN-OFF: p99 / 45000 ms # delete the orphan post-deploy). p99 / 45000 ms
# (75% of the 60s timeout) / eval 3 of 3 — tighter than the orphan's # (75% of the 60s timeout) / eval 3 of 3 — tighter than the orphan's
# Maximum>=48000 / 1-of-1. # Maximum>=48000 / 1-of-1.
email_processor.metric_duration( email_processor.metric_duration(
@ -308,7 +308,7 @@ class PoIngestStack(Stack):
).add_alarm_action(cw_actions.SnsAction(alarm_topic)) ).add_alarm_action(cw_actions.SnsAction(alarm_topic))
# --- Duration alarm: po-web-ui --- # --- Duration alarm: po-web-ui ---
# Net-new (no orphan exists for this function). NEEDS ADAM SIGN-OFF: # Net-new (no orphan exists for this function).
# p99 / 45000 ms (75% of the 60s timeout) / eval 3, datapoints 2. # p99 / 45000 ms (75% of the 60s timeout) / eval 3, datapoints 2.
web_ui.metric_duration( web_ui.metric_duration(
period=Duration.minutes(5), period=Duration.minutes(5),
@ -410,7 +410,7 @@ class PoIngestStack(Stack):
).add_alarm_action(cw_actions.SnsAction(alarm_topic)) ).add_alarm_action(cw_actions.SnsAction(alarm_topic))
# --- Duration alarm: po-ingest-site-extractor --- # --- Duration alarm: po-ingest-site-extractor ---
# Net-new (no orphan exists for this function). NEEDS ADAM SIGN-OFF: # Net-new (no orphan exists for this function).
# p99 / 45000 ms (75% of the 60s timeout) / eval 3, datapoints 2. # p99 / 45000 ms (75% of the 60s timeout) / eval 3, datapoints 2.
site_extractor.metric_duration( site_extractor.metric_duration(
period=Duration.minutes(5), period=Duration.minutes(5),

2
cdk/wo_stack.py
View file

@ -246,7 +246,7 @@ class WorkorderIngestStack(Stack):
# --- Duration alarm: workorder-email-processor (orphan adoption) --- # --- Duration alarm: workorder-email-processor (orphan adoption) ---
# Adopts the orphaned CLI alarm Lambda-Duration-workorder-email-processor # Adopts the orphaned CLI alarm Lambda-Duration-workorder-email-processor
# under the repo's <fn>-duration naming (NEW logical name → no deploy # under the repo's <fn>-duration naming (NEW logical name → no deploy
# collision; delete the orphan post-deploy). NEEDS ADAM SIGN-OFF: p95 / # collision; delete the orphan post-deploy). p95 /
# 45000 ms (75% of the 60s timeout) / eval 3 of which 2 datapoints — # 45000 ms (75% of the 60s timeout) / eval 3 of which 2 datapoints —
# tighter than the orphan's Maximum>=48000 / 1-of-1. # tighter than the orphan's Maximum>=48000 / 1-of-1.
email_processor.metric_duration( email_processor.metric_duration(