From 719acd3e49208d0edcd388db84205db7999fedbb Mon Sep 17 00:00:00 2001 From: Adam Moussa Date: Wed, 17 Jun 2026 14:38:05 -0400 Subject: [PATCH] Drop NEEDS ADAM SIGN-OFF wording from alarm comments Duration alarm thresholds are owner-approved; remove the sign-off flag from po_stack.py and wo_stack.py comments. Threshold values, eval config, and orphan-delete notes are unchanged. --- cdk/po_stack.py | 6 +++--- cdk/wo_stack.py | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/cdk/po_stack.py b/cdk/po_stack.py index af9e702..3e2036e 100644 --- a/cdk/po_stack.py +++ b/cdk/po_stack.py @@ -229,7 +229,7 @@ class PoIngestStack(Stack): # --- Duration alarm: po-email-processor (orphan adoption) --- # Adopts the orphaned CLI alarm Lambda-Duration-po-email-processor under # the repo's -duration naming (NEW logical name → no deploy collision; - # delete the orphan post-deploy). NEEDS ADAM SIGN-OFF: p99 / 45000 ms + # delete the orphan post-deploy). p99 / 45000 ms # (75% of the 60s timeout) / eval 3 of 3 — tighter than the orphan's # Maximum>=48000 / 1-of-1. email_processor.metric_duration( @@ -308,7 +308,7 @@ class PoIngestStack(Stack): ).add_alarm_action(cw_actions.SnsAction(alarm_topic)) # --- Duration alarm: po-web-ui --- - # Net-new (no orphan exists for this function). NEEDS ADAM SIGN-OFF: + # Net-new (no orphan exists for this function). # p99 / 45000 ms (75% of the 60s timeout) / eval 3, datapoints 2. web_ui.metric_duration( period=Duration.minutes(5), @@ -410,7 +410,7 @@ class PoIngestStack(Stack): ).add_alarm_action(cw_actions.SnsAction(alarm_topic)) # --- Duration alarm: po-ingest-site-extractor --- - # Net-new (no orphan exists for this function). NEEDS ADAM SIGN-OFF: + # Net-new (no orphan exists for this function). # p99 / 45000 ms (75% of the 60s timeout) / eval 3, datapoints 2. site_extractor.metric_duration( period=Duration.minutes(5), diff --git a/cdk/wo_stack.py b/cdk/wo_stack.py index e7ea288..8aa766d 100644 --- a/cdk/wo_stack.py +++ b/cdk/wo_stack.py @@ -246,7 +246,7 @@ class WorkorderIngestStack(Stack): # --- Duration alarm: workorder-email-processor (orphan adoption) --- # Adopts the orphaned CLI alarm Lambda-Duration-workorder-email-processor # under the repo's -duration naming (NEW logical name → no deploy - # collision; delete the orphan post-deploy). NEEDS ADAM SIGN-OFF: p95 / + # collision; delete the orphan post-deploy). p95 / # 45000 ms (75% of the 60s timeout) / eval 3 of which 2 datapoints — # tighter than the orphan's Maximum>=48000 / 1-of-1. email_processor.metric_duration(