agent-team Plane-2: P4 live transports + intake, P3-inert build/verify subgraph #13

Merged
amoussa1229 merged 3 commits from feature/agent-team-plane2-p3-p4 into main 2026-06-18 17:40:48 +00:00
amoussa1229 commented 2026-06-18 17:23:39 +00:00 (Migrated from github.com)

Stacked on #12 (base = feature/agent-team-plane2-p1-p2).

What

Continues the Plane-2 depth-first build. Authored by a multi-agent workflow (4 parallel builders -> integrate -> adversarial review), gate-respecting.

P4 (ungated)

  • transport/github_live.py - live GitHub issue-comment poster (question_id marker).
  • transport/claude_code_live.py - live Claude Code file-drop responder.
  • transport/github_intake.py - GithubIntake: labeled issue -> coordinator.start_task, de-duped.
  • run-team.py - _build_transport wires github/claude_code live; new intake-github subcommand.

P3-inert (gate-respecting, opt-in, NO live CI)

  • nodes/build_verify_subgraph.py - BUILD->VERIFY nodes + route_after_verify.
  • graph.py - opt-in build_verify param repoints the review build route at the subgraph (BUILD->VERIFY->{approved->END | loop->PLAN | parked->END}); default unchanged (P2).
  • coordinator.py - build_verify_wiring composes it INERT: no ci_result -> ci_gate BLOCK -> PARKED; the LLM is a fix-proposer only and can never declare green.

Gate held

Production default stays P2 (P3 is opt-in and off). The live CI apply/verify workflow + OIDC role are NOT in this PR - they remain held for the mandatory /sh-security-review + GPT-4.1 cross-review of the CI/untrusted-input trust boundary (design §3.3.2 / §7.1 P3).

Security review (workflow)

2 dimensions (security + correctness) -> proof-or-kill verifier. No BLOCK. 2 confirmed NITs, both fixed in this PR:

  • Untrusted issue title/body logged verbatim (log-injection) -> truncated + newline-escaped.
  • claude_code_live drop-path backslash sanitization edge -> backslash now neutralized (defense-in-depth; traversal was already prevented on POSIX).

Tests

795 passing, ruff clean. New coverage: each transport + intake, the P3 graph topology (authenticated-pass -> DONE, no-CI -> PARKED, LLM-cannot-flip-to-pass), and the run-team transport/intake wiring.

Not in this PR (still gated / later)

  • P3 live CI apply/verify + OIDC (the security + cross-review gate).
  • Provisioning + live demos; Plane-1 checkers + Phase 0 substrate.
**Stacked on #12** (base = `feature/agent-team-plane2-p1-p2`). ## What Continues the Plane-2 depth-first build. Authored by a multi-agent workflow (4 parallel builders -> integrate -> adversarial review), gate-respecting. ### P4 (ungated) - `transport/github_live.py` - live GitHub issue-comment poster (question_id marker). - `transport/claude_code_live.py` - live Claude Code file-drop responder. - `transport/github_intake.py` - `GithubIntake`: labeled issue -> `coordinator.start_task`, de-duped. - `run-team.py` - `_build_transport` wires github/claude_code live; new `intake-github` subcommand. ### P3-inert (gate-respecting, opt-in, NO live CI) - `nodes/build_verify_subgraph.py` - BUILD->VERIFY nodes + `route_after_verify`. - `graph.py` - opt-in `build_verify` param repoints the review `build` route at the subgraph (`BUILD->VERIFY->{approved->END | loop->PLAN | parked->END}`); **default unchanged (P2)**. - `coordinator.py` - `build_verify_wiring` composes it INERT: no `ci_result` -> `ci_gate` BLOCK -> PARKED; the LLM is a fix-proposer only and can never declare green. ## Gate held Production default stays **P2** (P3 is opt-in and off). The live CI apply/verify workflow + OIDC role are **NOT** in this PR - they remain held for the mandatory **`/sh-security-review` + GPT-4.1 cross-review** of the CI/untrusted-input trust boundary (design §3.3.2 / §7.1 P3). ## Security review (workflow) 2 dimensions (security + correctness) -> proof-or-kill verifier. **No BLOCK.** 2 confirmed NITs, both fixed in this PR: - Untrusted issue title/body logged verbatim (log-injection) -> truncated + newline-escaped. - `claude_code_live` drop-path backslash sanitization edge -> backslash now neutralized (defense-in-depth; traversal was already prevented on POSIX). ## Tests 795 passing, ruff clean. New coverage: each transport + intake, the P3 graph topology (authenticated-pass -> DONE, no-CI -> PARKED, LLM-cannot-flip-to-pass), and the run-team transport/intake wiring. ## Not in this PR (still gated / later) - P3 **live** CI apply/verify + OIDC (the security + cross-review gate). - Provisioning + live demos; Plane-1 checkers + Phase 0 substrate.
This repo is archived. You cannot comment on pull requests.
No description provided.