orchestrator

adam/orchestrator

Archived

Fork 0

Commit graph

Author	SHA1	Message	Date
Adam Moussa	c4bea7270b	harden(agent-team): fold C1 cross-review MEDIUMs into p3_rollback.sh GPT-4.1 cross-family review (APPROVE, no critical/high) raised two MEDIUMs on the rollback tooling; addressed both: - require_keys: each restore_* asserts its required baseline keys up front and refuses a PARTIAL (silently-weaker) restore. environment accepts ids OR logins (equivalent); a missing protection.full now REFUSES the enforce_admins-only degrade unless P3_ROLLBACK_ALLOW_PARTIAL=1 is set (loud DEGRADED warning). - out-of-band ACK: an --apply that needs a MANUAL App neutralise (no APP JWT, or action=out-of-band) refuses unless P3_ROLLBACK_OOB_ACK=1 — so the App is never left un-neutralised without a conscious operator sign-off; with the ack the other surfaces still restore. Documented both env vars in usage. +3 tests (required-key refuse, partial-protection ack, oob ack). Suite: 1362 passed, ruff clean.	2026-06-23 19:52:04 -04:00
Adam Moussa	cb84629c2b	feat(agent-team): P3 Phases A/B/E — safety tooling, wiring, docs Phase A (safety): - scripts/p3_rollback.sh (+test): restore all privileged P3 surfaces from a recorded baseline; --dry-run default, --apply gated. Correct App-uninstall (App JWT) model; per-task env-reviewer restore by numeric id; real protection post-restore assert (normalize reads argv, fails loud, divergent state exits non-zero — regression-tested). KNOWN-LIMITATIONS header flags the branch-protection GET->PUT transform + live-validation for the C1 gate. - scripts/assert_no_write_token.py (+test): box/CI audit that no write token (incl. ghu_/ghr_ prefixes + App PEM) lives on the box. - draft_pr_monitor.py (+test): runaway (>3/15min) + stale (7d) draft-PR sweep, wired into tick() and bound a read-only provider in serve. Phase B (wiring): systemd EnvironmentFile P3 vars + verification; new-draft-PR lifecycle notice. Phase E (docs): P3-LIVE-FLIP-PLAN/README/ci-README reflect CI-live-since-6/22 + box-integration; runbook consolidated (rollback Incident 7 + box-env wiring); removed a stray duplicate runbook. Suite: 1360 passed, ruff clean. Branch only; not merged/deployed. REMAINING HUMAN GATES: C1 /sh-security-review + GPT-4.1 cross-review on the enabled workflow + rollback script; D box deploy + smoke + merge.	2026-06-23 19:52:04 -04:00

Author

SHA1

Message

Date

Adam Moussa

c4bea7270b

harden(agent-team): fold C1 cross-review MEDIUMs into p3_rollback.sh

GPT-4.1 cross-family review (APPROVE, no critical/high) raised two MEDIUMs on the
rollback tooling; addressed both:
- require_keys: each restore_* asserts its required baseline keys up front and
  refuses a PARTIAL (silently-weaker) restore. environment accepts ids OR logins
  (equivalent); a missing protection.full now REFUSES the enforce_admins-only
  degrade unless P3_ROLLBACK_ALLOW_PARTIAL=1 is set (loud DEGRADED warning).
- out-of-band ACK: an --apply that needs a MANUAL App neutralise (no APP JWT, or
  action=out-of-band) refuses unless P3_ROLLBACK_OOB_ACK=1 — so the App is never
  left un-neutralised without a conscious operator sign-off; with the ack the
  other surfaces still restore.
Documented both env vars in usage. +3 tests (required-key refuse, partial-protection
ack, oob ack). Suite: 1362 passed, ruff clean.

2026-06-23 19:52:04 -04:00

Adam Moussa

cb84629c2b

feat(agent-team): P3 Phases A/B/E — safety tooling, wiring, docs

Phase A (safety):
- scripts/p3_rollback.sh (+test): restore all privileged P3 surfaces from a
  recorded baseline; --dry-run default, --apply gated. Correct App-uninstall
  (App JWT) model; per-task env-reviewer restore by numeric id; real
  protection post-restore assert (normalize reads argv, fails loud, divergent
  state exits non-zero — regression-tested). KNOWN-LIMITATIONS header flags the
  branch-protection GET->PUT transform + live-validation for the C1 gate.
- scripts/assert_no_write_token.py (+test): box/CI audit that no write token
  (incl. ghu_/ghr_ prefixes + App PEM) lives on the box.
- draft_pr_monitor.py (+test): runaway (>3/15min) + stale (7d) draft-PR sweep,
  wired into tick() and bound a read-only provider in serve.

Phase B (wiring): systemd EnvironmentFile P3 vars + verification; new-draft-PR
lifecycle notice.

Phase E (docs): P3-LIVE-FLIP-PLAN/README/ci-README reflect CI-live-since-6/22 +
box-integration; runbook consolidated (rollback Incident 7 + box-env wiring);
removed a stray duplicate runbook.

Suite: 1360 passed, ruff clean. Branch only; not merged/deployed.
REMAINING HUMAN GATES: C1 /sh-security-review + GPT-4.1 cross-review on the
enabled workflow + rollback script; D box deploy + smoke + merge.

2026-06-23 19:52:04 -04:00

2 commits