adam/open-swe
1
0
Fork 0
mirror of https://github.com/Sea-Haven-Industries/open-swe.git synced 2026-10-06 01:52:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

fix: Better naming for NEXT_PUBLIC_GITHUB_APP_CLIENT_ID (#427)

Browse source
This commit is contained in:
Brace Sproul 2025-07-16 08:52:26 -07:00 • committed by GitHub
parent d2e981e219
commit dc6e6b8625
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
apps/docs/setup/development.mdx
View file

@ -58,7 +58,7 @@ Before starting, ensure you have the following installed:
```bash Environment Variables [expandable] ```bash Environment Variables [expandable]
# GitHub App OAuth settings (will be filled after creating GitHub App) # GitHub App OAuth settings (will be filled after creating GitHub App)
NEXT_PUBLIC_GITHUB_APP_ID="" NEXT_PUBLIC_GITHUB_APP_CLIENT_ID=""
GITHUB_APP_CLIENT_SECRET="" GITHUB_APP_CLIENT_SECRET=""
GITHUB_APP_REDIRECT_URI="http://localhost:3000/api/auth/github/callback" GITHUB_APP_REDIRECT_URI="http://localhost:3000/api/auth/github/callback"
@ -189,7 +189,7 @@ Before starting, ensure you have the following installed:
- **GITHUB_APP_NAME**: The name you chose - **GITHUB_APP_NAME**: The name you chose
- **GITHUB_APP_ID**: Found in the "About" section (e.g., `12345678`) - **GITHUB_APP_ID**: Found in the "About" section (e.g., `12345678`)
- **NEXT_PUBLIC_GITHUB_APP_ID**: Found in the "About" section - **NEXT_PUBLIC_GITHUB_APP_CLIENT_ID**: Found in the "About" section
- **GITHUB_APP_CLIENT_SECRET**: - **GITHUB_APP_CLIENT_SECRET**:
1. Scroll to "Client secrets" section 1. Scroll to "Client secrets" section
2. Click "Generate new client secret" 2. Click "Generate new client secret"

2
apps/web/.env.example
View file

@ -1,6 +1,6 @@
# ------------------Github App Secrets----------------- # ------------------Github App Secrets-----------------
# GitHub app client secrets. Used for the GitHub OAuth login flow. # GitHub app client secrets. Used for the GitHub OAuth login flow.
NEXT_PUBLIC_GITHUB_APP_ID="" NEXT_PUBLIC_GITHUB_APP_CLIENT_ID=""
GITHUB_APP_CLIENT_SECRET="" GITHUB_APP_CLIENT_SECRET=""
# Should be updated to your production URL when deployed. # Should be updated to your production URL when deployed.
# This value should match the redirect URL you have configured in # This value should match the redirect URL you have configured in

2
apps/web/src/app/api/auth/github/callback/route.ts
View file

@ -38,7 +38,7 @@ export async function GET(request: NextRequest) {
); );
} }
const clientId = process.env.NEXT_PUBLIC_GITHUB_APP_ID; const clientId = process.env.NEXT_PUBLIC_GITHUB_APP_CLIENT_ID;
const clientSecret = process.env.GITHUB_APP_CLIENT_SECRET; const clientSecret = process.env.GITHUB_APP_CLIENT_SECRET;
const redirectUri = process.env.GITHUB_APP_REDIRECT_URI; const redirectUri = process.env.GITHUB_APP_REDIRECT_URI;

2
apps/web/src/app/api/auth/github/login/route.ts
View file

@ -3,7 +3,7 @@ import { NextRequest, NextResponse } from "next/server";
export async function GET(_request: NextRequest) { export async function GET(_request: NextRequest) {
try { try {
const clientId = process.env.NEXT_PUBLIC_GITHUB_APP_ID; const clientId = process.env.NEXT_PUBLIC_GITHUB_APP_CLIENT_ID;
const redirectUri = process.env.GITHUB_APP_REDIRECT_URI; const redirectUri = process.env.GITHUB_APP_REDIRECT_URI;
if (!clientId || !redirectUri) { if (!clientId || !redirectUri) {

2
apps/web/src/features/settings-page/github-manager.tsx
View file

@ -53,7 +53,7 @@ export function GitHubManager() {
}; };
const handleManageOnGitHub = () => { const handleManageOnGitHub = () => {
const appId = process.env.NEXT_PUBLIC_GITHUB_APP_ID; const appId = process.env.NEXT_PUBLIC_GITHUB_APP_CLIENT_ID;
const fallbackInstallationsUrl = const fallbackInstallationsUrl =
"https://github.com/settings/installations"; "https://github.com/settings/installations";
const applicationUrl = appId const applicationUrl = appId