From dc6e6b86257292e1979c7ed5dff707ac19392a72 Mon Sep 17 00:00:00 2001
From: Brace Sproul <braceasproul@gmail.com>
Date: Wed, 16 Jul 2025 08:52:26 -0700
Subject: [PATCH] fix: Better naming for NEXT_PUBLIC_GITHUB_APP_CLIENT_ID
 (#427)

---
 apps/docs/setup/development.mdx                        | 4 ++--
 apps/web/.env.example                                  | 2 +-
 apps/web/src/app/api/auth/github/callback/route.ts     | 2 +-
 apps/web/src/app/api/auth/github/login/route.ts        | 2 +-
 apps/web/src/features/settings-page/github-manager.tsx | 2 +-
 5 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/apps/docs/setup/development.mdx b/apps/docs/setup/development.mdx
index 49e13032..5857d855 100644
--- a/apps/docs/setup/development.mdx
+++ b/apps/docs/setup/development.mdx
@@ -58,7 +58,7 @@ Before starting, ensure you have the following installed:
 
     ```bash Environment Variables [expandable]
     # GitHub App OAuth settings (will be filled after creating GitHub App)
-    NEXT_PUBLIC_GITHUB_APP_ID=""
+    NEXT_PUBLIC_GITHUB_APP_CLIENT_ID=""
     GITHUB_APP_CLIENT_SECRET=""
     GITHUB_APP_REDIRECT_URI="http://localhost:3000/api/auth/github/callback"
     
@@ -189,7 +189,7 @@ Before starting, ensure you have the following installed:
 
     - **GITHUB_APP_NAME**: The name you chose
     - **GITHUB_APP_ID**: Found in the "About" section (e.g., `12345678`)
-    - **NEXT_PUBLIC_GITHUB_APP_ID**: Found in the "About" section
+    - **NEXT_PUBLIC_GITHUB_APP_CLIENT_ID**: Found in the "About" section
     - **GITHUB_APP_CLIENT_SECRET**: 
       1. Scroll to "Client secrets" section
       2. Click "Generate new client secret"
diff --git a/apps/web/.env.example b/apps/web/.env.example
index 0745c53e..1b5e74d1 100644
--- a/apps/web/.env.example
+++ b/apps/web/.env.example
@@ -1,6 +1,6 @@
 # ------------------Github App Secrets-----------------
 # GitHub app client secrets. Used for the GitHub OAuth login flow.
-NEXT_PUBLIC_GITHUB_APP_ID=""
+NEXT_PUBLIC_GITHUB_APP_CLIENT_ID=""
 GITHUB_APP_CLIENT_SECRET=""
 # Should be updated to your production URL when deployed.
 # This value should match the redirect URL you have configured in
diff --git a/apps/web/src/app/api/auth/github/callback/route.ts b/apps/web/src/app/api/auth/github/callback/route.ts
index cb2192ec..9ff84be6 100644
--- a/apps/web/src/app/api/auth/github/callback/route.ts
+++ b/apps/web/src/app/api/auth/github/callback/route.ts
@@ -38,7 +38,7 @@ export async function GET(request: NextRequest) {
       );
     }
 
-    const clientId = process.env.NEXT_PUBLIC_GITHUB_APP_ID;
+    const clientId = process.env.NEXT_PUBLIC_GITHUB_APP_CLIENT_ID;
     const clientSecret = process.env.GITHUB_APP_CLIENT_SECRET;
     const redirectUri = process.env.GITHUB_APP_REDIRECT_URI;
 
diff --git a/apps/web/src/app/api/auth/github/login/route.ts b/apps/web/src/app/api/auth/github/login/route.ts
index 0ed3ccdf..804313a4 100644
--- a/apps/web/src/app/api/auth/github/login/route.ts
+++ b/apps/web/src/app/api/auth/github/login/route.ts
@@ -3,7 +3,7 @@ import { NextRequest, NextResponse } from "next/server";
 
 export async function GET(_request: NextRequest) {
   try {
-    const clientId = process.env.NEXT_PUBLIC_GITHUB_APP_ID;
+    const clientId = process.env.NEXT_PUBLIC_GITHUB_APP_CLIENT_ID;
     const redirectUri = process.env.GITHUB_APP_REDIRECT_URI;
 
     if (!clientId || !redirectUri) {
diff --git a/apps/web/src/features/settings-page/github-manager.tsx b/apps/web/src/features/settings-page/github-manager.tsx
index cc35282d..c804654c 100644
--- a/apps/web/src/features/settings-page/github-manager.tsx
+++ b/apps/web/src/features/settings-page/github-manager.tsx
@@ -53,7 +53,7 @@ export function GitHubManager() {
   };
 
   const handleManageOnGitHub = () => {
-    const appId = process.env.NEXT_PUBLIC_GITHUB_APP_ID;
+    const appId = process.env.NEXT_PUBLIC_GITHUB_APP_CLIENT_ID;
     const fallbackInstallationsUrl =
       "https://github.com/settings/installations";
     const applicationUrl = appId