INFRA-136: fail ci/ci aggregator on skipped needed jobs #74

Merged

amoussa1229 merged 1 commit from INFRA-136-ci-standardization into main

2026-07-08 20:53:52 +00:00

amoussa1229 commented

2026-07-08 20:30:44 +00:00

(Migrated from github.com)

Summary

CI standardization hygiene (INFRA-136, agent 12a). The inline ci / ci aggregator green-lit the org-required status check when a needed job was SKIPPED: skipped is neither failure nor cancelled, so a conditionally-skipped required job could pass the org-required check without ever running.

Fix

Treat skipped as a failure in the aggregator condition (one-line change plus a comment). Pure hardening — python and typescript have no if: and cannot skip under current config, so this does not affect current green builds; it closes the latent hole.

Deferred

The audit's prescribed remedy (Stub 4: a shared callable-ci-aggregate.yaml reusable, converting exec-aide and proposal-system) is not applied here: it requires authoring a new org-wide reusable workflow in the .github repo with a cross-repo @main dependency, and is coupled to proposal-system (a closed topic, out of scope). Recommend a dedicated follow-up ticket to build the shared callable once and convert callers. This contained inline fix closes the actual bug for exec-aide in the meantime.

Refs INFRA-136.

## Summary CI standardization hygiene (INFRA-136, agent 12a). The inline `ci / ci` aggregator green-lit the org-required status check when a needed job was **SKIPPED**: `skipped` is neither `failure` nor `cancelled`, so a conditionally-skipped required job could pass the org-required check without ever running. ### Fix Treat `skipped` as a failure in the aggregator condition (one-line change plus a comment). Pure hardening — `python` and `typescript` have no `if:` and cannot skip under current config, so this does not affect current green builds; it closes the latent hole. ### Deferred The audit's prescribed remedy (Stub 4: a shared `callable-ci-aggregate.yaml` reusable, converting exec-aide and proposal-system) is **not applied** here: it requires authoring a new org-wide reusable workflow in the `.github` repo with a cross-repo `@main` dependency, and is coupled to proposal-system (a closed topic, out of scope). Recommend a dedicated follow-up ticket to build the shared callable once and convert callers. This contained inline fix closes the actual bug for exec-aide in the meantime. Refs INFRA-136.

seahaven-openswe[bot] (Migrated from github.com) reviewed 2026-07-08 20:31:59 +00:00

seahaven-openswe[bot] (Migrated from github.com) left a comment

✅ Open SWE Review: No issues found

Open SWE reviewed this PR and found no potential bugs to report.

Open in Web

## ✅ Open SWE Review: No issues found Open SWE reviewed this PR and found no potential bugs to report. [Open in Web](https://openswe.seahaven.com/agents/reviews/Sea-Haven-Industries/exec-aide/74)

This repo is archived. You cannot comment on pull requests.

No reviewers