Add CI workflow #27

Merged
amoussa1229 merged 2 commits from feature/add-ci-workflow into main 2026-05-08 20:02:47 +00:00
amoussa1229 commented 2026-05-08 19:42:01 +00:00 (Migrated from github.com)

Summary

Add a reusable CI workflow that runs on pull requests to main. This repo has a mixed stack (TypeScript CDK + Python Lambdas), so the workflow calls both ci-python-sam.yaml (for src/ with SAM validation disabled) and ci-typescript-cdk.yaml. Also applies ruff formatting and lint fixes across all Python source files (11 files reformatted, 3 auto-fixed lint issues, 4 E402 import-order violations fixed manually).

Validation

  • Verified workflow YAML syntax and reusable workflow references
  • Ran ruff format and ruff check --fix on src/
  • Manually fixed E402 violations in src/conversation/app.py (moved imports above class definition)
  • Final ruff check and ruff format --check both pass clean

Tests

CI will validate itself on this PR if the reusable workflows are already published to the .github repo's main branch.

## Summary Add a reusable CI workflow that runs on pull requests to main. This repo has a mixed stack (TypeScript CDK + Python Lambdas), so the workflow calls both `ci-python-sam.yaml` (for `src/` with SAM validation disabled) and `ci-typescript-cdk.yaml`. Also applies ruff formatting and lint fixes across all Python source files (11 files reformatted, 3 auto-fixed lint issues, 4 E402 import-order violations fixed manually). ## Validation - Verified workflow YAML syntax and reusable workflow references - Ran `ruff format` and `ruff check --fix` on `src/` - Manually fixed E402 violations in `src/conversation/app.py` (moved imports above class definition) - Final `ruff check` and `ruff format --check` both pass clean ## Tests CI will validate itself on this PR if the reusable workflows are already published to the `.github` repo's main branch.
cursor[bot] commented 2026-05-08 19:42:08 +00:00 (Migrated from github.com)

PR Summary

Low Risk
Low risk: mainly adds a GitHub Actions CI workflow and applies ruff-driven formatting/import cleanups with no intended behavior changes.

Overview
Adds a PR-triggered GitHub Actions CI workflow that reuses org-standard pipelines for Python (SAM) and TypeScript (CDK), with synth/validate steps explicitly disabled.

Separately, applies repo-wide ruff formatting/lint fixes across the Python sources (import order cleanup, line wrapping, and a few small style-only edits like removing unused imports), with no functional changes intended.

Reviewed by Cursor Bugbot for commit ff9aec3c35. Bugbot is set up for automated code reviews on this repo. Configure here.

## PR Summary <!-- CURSOR_SUMMARY --> **Low Risk** Low risk: mainly adds a GitHub Actions CI workflow and applies ruff-driven formatting/import cleanups with no intended behavior changes. **Overview** Adds a PR-triggered GitHub Actions `CI` workflow that reuses org-standard pipelines for **Python (SAM)** and **TypeScript (CDK)**, with synth/validate steps explicitly disabled. Separately, applies repo-wide ruff formatting/lint fixes across the Python sources (import order cleanup, line wrapping, and a few small style-only edits like removing unused imports), with no functional changes intended. <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit ff9aec3c355fca9ee55d09ff39eb7363ea0c9326. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
claude[bot] commented 2026-05-08 19:44:06 +00:00 (Migrated from github.com)

Reviewed — looks good. Almost entirely ruff format/lint cleanup, plus the new reusable-workflow wiring in .github/workflows/ci.yaml and an E402 fix in src/conversation/app.py (imports lifted above _DecimalEncoder, no behavior change). Spot-checked the dropped imports (json in slack.py, datetime/timezone in gmail.py) and they are genuinely unused. No bugs, security issues, or convention violations to flag.

Reviewed — looks good. Almost entirely ruff format/lint cleanup, plus the new reusable-workflow wiring in `.github/workflows/ci.yaml` and an E402 fix in `src/conversation/app.py` (imports lifted above `_DecimalEncoder`, no behavior change). Spot-checked the dropped imports (`json` in `slack.py`, `datetime`/`timezone` in `gmail.py`) and they are genuinely unused. No bugs, security issues, or convention violations to flag.
claude[bot] commented 2026-05-08 20:02:11 +00:00 (Migrated from github.com)

Reviewed — looks good. CI workflow correctly delegates to the org's reusable Python+SAM and TypeScript+CDK workflows, and the ruff formatting changes are functionally inert. Spot-checked the two import removals (json in shared/slack.py, datetime/timezone in shared/gmail.py) and confirmed neither is referenced after removal, and the import reordering in conversation/app.py doesn't introduce a circular import.

Reviewed — looks good. CI workflow correctly delegates to the org's reusable Python+SAM and TypeScript+CDK workflows, and the ruff formatting changes are functionally inert. Spot-checked the two import removals (`json` in `shared/slack.py`, `datetime/timezone` in `shared/gmail.py`) and confirmed neither is referenced after removal, and the import reordering in `conversation/app.py` doesn't introduce a circular import.
This repo is archived. You cannot comment on pull requests.
No description provided.