Add CI workflow #27
No reviewers
Labels
No labels
app
bug
ci
compliance
dependencies
docs
documentation
duplicate
enhancement
good first issue
help wanted
infra
invalid
javascript
python
question
wontfix
No milestone
No project
No assignees
1 participant
Due date
No due date set.
Dependencies
No dependencies set.
Reference: adam/exec-aide#27
Loading…
Add table
Reference in a new issue
No description provided.
Delete branch "feature/add-ci-workflow"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Add a reusable CI workflow that runs on pull requests to main. This repo has a mixed stack (TypeScript CDK + Python Lambdas), so the workflow calls both
ci-python-sam.yaml(forsrc/with SAM validation disabled) andci-typescript-cdk.yaml. Also applies ruff formatting and lint fixes across all Python source files (11 files reformatted, 3 auto-fixed lint issues, 4 E402 import-order violations fixed manually).Validation
ruff formatandruff check --fixonsrc/src/conversation/app.py(moved imports above class definition)ruff checkandruff format --checkboth pass cleanTests
CI will validate itself on this PR if the reusable workflows are already published to the
.githubrepo's main branch.PR Summary
Low Risk
Low risk: mainly adds a GitHub Actions CI workflow and applies ruff-driven formatting/import cleanups with no intended behavior changes.
Overview
Adds a PR-triggered GitHub Actions
CIworkflow that reuses org-standard pipelines for Python (SAM) and TypeScript (CDK), with synth/validate steps explicitly disabled.Separately, applies repo-wide ruff formatting/lint fixes across the Python sources (import order cleanup, line wrapping, and a few small style-only edits like removing unused imports), with no functional changes intended.
Reviewed by Cursor Bugbot for commit
ff9aec3c35. Bugbot is set up for automated code reviews on this repo. Configure here.Reviewed — looks good. Almost entirely ruff format/lint cleanup, plus the new reusable-workflow wiring in
.github/workflows/ci.yamland an E402 fix insrc/conversation/app.py(imports lifted above_DecimalEncoder, no behavior change). Spot-checked the dropped imports (jsoninslack.py,datetime/timezoneingmail.py) and they are genuinely unused. No bugs, security issues, or convention violations to flag.Reviewed — looks good. CI workflow correctly delegates to the org's reusable Python+SAM and TypeScript+CDK workflows, and the ruff formatting changes are functionally inert. Spot-checked the two import removals (
jsoninshared/slack.py,datetime/timezoneinshared/gmail.py) and confirmed neither is referenced after removal, and the import reordering inconversation/app.pydoesn't introduce a circular import.