mirror of
https://github.com/Sea-Haven-Industries/shoc-pr-review-runner.git
synced 2026-10-04 09:21:56 +00:00
17 lines
707 B
Markdown
17 lines
707 B
Markdown
|
|
### 1. Overall Verdict
|
||
|
|
|
||
|
|
`REQUEST_CHANGES` - The overdue filter sends a type value the backend rejects.
|
||
|
|
|
||
|
|
### 2. Overall Review Comment
|
||
|
|
|
||
|
|
Reviewed at `abc1234`. The board work is close, but the overdue filter still maps to `types=99`, which the backend binds to a real enum member and silently returns the wrong rows.
|
||
|
|
|
||
|
|
### 3. Inline Comments
|
||
|
|
|
||
|
|
**`src/api/api-paths.ts:42`** - blocker
|
||
|
|
|
||
|
|
The overdue filter sends `types=99`; the backend expects `overdue=true` and binds 99 to WorkOrderType.Other, so the board silently shows wrong results.
|
||
|
|
|
||
|
|
**Fix:** Send `overdue=true` and drop the sentinel 99 from the types list.
|
||
|
|
**Test:** A unit test asserting the overdue filter produces `overdue=true` with no `types` param.
|