adam/shoc-pr-review-runner
1
0
Fork 0
mirror of https://github.com/Sea-Haven-Industries/shoc-pr-review-runner.git synced 2026-10-07 07:38:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
shoc-pr-review-runner/tests/fixtures/reviews/invalid-duplicate-sections.md

29 lines
440 B
Markdown
Raw Normal View History

feat: SHOC PR review runner, phase 1 Manually-dispatched GitHub Actions workflow that reviews SHOC pull requests in a clean environment: exact-head checkout of shoc-frontend-new and shoc-backend, clean build/test gates, a truthful evidence report, a single-shot Fireworks review, deterministic output validation, and published artifacts. The runner never writes to the product repositories or their pull requests. The review checklists move here from the reviewers' local Cursor commands so the instructions live outside both product repos. Phase 1 does not provision a database, start either application, or run live browser flows; the evidence report records those as NOT_RUN so a review cannot claim them. Security architecture: building a PR executes its author's code, so the workflow is split. The gates job runs that code holding no Fireworks key and revokes its App token first; the review job holds the key, executes no product code, and re-checks out this repo fresh. Product checkouts live outside the workspace, the App token is downscoped at mint time, gate results fail closed on any duplicate key, changed files are read from git objects rather than the filesystem, and the validator re-checks every claim against the gate table.
2026-07-29 12:04:27 -04:00
### 1. Overall Verdict
`REQUEST_CHANGES` - draft verdict, superseded below.
### 2. Overall Review Comment
Reviewed at `abc1234`. Draft.
### 3. Inline Comments
**`src/a.ts:10`** - blocker
Something is broken here.
**Fix:** Fix it.
**Test:** Test it.
### 1. Overall Verdict
`APPROVE` - final verdict after re-check, everything is clean.
### 2. Overall Review Comment
Reviewed at `abc1234`. All good.
### 3. Inline Comments
None.
Reference in a new issue Copy permalink