mirror of
https://github.com/Sea-Haven-Industries/shoc-frontend-new.git
synced 2026-09-30 12:43:13 +00:00
80be702733
* feat(vendors): structure the address into Street/City/State with autocomplete The Vendor form carried one free-text "Address (optional)" line, with City, State and Zip already present but hidden behind display:none, and a separate "Google Maps URL" input someone had to paste into by hand. Street Address, City and State are now three required fields. Typing three characters in Street Address offers up to four candidates; picking one fills all three at once, and typing without picking stays plain free text. The Google Maps URL input is gone — the location is derived from the address, the Street Address itself is the link in view mode, and a keyless map preview renders once all three parts are present. Zip stays in the payload but out of the form; the ticket scopes the visible set to three. The suggestion algorithm, candidate cities and copy are ported from the approved prototype rather than invented, so dev and design agree on what a dispatcher sees. Suggestions are deterministic for a given input on purpose: a reshuffling list moves a row out from under the pointer mid-click. Test fixtures that predate the requirement now carry an address, so each test still fails for the reason it is about. The two drawer tests asserting the stored-URL "Open in Google Maps" row are rewritten to the behaviour that replaced it. Delivers SH-271. * feat(work-orders): show the vendor location map in the Vendor dialog The last of SH-271's five acceptance bullets. The Work Order Vendor dialog gets one composed address line from the vendor dropdown payload, not the structured parts the form and detail drawer hold, so the preview takes the line directly — it is saved data either way, and the completeness rule exists to stop a map of half-typed input, not to reject a stored address. The dialog's hand-built maps URL now goes through the shared helper, so the link and the preview cannot drift apart. * test(vendors): update the browser specs and pixel baselines for the new address `npm run verify` does not run Playwright, so the first push went out with the browser suite still asserting the UI this ticket removes. Three assertions were stale: the combined "Address (optional)" input, the "Google Maps URL (optional)" input, and the detail drawer's separate "Open in Google Maps" row — now replaced by the Street Address itself being the link, checked against the derived href. A fourth test created a vendor without an address, which the new requirement blocks; it fills one, so the test still fails only for the reason it is about. Baselines regenerated in mcr.microsoft.com/playwright:v1.61.1-noble, the image CI uses — macOS font rendering produces different pixels. Exactly three of the sixteen were rewritten (vendor add, edit, detail); the rest, including every Work Orders shot, are byte-identical, which is the evidence that this change stays inside the surfaces it claims. * test(vendors): keep the map preview out of the pixel baselines The visual suite mocks `**/api/**` and nothing else, so the address map preview's iframe reached maps.google.com for real. Whether that frame paints, and what it paints, depends on the network and on what Google serves that minute — which is why `vendor-edit` failed in CI at 18178 differing pixels while passing in a container that could not reach Google. Regenerating the baseline would not have fixed it; it would have moved the flake. Aborting the request pins the frame to a blank box, so the shot measures our layout and nothing else. The committed baselines are unchanged by this — they were already correct — and a second container run with no --update passes 16/16, which is the evidence the shot is now stable rather than merely green once. * fix(vendors): complete structured address map flows * test(vendors): align add visual baseline with CI --------- Co-authored-by: Codex Review Integration <codex-review@local.invalid> |
||
|---|---|---|
| .. | ||
| address | ||
| auth | ||
| format | ||
| query | ||
| theme | ||
| dialog-guard.ts | ||
| env.ts | ||
| resolve-api-prefix-url.ts | ||
| time-utils.ts | ||
| utils.ts | ||