From 9bb0416346ac0968496e4415c2817394bc260f13 Mon Sep 17 00:00:00 2001
From: Alexandre Brandizzi <alex_brandizzi@hotmail.com>
Date: Fri, 25 Sep 2026 12:24:16 -0300
Subject: [PATCH] fix(sites): block delete until the open work-order check
 succeeds

---
 .../_components/site-delete-dialog.tsx        | 23 ++++++++++++++++---
 .../locations/site-delete.test.tsx            | 23 +++++++++++++++++++
 2 files changed, 43 insertions(+), 3 deletions(-)

diff --git a/src/app/(protected)/locations/_components/site-delete-dialog.tsx b/src/app/(protected)/locations/_components/site-delete-dialog.tsx
index bdd5bb08..56e3c232 100644
--- a/src/app/(protected)/locations/_components/site-delete-dialog.tsx
+++ b/src/app/(protected)/locations/_components/site-delete-dialog.tsx
@@ -21,6 +21,9 @@ interface SiteDeleteDialogProps {
   onDeleted: () => void;
 }
 
+const CHECK_FAILED_MESSAGE =
+  "Couldn't check this site for open work orders. Try again before deleting it.";
+
 function describeDeletion(siteCode: string, openCount: number): string {
   if (openCount === 0) {
     return `This will permanently remove ${siteCode} from Sites. This cannot be undone.`;
@@ -39,8 +42,16 @@ export function SiteDeleteDialog({
 }: SiteDeleteDialogProps) {
   const navigate = useNavigate();
   const deleteLocation = useDeleteLocation();
-  const { data: openWorkOrders, isLoading } = useSiteOpenWorkOrders(siteId, open);
+  const {
+    data: openWorkOrders,
+    isLoading,
+    isError,
+    isFetching,
+    refetch,
+  } = useSiteOpenWorkOrders(siteId, open);
   const openCount = openWorkOrders?.count ?? 0;
+  // Without the count the warning cannot be shown, so Delete waits for a successful check.
+  const countUnknown = isLoading || isError;
 
   return (
     <Dialog
@@ -56,7 +67,8 @@ export function SiteDeleteDialog({
       <DialogTitle id="site-delete-title">Delete this site?</DialogTitle>
       <DialogContent>
         {isLoading && <CircularProgress size={20} aria-label="Checking open work orders" />}
-        {!isLoading && (
+        {isError && <DialogContentText role="alert">{CHECK_FAILED_MESSAGE}</DialogContentText>}
+        {!countUnknown && (
           <DialogContentText>{describeDeletion(siteCode, openCount)}</DialogContentText>
         )}
       </DialogContent>
@@ -64,6 +76,11 @@ export function SiteDeleteDialog({
         <Button variant="text" onClick={onClose} disabled={deleteLocation.isPending}>
           Cancel
         </Button>
+        {isError && (
+          <Button variant="outlined" disabled={isFetching} onClick={() => void refetch()}>
+            Try again
+          </Button>
+        )}
         {openCount > 0 && (
           <Button
             variant="outlined"
@@ -75,7 +92,7 @@ export function SiteDeleteDialog({
         <Button
           variant="contained"
           color="error"
-          disabled={isLoading || deleteLocation.isPending}
+          disabled={countUnknown || deleteLocation.isPending}
           onClick={() => deleteLocation.mutate(siteId, { onSuccess: onDeleted })}
         >
           {deleteLocation.isPending ? "Deleting..." : "Delete"}
diff --git a/src/test/app/(protected)/locations/site-delete.test.tsx b/src/test/app/(protected)/locations/site-delete.test.tsx
index 19ec50fe..24e9d981 100644
--- a/src/test/app/(protected)/locations/site-delete.test.tsx
+++ b/src/test/app/(protected)/locations/site-delete.test.tsx
@@ -173,6 +173,29 @@ describe("Delete a site from the detail panel", () => {
     );
   });
 
+  it("blocks Delete when the open work-order check fails, until a retry succeeds", async () => {
+    getOpenWorkOrders.mockRejectedValueOnce(new Error("Server error"));
+    getOpenWorkOrders.mockResolvedValueOnce({ count: 2, workOrderIds: [101, 205] });
+    renderAs("Admin");
+    const panel = await openPanel();
+
+    fireEvent.click(within(panel).getByRole("button", { name: "Delete" }));
+    const dialog = await screen.findByRole("dialog", { name: "Delete this site?" });
+
+    expect(await within(dialog).findByRole("alert")).toHaveTextContent(
+      "Couldn't check this site for open work orders. Try again before deleting it.",
+    );
+    expect(within(dialog).getByRole("button", { name: "Delete" })).toBeDisabled();
+    expect(within(dialog).queryByText(/This cannot be undone/)).not.toBeInTheDocument();
+
+    fireEvent.click(within(dialog).getByRole("button", { name: "Try again" }));
+
+    expect(await within(dialog).findByText(/It still has 2 open work orders/)).toBeInTheDocument();
+    expect(within(dialog).getByRole("button", { name: "Delete" })).toBeEnabled();
+    expect(within(dialog).getByRole("button", { name: "View open work orders" })).toBeEnabled();
+    expect(deleteSite).not.toHaveBeenCalled();
+  });
+
   it("keeps the site and shows the server's refusal when the API answers 403", async () => {
     getOpenWorkOrders.mockResolvedValue({ count: 0, workOrderIds: [] });
     deleteSite.mockRejectedValue(forbidden());