diff --git a/src/app/(protected)/workorders/_components/comp-doc/comp-doc-dialog.tsx b/src/app/(protected)/workorders/_components/comp-doc/comp-doc-dialog.tsx index 74d9c75e..6fe91dd6 100644 --- a/src/app/(protected)/workorders/_components/comp-doc/comp-doc-dialog.tsx +++ b/src/app/(protected)/workorders/_components/comp-doc/comp-doc-dialog.tsx @@ -11,6 +11,7 @@ import { formatMediaSizeLimit, isWorkOrderDocumentsReadOnly, isWorkOrderFileTooLarge, + MAX_WORK_ORDER_COMPLETION_DOC_BYTES, } from "@/domain/work-orders/utils/work-order-media-limits"; import { useCompDocDialog } from "@/app/(protected)/workorders/_hooks/use-comp-doc-dialog"; import { CompDocDialogFooter } from "./comp-doc-dialog-footer"; @@ -35,8 +36,8 @@ type UseCompDocPdfUploadArgs = { }; function rejectCompDocPdf(file: File, rowVersion: string): string | null { - if (isWorkOrderFileTooLarge(file)) { - return `File exceeds the ${formatMediaSizeLimit()} limit.`; + if (isWorkOrderFileTooLarge(file, MAX_WORK_ORDER_COMPLETION_DOC_BYTES)) { + return `File exceeds the ${formatMediaSizeLimit(MAX_WORK_ORDER_COMPLETION_DOC_BYTES)} limit.`; } if (file.type !== "application/pdf" && !file.name.toLowerCase().endsWith(".pdf")) { return "Please upload a PDF file."; diff --git a/src/app/(protected)/workorders/_components/comp-doc/use-comp-doc-pdf-actions.ts b/src/app/(protected)/workorders/_components/comp-doc/use-comp-doc-pdf-actions.ts index 5d3b6475..23861a53 100644 --- a/src/app/(protected)/workorders/_components/comp-doc/use-comp-doc-pdf-actions.ts +++ b/src/app/(protected)/workorders/_components/comp-doc/use-comp-doc-pdf-actions.ts @@ -11,6 +11,7 @@ import { fmtDocNow } from "@/domain/work-orders/utils/completion-doc-state"; import { formatMediaSizeLimit, isWorkOrderFileTooLarge, + MAX_WORK_ORDER_COMPLETION_DOC_BYTES, } from "@/domain/work-orders/utils/work-order-media-limits"; type UseCompDocPdfActionsArgs = { @@ -55,8 +56,10 @@ export function useCompDocPdfActions({ function handleUploadPdf(files: FileList | null) { const file = files?.[0]; if (!file) return; - if (isWorkOrderFileTooLarge(file)) { - toast.error(`File exceeds the ${formatMediaSizeLimit()} limit.`); + if (isWorkOrderFileTooLarge(file, MAX_WORK_ORDER_COMPLETION_DOC_BYTES)) { + toast.error( + `File exceeds the ${formatMediaSizeLimit(MAX_WORK_ORDER_COMPLETION_DOC_BYTES)} limit.`, + ); return; } if (file.type !== "application/pdf" && !file.name.toLowerCase().endsWith(".pdf")) { diff --git a/src/app/(protected)/workorders/_components/detail/tabs/slide-over-completion-tab.tsx b/src/app/(protected)/workorders/_components/detail/tabs/slide-over-completion-tab.tsx index cf89d2bf..f88e3867 100644 --- a/src/app/(protected)/workorders/_components/detail/tabs/slide-over-completion-tab.tsx +++ b/src/app/(protected)/workorders/_components/detail/tabs/slide-over-completion-tab.tsx @@ -11,6 +11,7 @@ import { hasCompletionMediaGallery } from "@/domain/work-orders/utils/partition- import { formatMediaSizeLimit, isWorkOrderFileTooLarge, + MAX_WORK_ORDER_COMPLETION_DOC_BYTES, } from "@/domain/work-orders/utils/work-order-media-limits"; import { SlideOverCompletionActions } from "./slide-over-completion-actions"; import { SlideOverCompletionMedia } from "./slide-over-completion-media"; @@ -71,8 +72,10 @@ export function SlideOverCompletionTab({ const handlePdfSelected = (files: FileList | null) => { const file = files?.[0]; if (!file || !onUploadCompletionPdf) return; - if (isWorkOrderFileTooLarge(file)) { - toast.error(`File exceeds the ${formatMediaSizeLimit()} limit.`); + if (isWorkOrderFileTooLarge(file, MAX_WORK_ORDER_COMPLETION_DOC_BYTES)) { + toast.error( + `File exceeds the ${formatMediaSizeLimit(MAX_WORK_ORDER_COMPLETION_DOC_BYTES)} limit.`, + ); return; } if (file.type !== "application/pdf" && !file.name.toLowerCase().endsWith(".pdf")) { diff --git a/src/domain/work-orders/utils/work-order-media-limits.ts b/src/domain/work-orders/utils/work-order-media-limits.ts index 56b7aaef..00d9d261 100644 --- a/src/domain/work-orders/utils/work-order-media-limits.ts +++ b/src/domain/work-orders/utils/work-order-media-limits.ts @@ -1,8 +1,11 @@ import { isWorkOrderCompletionSurfaceReadOnly } from "@/domain/work-orders/utils/work-order-lock"; -/** Backend RequestSizeLimit for media and completion-doc uploads. */ +/** Backend RequestSizeLimit for media uploads and Extra Docs. */ export const MAX_WORK_ORDER_MEDIA_BYTES = 200_000_000; +/** Backend RequestSizeLimit for completion-document uploads. */ +export const MAX_WORK_ORDER_COMPLETION_DOC_BYTES = 50_000_000; + const MEDIA_MIME_TYPES = new Set([ "image/jpeg", "image/jpg", diff --git a/src/test/domain/work-orders/utils/work-order-media-limits.test.ts b/src/test/domain/work-orders/utils/work-order-media-limits.test.ts index 4a236b46..da86cd31 100644 --- a/src/test/domain/work-orders/utils/work-order-media-limits.test.ts +++ b/src/test/domain/work-orders/utils/work-order-media-limits.test.ts @@ -6,6 +6,7 @@ import { isWorkOrderExtraDocTypeAllowed, isWorkOrderFileTooLarge, isWorkOrderMediaTypeAllowed, + MAX_WORK_ORDER_COMPLETION_DOC_BYTES, MAX_WORK_ORDER_MEDIA_BYTES, workOrderExtraDocsAcceptAttribute, workOrderMediaAcceptAttribute, @@ -32,6 +33,23 @@ describe("work-order-media-limits", () => { expect(isWorkOrderFileTooLarge({ size: 10 } as File)).toBe(false); }); + it("caps completion-document uploads at 50_000_000 bytes and formats the completion copy", () => { + expect(MAX_WORK_ORDER_COMPLETION_DOC_BYTES).toBe(50_000_000); + expect(formatMediaSizeLimit(MAX_WORK_ORDER_COMPLETION_DOC_BYTES)).toBe("50 MB"); + expect( + isWorkOrderFileTooLarge( + { size: MAX_WORK_ORDER_COMPLETION_DOC_BYTES } as File, + MAX_WORK_ORDER_COMPLETION_DOC_BYTES, + ), + ).toBe(false); + expect( + isWorkOrderFileTooLarge( + { size: MAX_WORK_ORDER_COMPLETION_DOC_BYTES + 1 } as File, + MAX_WORK_ORDER_COMPLETION_DOC_BYTES, + ), + ).toBe(true); + }); + it("allows only JPG PNG MP4 MOV by MIME or extension", () => { expect(isWorkOrderMediaTypeAllowed({ name: "a.jpg", type: "image/jpeg" } as File)).toBe(true); expect(isWorkOrderMediaTypeAllowed({ name: "a.jpg", type: "image/jpg" } as File)).toBe(true);