From 8ed0c3a022450b9db74d8d14c3788d21170dc68a Mon Sep 17 00:00:00 2001 From: "arthur.bassi" Date: Wed, 12 Aug 2026 10:08:55 -0300 Subject: [PATCH] fix(work-orders): add severity to comp-doc and media fixtures after dev merge PR #45 introduced completion-doc, media and table-mutation fixtures that predate the required severity field, so the integrated head failed tsc. Fill severity on those row builders (null for PM, SEV 1 for the Emergency fixture) and type the mutation BASE_ROW instead of asserting it. --- .../comp-doc-dialog-completion-contract.test.tsx | 7 ++++++- .../(protected)/workorders/media-upload-modal-api.test.tsx | 1 + .../workorders/use-comp-doc-dialog-address-seed.test.tsx | 7 ++++++- .../use-work-order-table-mutations-completed-date.test.ts | 1 + .../use-cases/use-work-order-table-mutations.test.tsx | 5 +++-- 5 files changed, 17 insertions(+), 4 deletions(-) diff --git a/src/test/app/(protected)/workorders/comp-doc-dialog-completion-contract.test.tsx b/src/test/app/(protected)/workorders/comp-doc-dialog-completion-contract.test.tsx index 66bce349..138162c5 100644 --- a/src/test/app/(protected)/workorders/comp-doc-dialog-completion-contract.test.tsx +++ b/src/test/app/(protected)/workorders/comp-doc-dialog-completion-contract.test.tsx @@ -20,11 +20,12 @@ vi.mock("@/app/(protected)/workorders/_components/comp-doc/comp-doc-draft-toast" const SCHEDULED_ON = "2026-06-01"; function baseRow(overrides: Partial = {}): WorkOrderTableRow { - return { + const defaults: WorkOrderTableRow = { id: 42, woNumber: "WO-42", site: "SEA1", type: "PM", + severity: null, dispatcherId: "u1", dispatcherName: "Dispatcher", scheduledOn: SCHEDULED_ON, @@ -63,7 +64,11 @@ function baseRow(overrides: Partial = {}): WorkOrderTableRow rowVersion: "", dispatchRowVersion: "", flagColor: null, + }; + return { + ...defaults, ...overrides, + severity: overrides.severity !== undefined ? overrides.severity : defaults.severity, }; } diff --git a/src/test/app/(protected)/workorders/media-upload-modal-api.test.tsx b/src/test/app/(protected)/workorders/media-upload-modal-api.test.tsx index d74bfca8..9b57ae75 100644 --- a/src/test/app/(protected)/workorders/media-upload-modal-api.test.tsx +++ b/src/test/app/(protected)/workorders/media-upload-modal-api.test.tsx @@ -45,6 +45,7 @@ function baseRow(): WorkOrderTableRow { woNumber: "WO-7", site: "SEA1", type: "Emergency", + severity: 1, dispatcherId: "u1", dispatcherName: "Dispatcher", scheduledOn: "2026-06-01", diff --git a/src/test/app/(protected)/workorders/use-comp-doc-dialog-address-seed.test.tsx b/src/test/app/(protected)/workorders/use-comp-doc-dialog-address-seed.test.tsx index 3e734f4a..6d5871b2 100644 --- a/src/test/app/(protected)/workorders/use-comp-doc-dialog-address-seed.test.tsx +++ b/src/test/app/(protected)/workorders/use-comp-doc-dialog-address-seed.test.tsx @@ -15,11 +15,12 @@ vi.mock("@/domain/locations/use-cases/use-location-detail", () => ({ })); function baseRow(overrides: Partial = {}): WorkOrderTableRow { - return { + const defaults: WorkOrderTableRow = { id: 42, woNumber: "WO-42", site: "SEA1", type: "PM", + severity: null, dispatcherId: "u1", dispatcherName: "Dispatcher", scheduledOn: "2026-06-01", @@ -58,7 +59,11 @@ function baseRow(overrides: Partial = {}): WorkOrderTableRow rowVersion: "", dispatchRowVersion: "", flagColor: null, + }; + return { + ...defaults, ...overrides, + severity: overrides.severity !== undefined ? overrides.severity : defaults.severity, }; } diff --git a/src/test/domain/work-orders/use-cases/use-work-order-table-mutations-completed-date.test.ts b/src/test/domain/work-orders/use-cases/use-work-order-table-mutations-completed-date.test.ts index b9951795..399a64fa 100644 --- a/src/test/domain/work-orders/use-cases/use-work-order-table-mutations-completed-date.test.ts +++ b/src/test/domain/work-orders/use-cases/use-work-order-table-mutations-completed-date.test.ts @@ -17,6 +17,7 @@ const BASE_ROW = { id: 99, rowVersion: "AAAAAAA=", completedDate: "", + severity: null, } as WorkOrderTableRow; describe("runWorkOrderTablePatch completedDate", () => { diff --git a/src/test/domain/work-orders/use-cases/use-work-order-table-mutations.test.tsx b/src/test/domain/work-orders/use-cases/use-work-order-table-mutations.test.tsx index f7b8fc16..d2c97053 100644 --- a/src/test/domain/work-orders/use-cases/use-work-order-table-mutations.test.tsx +++ b/src/test/domain/work-orders/use-cases/use-work-order-table-mutations.test.tsx @@ -64,11 +64,12 @@ const BASE_DETAIL: WorkOrderDetail = { dispatches: [], }; -const BASE_ROW = { +const BASE_ROW: WorkOrderTableRow = { id: 42, woNumber: "WO-42", site: "SEA1", type: "PM", + severity: null, dispatcherId: "d1", dispatcherName: "Dispatcher", scheduledOn: "2026-06-01", @@ -107,7 +108,7 @@ const BASE_ROW = { rowVersion: "AAAAAAA=", dispatchRowVersion: "", flagColor: null, -} as WorkOrderTableRow; +}; describe("useWorkOrderTableMutations completion-doc persistence", () => { let serverState: WorkOrderDetail;