From 8031357dfa01df96460a0dad963b83cd6fb9fe28 Mon Sep 17 00:00:00 2001
From: Arthur Bassi <arthur.bassi@luby.com.br>
Date: Mon, 31 Aug 2026 10:22:27 -0300
Subject: [PATCH] fix(work-orders): assert GET User full display name

---
 src/domain/work-orders/api/work-orders-api.ts           | 2 +-
 src/test/domain/work-orders/api/work-orders-api.test.ts | 7 ++-----
 2 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/src/domain/work-orders/api/work-orders-api.ts b/src/domain/work-orders/api/work-orders-api.ts
index 8a298af7..ddebf957 100644
--- a/src/domain/work-orders/api/work-orders-api.ts
+++ b/src/domain/work-orders/api/work-orders-api.ts
@@ -120,7 +120,7 @@ function readOptionalString(item: Record<string, unknown>, ...keys: string[]): s
   return "";
 }
 
-/** GET User exposes `Name` as first name only; prefer FirstName + LastName when present. */
+/** GET User serializes `Name` as FirstName + LastName; compose those fields if present. */
 function mapUserDisplayName(item: Record<string, unknown>): string {
   const firstName = readOptionalString(item, "firstName", "FirstName");
   const lastName = readOptionalString(item, "lastName", "LastName");
diff --git a/src/test/domain/work-orders/api/work-orders-api.test.ts b/src/test/domain/work-orders/api/work-orders-api.test.ts
index 28ca8c18..d383aefc 100644
--- a/src/test/domain/work-orders/api/work-orders-api.test.ts
+++ b/src/test/domain/work-orders/api/work-orders-api.test.ts
@@ -204,10 +204,7 @@ const GET_USER_SERIALIZED_DIRECTORY = {
   data: [
     {
       Id: "s1",
-      Name: "Alex",
-      FirstName: "Alex",
-      LastName: "Smith",
-      UserName: "alex.smith",
+      Name: "Alex Smith",
     },
   ],
 };
@@ -217,7 +214,7 @@ describe("workOrdersApi.fetchUsers", () => {
     apiGet.mockReset();
   });
 
-  it("composes a full display name from the serialized GET User shape", async () => {
+  it("maps the serialized GET User Name as the full display name", async () => {
     apiGet.mockResolvedValue(GET_USER_SERIALIZED_DIRECTORY);
 
     const users = await workOrdersApi.fetchUsers();