From 70f8b303b5a6a338dded613c747a74987de97ec6 Mon Sep 17 00:00:00 2001 From: Alexandre Brandizzi Date: Fri, 25 Sep 2026 02:55:04 -0300 Subject: [PATCH] Show work-order uplift requests read-only in the Vendor Portal Revise and Withdraw now appear only on uplift requests the vendor raised. Requests raised from the work order stay visible without either control. --- .../_components/uplift-request-card.tsx | 6 +- .../vendor-portal/types/vendor-portal.ts | 2 + src/test/app/v/uplift-request-card.test.tsx | 59 +++++++++++++++++++ 3 files changed, 65 insertions(+), 2 deletions(-) create mode 100644 src/test/app/v/uplift-request-card.test.tsx diff --git a/src/app/v/[token]/dispatch/_components/uplift-request-card.tsx b/src/app/v/[token]/dispatch/_components/uplift-request-card.tsx index c9f4845e..511cfa08 100644 --- a/src/app/v/[token]/dispatch/_components/uplift-request-card.tsx +++ b/src/app/v/[token]/dispatch/_components/uplift-request-card.tsx @@ -35,8 +35,10 @@ export function UpliftRequestCard({ onCancelRevise, }: UpliftRequestCardProps) { const [revising, setRevising] = useState(false); - const canWithdraw = !locked && canAct && WITHDRAWABLE_STATUSES.has(request.status); - const canRevise = !locked && canAct && request.status === "ChangesRequested"; + // Requests raised from the work order are visible but read-only to the vendor. + const ownRequest = request.raisedByVendor !== false; + const canWithdraw = !locked && canAct && ownRequest && WITHDRAWABLE_STATUSES.has(request.status); + const canRevise = !locked && canAct && ownRequest && request.status === "ChangesRequested"; return (
diff --git a/src/domain/vendor-portal/types/vendor-portal.ts b/src/domain/vendor-portal/types/vendor-portal.ts index d9853b07..d5c1cada 100644 --- a/src/domain/vendor-portal/types/vendor-portal.ts +++ b/src/domain/vendor-portal/types/vendor-portal.ts @@ -66,6 +66,8 @@ export interface VendorPortalUpliftRequest { requestedNTE: number; currentNTE?: number; vendorReason?: string; + /** False when the request was raised from the work order; the vendor cannot revise or withdraw it. */ + raisedByVendor?: boolean; requestedAt?: string; decidedAt?: string; decidedByName?: string; diff --git a/src/test/app/v/uplift-request-card.test.tsx b/src/test/app/v/uplift-request-card.test.tsx new file mode 100644 index 00000000..e64693ef --- /dev/null +++ b/src/test/app/v/uplift-request-card.test.tsx @@ -0,0 +1,59 @@ +import { render, screen } from "@testing-library/react"; +import { describe, expect, it, vi } from "vitest"; +import { UpliftRequestCard } from "@/app/v/[token]/dispatch/_components/uplift-request-card"; +import type { VendorPortalUpliftRequest } from "@/domain/vendor-portal/types/vendor-portal"; + +function request(overrides: Partial = {}): VendorPortalUpliftRequest { + return { + id: 7, + status: "Pending", + requestedNTE: 1500, + currentNTE: 1000, + vendorReason: "Extra parts", + raisedByVendor: true, + ...overrides, + }; +} + +function renderCard(req: VendorPortalUpliftRequest) { + return render( + , + ); +} + +describe("UpliftRequestCard actions", () => { + it("offers Withdraw on a pending request the vendor raised", () => { + renderCard(request({ status: "Pending" })); + + expect(screen.getByRole("button", { name: /withdraw request/i })).toBeInTheDocument(); + expect(screen.queryByRole("button", { name: /revise/i })).not.toBeInTheDocument(); + }); + + it("offers Withdraw and Revise when changes are requested on a request the vendor raised", () => { + renderCard(request({ status: "ChangesRequested" })); + + expect(screen.getByRole("button", { name: /withdraw request/i })).toBeInTheDocument(); + expect(screen.getByRole("button", { name: /revise/i })).toBeInTheDocument(); + }); + + it.each(["Pending", "ChangesRequested"])( + "shows a %s request raised from the work order read-only", + (status) => { + renderCard(request({ status, raisedByVendor: false, requestedNTE: 90, currentNTE: 600 })); + + expect(screen.getByText(status)).toBeInTheDocument(); + expect(screen.queryByRole("button", { name: /withdraw request/i })).not.toBeInTheDocument(); + expect(screen.queryByRole("button", { name: /revise/i })).not.toBeInTheDocument(); + }, + ); +});