From 4eb929e1c8586fa2c744a125b7037911f59441cd Mon Sep 17 00:00:00 2001 From: Codex Review Integration Date: Wed, 16 Sep 2026 15:15:52 -0300 Subject: [PATCH] test(work-orders): remove query devtools overlay after navigation Also drops ticket keys from shipped comments and test names. Co-Authored-By: Claude Opus 5 (1M context) --- .../wo-number-sh-placeholder.spec.ts | 18 ++++++++++++++---- .../work-orders/utils/wo-number-input.ts | 2 +- ...able-wo-number-cell-sh-placeholder.test.tsx | 2 +- 3 files changed, 16 insertions(+), 6 deletions(-) diff --git a/e2e/work-orders/wo-number-sh-placeholder.spec.ts b/e2e/work-orders/wo-number-sh-placeholder.spec.ts index 6d14e801..e8bfaf61 100644 --- a/e2e/work-orders/wo-number-sh-placeholder.spec.ts +++ b/e2e/work-orders/wo-number-sh-placeholder.spec.ts @@ -16,6 +16,18 @@ async function fulfillJson(route: Route, body: unknown, status = 200) { await route.fulfill({ status, contentType: "application/json", body: JSON.stringify(body) }); } +async function hideQueryDevtools(page: Page) { + await page.addStyleTag({ + content: + ".tsqd-parent-container { display: none !important; pointer-events: none !important; }", + }); + await page.locator(".tsqd-parent-container").evaluateAll((nodes) => { + for (const node of nodes) { + node.remove(); + } + }); +} + const REAL_ROW = { id: 1000, woNumber: "12345678901", @@ -58,7 +70,7 @@ async function mockBoard(page: Page, patches: unknown[]) { ); } -test.describe("inline WO number SH placeholder (SH-320)", () => { +test.describe("inline WO number SH placeholder", () => { test.setTimeout(60_000); test.beforeEach(async ({ page }) => { @@ -66,9 +78,6 @@ test.describe("inline WO number SH placeholder (SH-320)", () => { await page.clock.resume(); await page.addInitScript((user) => { localStorage.setItem("auth", JSON.stringify(user)); - const style = document.createElement("style"); - style.textContent = ".tsqd-parent-container { display: none !important; }"; - document.documentElement.appendChild(style); }, TEST_USER); }); @@ -78,6 +87,7 @@ test.describe("inline WO number SH placeholder (SH-320)", () => { const mutations: unknown[] = []; await mockBoard(page, mutations); await page.goto("/workorders"); + await hideQueryDevtools(page); await expect(page.getByRole("heading", { name: "Work Orders" })).toBeVisible({ timeout: 20_000, }); diff --git a/src/domain/work-orders/utils/wo-number-input.ts b/src/domain/work-orders/utils/wo-number-input.ts index 39aec309..7f3ae624 100644 --- a/src/domain/work-orders/utils/wo-number-input.ts +++ b/src/domain/work-orders/utils/wo-number-input.ts @@ -25,7 +25,7 @@ export function isValidBoardWoNumber(woNumber: string): boolean { } /** - * SH-320: only an already-saved real APM number is protected from being replaced by an + * Only an already-saved real APM number is protected from being replaced by an * SH placeholder. A brand-new WO has no saved number, so the rule never applies there. */ export function isWoNumberDowngrade(savedWoNumber: string, nextWoNumber: string): boolean { diff --git a/src/test/app/(protected)/workorders/editable-wo-number-cell-sh-placeholder.test.tsx b/src/test/app/(protected)/workorders/editable-wo-number-cell-sh-placeholder.test.tsx index 5ae3cde3..ad16d2e8 100644 --- a/src/test/app/(protected)/workorders/editable-wo-number-cell-sh-placeholder.test.tsx +++ b/src/test/app/(protected)/workorders/editable-wo-number-cell-sh-placeholder.test.tsx @@ -35,7 +35,7 @@ function typeAndCommit(nextValue: string) { fireEvent.keyDown(input, { key: "Enter" }); } -describe("EditableWONumberCell SH placeholder numbers (SH-320)", () => { +describe("EditableWONumberCell SH placeholder numbers", () => { beforeEach(() => { vi.mocked(workOrdersApi.findByWoNumber).mockResolvedValue(null as never); vi.mocked(toast).mockClear();