adam/shoc-frontend-new
1
0
Fork 0
mirror of https://github.com/Sea-Haven-Industries/shoc-frontend-new.git synced 2026-10-06 10:02:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Merge pull request #233 from Sea-Haven-Industries/chore/staging-adoption-complete
Some checks are pending
Terraform CI / terraform (push) Waiting to run
Details
Frontend checks / Build and test (push) Waiting to run
Details
Frontend checks / governance (push) Waiting to run
Details
Frontend checks / Visual regression (push) Waiting to run
Details
Deploy Web / Resolve target (push) Waiting to run
Details
Deploy Web / Deploy SPA to (push) Blocked by required conditions
Details

Browse source 
chore(terraform): complete staging SPA adoption
This commit is contained in:
Adam Moussa 2026-09-18 16:57:34 -04:00 • committed by GitHub
commit 2600234b89
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
scripts/test-terraform-import-plan-check.py
View file

@ -340,13 +340,13 @@ class ImportPlanCheckerTests(unittest.TestCase):
self.assertFalse((REPOSITORY / "terraform" / "versions.tf").exists())
self.assertFalse((REPOSITORY / "terraform" / "main.tf").exists())
def test_dev_adoption_complete_is_pinned_in_locals(self) -> None:
def test_adoption_complete_is_pinned_in_locals(self) -> None:
dev = (REPOSITORY / "terraform/live/dev/main.tf").read_text(encoding="utf-8")
staging = (REPOSITORY / "terraform/live/staging/main.tf").read_text(
encoding="utf-8"
)
self.assertRegex(dev, r"adoption_complete\s+= true")
self.assertRegex(staging, r"adoption_complete\s+= false")
self.assertRegex(staging, r"adoption_complete\s+= true")
self.assertNotIn('variable "adoption_complete"', dev)
self.assertNotIn('variable "environment"', dev)
self.assertNotIn('variable "release_version_label"', dev)

2
terraform/live/README.md
View file

@ -1,7 +1,7 @@
# Live Terraform roots
`live/dev/` is the adopted HCP workspace `shoc-frontend-new-dev`.
`live/staging/` is `shoc-frontend-new-staging` (`adoption_complete = false`).
`live/staging/` is `shoc-frontend-new-staging` (`adoption_complete = true`).
Do not collapse these into one `terraform/` root in the same PR as application
CD. Flattening retargets two live HCP working directories and belongs in its

4
terraform/live/staging/main.tf
View file

@ -1,6 +1,6 @@
locals {
# Staging is not fully adopted. Pinned in code, never a workspace variable.
adoption_complete = false
# Controlled ownership transfer. Pinned in code, never a workspace variable.
adoption_complete = true
environment = "staging"
workspace_name = "shoc-frontend-new-staging"