Merge branch 'dev' into feature/sh-127-assigned-to-ownership

src/app/(protected)/vendors/_components/use-vendor-roster-form.ts

@@ -16,6 +16,9 @@ import {
 } from "@/domain/vendors/use-cases/use-save-vendor-company-roster";
 import { useVendorRosterResolver } from "./use-vendor-roster-resolver";
 
+const VENDOR_ROSTER_NO_CHANGES_MESSAGE =
+  "No changes to save. Enter technician details or update a company field.";
+
 const EDITABLE_COMPANY_FIELDS = [
   "name",
   "companyPhone",
@@ -180,7 +183,7 @@ export function useVendorRosterForm({
     if (mode === "create" && selection.selectedRoster != null) {
       const selected = selection.selectedRoster;
       if (!buildAdditiveRosterPatch(selected, values, selected.rowVersion, editedCompanyFields)) {
-        toast.error("Enter at least one technician to add to this vendor.");
+        toast.error(VENDOR_ROSTER_NO_CHANGES_MESSAGE);
         return;
       }
       save.mutate(

src/app/(protected)/vendors/_components/vendor-roster-form-fields.tsx

@@ -358,7 +358,7 @@ function TechniciansFieldArray({
     <Box>
       <Stack direction="row" sx={{ alignItems: "center", justifyContent: "space-between" }}>
         <Typography variant="subtitle2" className="font-semibold uppercase">
-          Technicians ({fields.length})
+          Technician details (optional)
         </Typography>
         <Button
           size="small"

src/test/app/(protected)/vendors/use-vendor-roster-form.test.tsx

@@ -2,6 +2,7 @@ import { act, renderHook, waitFor } from "@testing-library/react";
 import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
 import type { ReactNode } from "react";
 import { useController, useFieldArray } from "react-hook-form";
+import { toast } from "react-toastify";
 import { beforeEach, describe, expect, it, vi } from "vitest";
 
 const rosterGet = vi.fn();
@@ -428,6 +429,7 @@ describe("useVendorRosterForm additive add flow (SH-250)", () => {
   beforeEach(() => {
     rosterGet.mockReset();
     saveMutate.mockReset();
+    vi.mocked(toast.error).mockReset();
   });
 
   it("issues an additive add — never update — when an existing company is selected", async () => {
@@ -498,6 +500,10 @@ describe("useVendorRosterForm additive add flow (SH-250)", () => {
     });
 
     expect(saveMutate).not.toHaveBeenCalled();
+    expect(vi.mocked(toast.error)).toHaveBeenCalledTimes(1);
+    expect(vi.mocked(toast.error)).toHaveBeenCalledWith(
+      "No changes to save. Enter technician details or update a company field.",
+    );
   });
 
   it("keeps the entered technician and retries with the fresh rowVersion after reload", async () => {

src/test/app/(protected)/vendors/vendor-create-modal.test.tsx

@@ -75,6 +75,14 @@ describe("VendorCreateModal validation", () => {
     );
   });
 
+  it("labels the optional technician section without counting blank drafts", () => {
+    renderCreateModal();
+
+    expect(screen.getByText("Technician details (optional)")).toBeInTheDocument();
+    expect(screen.queryByText("Technicians (1)")).not.toBeInTheDocument();
+    expect(screen.getByRole("textbox", { name: "Technician name (optional)" })).toBeVisible();
+  });
+
   it("labels the plain company field exactly, required, with no generated asterisk", () => {
     renderWithProviders(<PlainCompanyFieldsHarness />, { route: "/vendors", withAuth: false });