From 090c9776590007d32b11f395c3e8e97a64f04406 Mon Sep 17 00:00:00 2001
From: Alexandre Brandizzi <alex_brandizzi@hotmail.com>
Date: Fri, 25 Sep 2026 17:03:15 -0300
Subject: [PATCH] fix(uplifts): report a failed approvals queue once, inline,
 without the global toast

---
 .../uplifts/use-cases/use-uplifts-queue.ts    |  3 ++
 .../use-cases/use-uplifts-queue.test.tsx      | 40 +++++++++++++++++++
 2 files changed, 43 insertions(+)
 create mode 100644 src/test/domain/uplifts/use-cases/use-uplifts-queue.test.tsx

diff --git a/src/domain/uplifts/use-cases/use-uplifts-queue.ts b/src/domain/uplifts/use-cases/use-uplifts-queue.ts
index 9ebcf4bd..256250ad 100644
--- a/src/domain/uplifts/use-cases/use-uplifts-queue.ts
+++ b/src/domain/uplifts/use-cases/use-uplifts-queue.ts
@@ -10,5 +10,8 @@ export function useUpliftsQueue(
     queryKey: queryKeys.uplifts.queue(params as Record<string, unknown>),
     queryFn: () => upliftsApi.list(params),
     placeholderData: keepPreviousData,
+    // The Uplift Approvals page reports a failed queue inline, so the global toast
+    // would announce the same failure twice.
+    meta: { suppressErrorToast: true },
   });
 }
diff --git a/src/test/domain/uplifts/use-cases/use-uplifts-queue.test.tsx b/src/test/domain/uplifts/use-cases/use-uplifts-queue.test.tsx
new file mode 100644
index 00000000..f71eb8d4
--- /dev/null
+++ b/src/test/domain/uplifts/use-cases/use-uplifts-queue.test.tsx
@@ -0,0 +1,40 @@
+import { QueryClientProvider } from "@tanstack/react-query";
+import { renderHook, waitFor } from "@testing-library/react";
+import type { ReactNode } from "react";
+import { afterEach, describe, expect, it, vi } from "vitest";
+import { upliftsApi } from "@/domain/uplifts/api/uplifts-api";
+import { useUpliftsQueue } from "@/domain/uplifts/use-cases/use-uplifts-queue";
+import { createAppQueryClient } from "@/lib/query/query-client";
+
+const toastMocks = vi.hoisted(() => ({ error: vi.fn() }));
+
+vi.mock("react-toastify", () => ({
+  toast: { error: toastMocks.error, success: vi.fn() },
+}));
+
+afterEach(() => {
+  vi.restoreAllMocks();
+  toastMocks.error.mockReset();
+});
+
+describe("useUpliftsQueue", () => {
+  it("does not show the global error toast, since the approvals page reports the failure inline", async () => {
+    vi.spyOn(upliftsApi, "list").mockRejectedValue(new Error("Failed to load uplift queue"));
+    // The real app query client runs the QueryCache's global onError handler, which
+    // toasts unless the query opts out.
+    const queryClient = createAppQueryClient();
+    queryClient.setDefaultOptions({ queries: { retry: false } });
+
+    const { result } = renderHook(
+      () => useUpliftsQueue({ status: "Rejected", page: 1, pageSize: 25 }),
+      {
+        wrapper: ({ children }: { children: ReactNode }) => (
+          <QueryClientProvider client={queryClient}>{children}</QueryClientProvider>
+        ),
+      },
+    );
+
+    await waitFor(() => expect(result.current.error).toBeInstanceOf(Error));
+    expect(toastMocks.error).not.toHaveBeenCalled();
+  });
+});