mirror of
https://github.com/Sea-Haven-Industries/shoc-backend.git
synced 2026-09-30 17:43:12 +00:00
* refactor(api): enforce service and data-service boundaries * refactor(api): complete feature service boundaries * refactor(identity): enforce service and data boundaries * refactor(vendors): enforce service and data boundaries * refactor(workorders): enforce service and data boundaries * refactor(backend): enforce architecture and optimize dispatch * style(backend): format changed architecture files * fix(architecture): address backend review follow-ups * fix(backend): sanitize exception disclosure in changed API endpoints Replace raw exception-message disclosure (ex.Message) returned to API callers with a stable sanitized public message plus correlated structured internal logging, across the endpoints changed in this PR. - Add SanitizedErrors helper: logs the original exception at Error with a generated correlation id and returns a stable public message referencing it so support can trace without exposing internals. - Inject ILogger<T> into the 14 changed controllers and route every ex.Message/dbex.Message disclosure through the helper, preserving status codes, response shapes, and business data (e.g. OpenWorkOrders). - Leave FluentValidation (vex.Errors) and existing fixed-message catches untouched; out-of-scope controllers (Account/Contact/Employee/Asset/ PMSchedule) are unchanged. - Add focused tests proving internal exception text is not returned and that Error logging carrying the original exception is invoked. * fix(architecture): abstract job run state access * style: format board update service * test: use collection assertion idiom
125 lines
4.5 KiB
C#
125 lines
4.5 KiB
C#
using Data.SeaHavenIndustries;
|
|
using Microsoft.EntityFrameworkCore;
|
|
using SeaHaven.DataServices.Dto;
|
|
using SeaHaven.DataServices.Interfaces;
|
|
|
|
namespace SeaHaven.DataServices.Implementation
|
|
{
|
|
public class SettingsDataService : ISettingsDataService
|
|
{
|
|
private readonly ApplicationDbContext _context;
|
|
|
|
public SettingsDataService(ApplicationDbContext context)
|
|
{
|
|
_context = context;
|
|
}
|
|
|
|
public async Task AddCategoryAsync(string name, CancellationToken cancellationToken)
|
|
{
|
|
var category = new Category { Name = name };
|
|
await _context.Categories.AddAsync(category, cancellationToken);
|
|
await _context.SaveChangesAsync(cancellationToken);
|
|
}
|
|
|
|
public async Task<bool> UpdateCategoryAsync(int id, string name, CancellationToken cancellationToken)
|
|
{
|
|
var exist = await _context.Categories
|
|
.Where(w => w.Id == id)
|
|
.FirstOrDefaultAsync(cancellationToken);
|
|
if (exist == null)
|
|
return false;
|
|
|
|
exist.Name = name;
|
|
_context.Categories.Update(exist);
|
|
await _context.SaveChangesAsync(cancellationToken);
|
|
return true;
|
|
}
|
|
|
|
public async Task<bool> DeleteCategoryCascadeAsync(int id, CancellationToken cancellationToken)
|
|
{
|
|
var exist = await _context.Categories
|
|
.Where(w => w.Id == id)
|
|
.FirstOrDefaultAsync(cancellationToken);
|
|
if (exist == null)
|
|
return false;
|
|
|
|
var templates = await _context.Templates.Where(w => w.CategoryId == id).ToListAsync(cancellationToken);
|
|
if (templates != null)
|
|
{
|
|
_context.RemoveRange(templates);
|
|
}
|
|
|
|
var workOrderCategories = await _context.workOrderCategories.Where(w => w.CategoryId == id).ToListAsync(cancellationToken);
|
|
if (workOrderCategories != null)
|
|
{
|
|
_context.RemoveRange(workOrderCategories);
|
|
}
|
|
|
|
_context.Remove(exist);
|
|
await _context.SaveChangesAsync(cancellationToken);
|
|
return true;
|
|
}
|
|
|
|
public async Task<(IReadOnlyList<SettingsCategoryItemDTO> Items, int Total)> GetCategoryListPagedAsync(
|
|
int page,
|
|
int pageSize,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
var totalCount = await _context.Categories.CountAsync(cancellationToken);
|
|
var data = await _context.Categories
|
|
.AsNoTracking()
|
|
.Select(s => new SettingsCategoryItemDTO
|
|
{
|
|
Id = s.Id,
|
|
Name = s.Name
|
|
})
|
|
.OrderByDescending(d => d.Id)
|
|
.Skip((page - 1) * pageSize)
|
|
.Take(pageSize)
|
|
.ToListAsync(cancellationToken);
|
|
|
|
return (data, totalCount);
|
|
}
|
|
|
|
public async Task<(IReadOnlyList<WorkOrder> Items, int Total)> GetTemplatesPagedAsync(
|
|
int page,
|
|
int pageSize,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
var totalCount = await _context.workOrders.CountAsync(w => w.istemplate == true, cancellationToken);
|
|
var data = await _context.workOrders
|
|
.AsNoTracking()
|
|
.Where(w => w.istemplate == true)
|
|
.OrderByDescending(d => d.Id)
|
|
.Skip((page - 1) * pageSize)
|
|
.Take(pageSize)
|
|
.ToListAsync(cancellationToken);
|
|
|
|
return (data, totalCount);
|
|
}
|
|
|
|
public async Task<(IReadOnlyList<ApplicationUser> Users, int Total)> GetUsersPagedAsync(
|
|
string? search,
|
|
int page,
|
|
int pageSize,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
var totalCount = await _context.Users.CountAsync(cancellationToken);
|
|
var users = await _context.Users
|
|
.AsNoTracking()
|
|
.Where(w => (w.FirstName ?? "").ToLower().Contains((search ?? "").ToLower()))
|
|
.OrderByDescending(d => d.Id)
|
|
.Skip((page - 1) * pageSize)
|
|
.Take(pageSize)
|
|
.ToListAsync(cancellationToken);
|
|
|
|
return (users, totalCount);
|
|
}
|
|
|
|
public async Task<IReadOnlyList<string>> GetRoleNamesAsync(CancellationToken cancellationToken)
|
|
{
|
|
var roles = await _context.Roles.AsNoTracking().ToListAsync(cancellationToken);
|
|
return roles.Select(r => r.Name!).ToList();
|
|
}
|
|
}
|
|
}
|