mirror of
https://github.com/Sea-Haven-Industries/shoc-backend.git
synced 2026-09-30 13:03:12 +00:00
* refactor(api): enforce service and data-service boundaries * refactor(api): complete feature service boundaries * refactor(identity): enforce service and data boundaries * refactor(vendors): enforce service and data boundaries * refactor(workorders): enforce service and data boundaries * refactor(backend): enforce architecture and optimize dispatch * style(backend): format changed architecture files * fix(architecture): address backend review follow-ups * fix(backend): sanitize exception disclosure in changed API endpoints Replace raw exception-message disclosure (ex.Message) returned to API callers with a stable sanitized public message plus correlated structured internal logging, across the endpoints changed in this PR. - Add SanitizedErrors helper: logs the original exception at Error with a generated correlation id and returns a stable public message referencing it so support can trace without exposing internals. - Inject ILogger<T> into the 14 changed controllers and route every ex.Message/dbex.Message disclosure through the helper, preserving status codes, response shapes, and business data (e.g. OpenWorkOrders). - Leave FluentValidation (vex.Errors) and existing fixed-message catches untouched; out-of-scope controllers (Account/Contact/Employee/Asset/ PMSchedule) are unchanged. - Add focused tests proving internal exception text is not returned and that Error logging carrying the original exception is invoked. * fix(architecture): abstract job run state access * style: format board update service * test: use collection assertion idiom
66 lines
2.6 KiB
C#
66 lines
2.6 KiB
C#
using Microsoft.Extensions.Options;
|
|
using SeaHaven.DataServices.Interfaces;
|
|
using SeaHaven.Services.DTOs;
|
|
using SeaHaven.Services.Interfaces;
|
|
|
|
namespace SeaHaven.Services.Implementation
|
|
{
|
|
public class WorkOrderOpsHealthService : IWorkOrderOpsHealthService
|
|
{
|
|
private readonly IWorkOrderOpsHealthDataService _healthData;
|
|
private readonly IWorkOrderJobRunStateAccessor _runState;
|
|
private readonly WorkOrderOpsHealthOptions _options;
|
|
|
|
public WorkOrderOpsHealthService(
|
|
IWorkOrderOpsHealthDataService healthData,
|
|
IWorkOrderJobRunStateAccessor runState,
|
|
IOptions<WorkOrderOpsHealthOptions> options)
|
|
{
|
|
_healthData = healthData;
|
|
_runState = runState;
|
|
_options = options.Value;
|
|
}
|
|
|
|
public async Task<WorkOrderOpsHealthDto> GetHealthAsync(CancellationToken cancellationToken = default)
|
|
{
|
|
var since = DateTime.UtcNow.AddHours(-24);
|
|
|
|
var syncRejected = await _healthData.CountSyncRejectedSinceAsync(since, cancellationToken);
|
|
var fieldLocks = await _healthData.CountFieldLocksAsync(cancellationToken);
|
|
|
|
var state = _runState.State;
|
|
var ledgerWeekRolled = await _healthData.GetLastWeekRolledProcessedAtAsync(cancellationToken);
|
|
|
|
return new WorkOrderOpsHealthDto
|
|
{
|
|
LastWeekRolledRunUtc = state.LastWeekRolledRunUtc ?? ledgerWeekRolled,
|
|
LastPastDueCacheRunUtc = state.LastPastDueCacheRunUtc,
|
|
LastWeekRolledError = state.LastWeekRolledError,
|
|
LastPastDueCacheError = state.LastPastDueCacheError,
|
|
SyncRejectedLast24h = syncRejected,
|
|
FieldLockCount = fieldLocks,
|
|
SyncEnabled = _options.SyncEnabled,
|
|
IngestEnabled = _options.IngestEnabled,
|
|
LegacyDeprecationEnabled = _options.LegacyDeprecationEnabled,
|
|
LegacySunsetDate = _options.LegacySunsetDate,
|
|
CheckedAtUtc = DateTime.UtcNow
|
|
};
|
|
}
|
|
}
|
|
|
|
/// <summary>Options bridged from API configuration for health snapshots.</summary>
|
|
public class WorkOrderOpsHealthOptions
|
|
{
|
|
public bool SyncEnabled { get; set; } = true;
|
|
public bool IngestEnabled { get; set; } = true;
|
|
public bool LegacyDeprecationEnabled { get; set; }
|
|
public string? LegacySunsetDate { get; set; }
|
|
}
|
|
|
|
/// <summary>Shared in-memory job run timestamps (API hosted services + ops health).</summary>
|
|
public class WorkOrderJobRunStateAccessor : IWorkOrderJobRunStateAccessor
|
|
{
|
|
public WorkOrderJobRunState State { get; } = new();
|
|
}
|
|
|
|
}
|