mirror of
https://github.com/Sea-Haven-Industries/shoc-backend.git
synced 2026-09-30 04:53:11 +00:00
* refactor(api): enforce service and data-service boundaries * refactor(api): complete feature service boundaries * refactor(identity): enforce service and data boundaries * refactor(vendors): enforce service and data boundaries * refactor(workorders): enforce service and data boundaries * refactor(backend): enforce architecture and optimize dispatch * style(backend): format changed architecture files * fix(architecture): address backend review follow-ups * fix(backend): sanitize exception disclosure in changed API endpoints Replace raw exception-message disclosure (ex.Message) returned to API callers with a stable sanitized public message plus correlated structured internal logging, across the endpoints changed in this PR. - Add SanitizedErrors helper: logs the original exception at Error with a generated correlation id and returns a stable public message referencing it so support can trace without exposing internals. - Inject ILogger<T> into the 14 changed controllers and route every ex.Message/dbex.Message disclosure through the helper, preserving status codes, response shapes, and business data (e.g. OpenWorkOrders). - Leave FluentValidation (vex.Errors) and existing fixed-message catches untouched; out-of-scope controllers (Account/Contact/Employee/Asset/ PMSchedule) are unchanged. - Add focused tests proving internal exception text is not returned and that Error logging carrying the original exception is invoked. * fix(architecture): abstract job run state access * style: format board update service * test: use collection assertion idiom
104 lines
3.5 KiB
C#
104 lines
3.5 KiB
C#
using Api.SeaHavenIndustries.Options;
|
|
using Microsoft.AspNetCore.Authorization;
|
|
using Microsoft.AspNetCore.Mvc;
|
|
using Microsoft.Extensions.Options;
|
|
using SeaHaven.Services.Interfaces;
|
|
|
|
namespace Api.SeaHavenIndustries.Controllers
|
|
{
|
|
[Authorize(Roles = "Admin")]
|
|
[ApiController]
|
|
[Route("api/[controller]")]
|
|
public class SyncController : Controller
|
|
{
|
|
private readonly ISyncService _syncService;
|
|
private readonly SyncOptions _syncOptions;
|
|
|
|
public SyncController(ISyncService syncService, IOptions<SyncOptions> syncOptions)
|
|
{
|
|
_syncService = syncService;
|
|
_syncOptions = syncOptions.Value;
|
|
}
|
|
|
|
private IActionResult? SyncDisabledResult()
|
|
{
|
|
if (_syncOptions.Enabled)
|
|
return null;
|
|
|
|
return StatusCode(StatusCodes.Status503ServiceUnavailable, new
|
|
{
|
|
message = "DynamoDB sync bridge is disabled. Use POST /api/workorders/ingest."
|
|
});
|
|
}
|
|
|
|
[HttpPost("WorkOrders")]
|
|
public async Task<IActionResult> SyncWorkOrders(CancellationToken cancellationToken)
|
|
{
|
|
if (SyncDisabledResult() is { } disabled)
|
|
return disabled;
|
|
|
|
var result = await _syncService.SyncWorkOrdersAsync(cancellationToken);
|
|
return Ok(result);
|
|
}
|
|
|
|
[HttpPost("Comments")]
|
|
public async Task<IActionResult> SyncComments(CancellationToken cancellationToken)
|
|
{
|
|
if (SyncDisabledResult() is { } disabled)
|
|
return disabled;
|
|
|
|
var result = await _syncService.SyncCommentsAsync(cancellationToken);
|
|
return Ok(result);
|
|
}
|
|
|
|
[HttpPost("BackfillInternalWONumbers")]
|
|
public async Task<IActionResult> BackfillInternalWONumbers(CancellationToken cancellationToken)
|
|
{
|
|
if (SyncDisabledResult() is { } disabled)
|
|
return disabled;
|
|
|
|
var result = await _syncService.BackfillInternalWONumbersAsync(cancellationToken);
|
|
return Ok(result);
|
|
}
|
|
|
|
[HttpPost("BackfillDispatchNumbers")]
|
|
public async Task<IActionResult> BackfillDispatchNumbers(CancellationToken cancellationToken)
|
|
{
|
|
if (SyncDisabledResult() is { } disabled)
|
|
return disabled;
|
|
|
|
var result = await _syncService.BackfillDispatchNumbersAsync(cancellationToken);
|
|
return Ok(result);
|
|
}
|
|
|
|
[HttpPost("VendorReplies")]
|
|
public async Task<IActionResult> SyncVendorReplies(CancellationToken cancellationToken)
|
|
{
|
|
if (SyncDisabledResult() is { } disabled)
|
|
return disabled;
|
|
|
|
var result = await _syncService.SyncVendorRepliesAsync(cancellationToken);
|
|
return Ok(result);
|
|
}
|
|
|
|
[HttpPost("BackfillCommentTypes")]
|
|
public async Task<IActionResult> BackfillCommentTypes(CancellationToken cancellationToken)
|
|
{
|
|
if (SyncDisabledResult() is { } disabled)
|
|
return disabled;
|
|
|
|
var result = await _syncService.BackfillCommentTypesAsync(cancellationToken);
|
|
return Ok(result);
|
|
}
|
|
|
|
[HttpPost("All")]
|
|
public async Task<IActionResult> SyncAll(CancellationToken cancellationToken)
|
|
{
|
|
if (SyncDisabledResult() is { } disabled)
|
|
return disabled;
|
|
|
|
var result = await _syncService.SyncAllAsync(cancellationToken);
|
|
return Ok(result);
|
|
}
|
|
}
|
|
}
|