mirror of
https://github.com/Sea-Haven-Industries/shoc-backend.git
synced 2026-09-30 06:03:12 +00:00
Editing a work order's POC never reached the backend: no update path wrote
PocName/PocPhone/PocNotes, so the optimistic UI edit was lost on refetch and
the completion freeze captured the Site contact instead of the manual value,
and nothing was audited.
- Add tenant-scoped PATCH api/workorders/{id}/poc via new WorkOrderPocService
+ WorkOrderPocDataService: persists the override, stages FieldChanged audit
entries (which also write field locks so sync never overwrites a manual POC),
and enforces row-version concurrency and terminal-status read-only rules.
- Lock semantics (SH-190): a manual POC away from the Site's live contacts is
stored WO-level; an edit equal to a live Site contact (or blanking name+phone)
stores nothing so the WO follows the Site. PocCustomized exposes the state.
- Board projection, completion freeze and create now share one Site-contact
fallback (first non-deleted contact by SiteContactOrder) so a never-overridden
WO keeps following the Site, including at create when the wizard prefills it.
- Route contract baseline gains PATCH {id:int}/poc.
113 lines
4.4 KiB
C#
113 lines
4.4 KiB
C#
using Data.SeaHavenIndustries;
|
|
using Data.SeaHavenIndustries.Enums;
|
|
using Microsoft.EntityFrameworkCore;
|
|
using SeaHaven.DataServices.Implementation;
|
|
using SeaHaven.Services.DTOs;
|
|
using SeaHaven.Services.Implementation;
|
|
using SeaHaven.Services.Interfaces;
|
|
using SeaHaven.Services.Validation;
|
|
|
|
namespace SeaHavenIndustries.Tests;
|
|
|
|
public class WorkOrderBoardCreateSyncLockTests
|
|
{
|
|
[Fact]
|
|
public async Task AfterShocCreate_SyncRejectsLockedSiteCode()
|
|
{
|
|
var options = new DbContextOptionsBuilder<ApplicationDbContext>()
|
|
.UseInMemoryDatabase(Guid.NewGuid().ToString())
|
|
.Options;
|
|
await using var context = new ApplicationDbContext(options);
|
|
WorkOrderAccountTestHelpers.SeedBoardCreateScope(context);
|
|
|
|
var boardData = new WorkOrderBoardDataService(context);
|
|
var mutationData = new WorkOrderBoardMutationDataService(context);
|
|
var resolver = WorkOrderAccountTestHelpers.Resolver(context);
|
|
var boardService = new WorkOrderBoardService(boardData, resolver);
|
|
var fieldLocks = new WorkOrderFieldLockService(new WorkOrderFieldLockDataService(context));
|
|
var audit = new WorkOrderAuditService(new WorkOrderAuditDataService(context), fieldLocks);
|
|
var createService = new WorkOrderBoardCreateService(
|
|
boardData,
|
|
mutationData,
|
|
boardService,
|
|
audit,
|
|
new WorkOrderBoardCreateValidation(),
|
|
resolver,
|
|
new WorkOrderPocDataService(context));
|
|
var policy = new SyncFieldMergePolicy(fieldLocks);
|
|
|
|
await createService.CreateAsync(new WorkOrderBoardCreateRequestDto
|
|
{
|
|
WorkOrderType = WorkOrderType.PM,
|
|
SiteCode = "BK5",
|
|
LocationId = 1
|
|
}, WorkOrderAccountTestHelpers.AccountUser("dispatcher-1"), "dispatcher-1");
|
|
|
|
var wo = await context.workOrders.SingleAsync();
|
|
var syncContext = new WorkOrderSyncContext
|
|
{
|
|
WorkOrder = wo,
|
|
FieldLocks = fieldLocks,
|
|
Audit = audit
|
|
};
|
|
|
|
var applied = await policy.TryApplyAsync(syncContext, "SiteCode", "SYNC-SITE");
|
|
|
|
Assert.False(applied);
|
|
Assert.Equal("BK5", wo.SiteCode);
|
|
|
|
var rejected = await context.WorkOrderAuditLogs
|
|
.SingleAsync(l => l.Action == "SyncRejected" && l.FieldName == "SiteCode");
|
|
Assert.Equal("SYNC-SITE", rejected.NewValue);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task AfterShocCreate_SyncCanUpdateUnlockedField_NotInShocSet()
|
|
{
|
|
var options = new DbContextOptionsBuilder<ApplicationDbContext>()
|
|
.UseInMemoryDatabase(Guid.NewGuid().ToString())
|
|
.Options;
|
|
await using var context = new ApplicationDbContext(options);
|
|
WorkOrderAccountTestHelpers.SeedBoardCreateScope(context);
|
|
|
|
var boardData = new WorkOrderBoardDataService(context);
|
|
var mutationData = new WorkOrderBoardMutationDataService(context);
|
|
var resolver = WorkOrderAccountTestHelpers.Resolver(context);
|
|
var boardService = new WorkOrderBoardService(boardData, resolver);
|
|
var fieldLocks = new WorkOrderFieldLockService(new WorkOrderFieldLockDataService(context));
|
|
var audit = new WorkOrderAuditService(new WorkOrderAuditDataService(context), fieldLocks);
|
|
var createService = new WorkOrderBoardCreateService(
|
|
boardData,
|
|
mutationData,
|
|
boardService,
|
|
audit,
|
|
new WorkOrderBoardCreateValidation(),
|
|
resolver,
|
|
new WorkOrderPocDataService(context));
|
|
var policy = new SyncFieldMergePolicy(fieldLocks);
|
|
|
|
await createService.CreateAsync(new WorkOrderBoardCreateRequestDto
|
|
{
|
|
WorkOrderType = WorkOrderType.PM,
|
|
SiteCode = "BK5",
|
|
LocationId = 1
|
|
}, WorkOrderAccountTestHelpers.AccountUser("dispatcher-1"), "dispatcher-1");
|
|
|
|
var wo = await context.workOrders.SingleAsync();
|
|
wo.Customer = "Original";
|
|
await context.SaveChangesAsync();
|
|
|
|
var syncContext = new WorkOrderSyncContext
|
|
{
|
|
WorkOrder = wo,
|
|
FieldLocks = fieldLocks,
|
|
Audit = audit
|
|
};
|
|
|
|
// Customer is not in SyncFieldMergePolicy apply switch — use Description which wasn't set on create
|
|
var applied = await policy.TryApplyAsync(syncContext, "Description", "From sync");
|
|
|
|
Assert.True(applied);
|
|
Assert.Equal("From sync", wo.Description);
|
|
}
|
|
}
|