mirror of
https://github.com/Sea-Haven-Industries/shoc-backend.git
synced 2026-09-30 09:33:13 +00:00
* refactor(api): enforce service and data-service boundaries * refactor(api): complete feature service boundaries * refactor(identity): enforce service and data boundaries * refactor(vendors): enforce service and data boundaries * refactor(workorders): enforce service and data boundaries * refactor(backend): enforce architecture and optimize dispatch * style(backend): format changed architecture files * fix(architecture): address backend review follow-ups * fix(backend): sanitize exception disclosure in changed API endpoints Replace raw exception-message disclosure (ex.Message) returned to API callers with a stable sanitized public message plus correlated structured internal logging, across the endpoints changed in this PR. - Add SanitizedErrors helper: logs the original exception at Error with a generated correlation id and returns a stable public message referencing it so support can trace without exposing internals. - Inject ILogger<T> into the 14 changed controllers and route every ex.Message/dbex.Message disclosure through the helper, preserving status codes, response shapes, and business data (e.g. OpenWorkOrders). - Leave FluentValidation (vex.Errors) and existing fixed-message catches untouched; out-of-scope controllers (Account/Contact/Employee/Asset/ PMSchedule) are unchanged. - Add focused tests proving internal exception text is not returned and that Error logging carrying the original exception is invoked. * fix(architecture): abstract job run state access * style: format board update service * test: use collection assertion idiom
110 lines
3.5 KiB
C#
110 lines
3.5 KiB
C#
using Api.SeaHavenIndustries.Controllers;
|
|
using Data.SeaHavenIndustries;
|
|
using FluentAssertions;
|
|
using Microsoft.AspNetCore.Http;
|
|
using Microsoft.AspNetCore.Mvc;
|
|
using Microsoft.EntityFrameworkCore;
|
|
using Microsoft.Extensions.Logging;
|
|
using Moq;
|
|
using SeaHaven.DataServices.Implementation;
|
|
using SeaHaven.Services.DTOs;
|
|
using SeaHaven.Services.Implementation;
|
|
using SeaHaven.Services.Validation;
|
|
using Xunit;
|
|
|
|
namespace Api.SeaHavenIndustries.Tests;
|
|
|
|
public class LocationControllerSitesTests
|
|
{
|
|
private static ApplicationDbContext NewContext()
|
|
{
|
|
var options = new DbContextOptionsBuilder<ApplicationDbContext>()
|
|
.UseInMemoryDatabase(Guid.NewGuid().ToString())
|
|
.Options;
|
|
return new ApplicationDbContext(options);
|
|
}
|
|
|
|
private static LocationController NewController(ApplicationDbContext ctx)
|
|
{
|
|
var dataService = new LocationDataService(ctx);
|
|
var service = new LocationService(
|
|
dataService,
|
|
Mock.Of<ICreateLocationValidation>(),
|
|
Mock.Of<IUpdateLocationValidation>());
|
|
|
|
var controller = new LocationController(service, Mock.Of<ILogger<LocationController>>())
|
|
{
|
|
ControllerContext = new ControllerContext
|
|
{
|
|
HttpContext = new DefaultHttpContext()
|
|
}
|
|
};
|
|
|
|
return controller;
|
|
}
|
|
|
|
private static async Task SeedSitesAsync(ApplicationDbContext ctx)
|
|
{
|
|
ctx.Locations.AddRange(
|
|
new Locations { Id = 1, Name = "STL8", City = "St. Louis", State = "MO" },
|
|
new Locations { Id = 2, Name = "BK5", City = "Dallas", State = "TX" },
|
|
new Locations { Id = 3, Name = "IND9", City = "Indianapolis", State = "IN" },
|
|
new Locations { Id = 4, Name = "DFW8", City = "Dallas", State = "TX" });
|
|
await ctx.SaveChangesAsync();
|
|
}
|
|
|
|
[Fact]
|
|
public async Task GetSites_ReturnsIdCodeCityState_OrderedByCode()
|
|
{
|
|
await using var ctx = NewContext();
|
|
await SeedSitesAsync(ctx);
|
|
var controller = NewController(ctx);
|
|
|
|
var result = await controller.GetSites();
|
|
|
|
var ok = result.Should().BeOfType<OkObjectResult>().Subject;
|
|
var data = ok.Value.Should().BeAssignableTo<IReadOnlyList<SiteOptionDTO>>().Subject;
|
|
|
|
data.Should().HaveCount(4);
|
|
data.Select(s => s.Code).Should().ContainInOrder("BK5", "DFW8", "IND9", "STL8");
|
|
data[0].Should().BeEquivalentTo(new SiteOptionDTO
|
|
{
|
|
Id = 2,
|
|
Code = "BK5",
|
|
City = "Dallas",
|
|
State = "TX"
|
|
});
|
|
}
|
|
|
|
[Fact]
|
|
public async Task GetSites_FiltersByCode()
|
|
{
|
|
await using var ctx = NewContext();
|
|
await SeedSitesAsync(ctx);
|
|
var controller = NewController(ctx);
|
|
|
|
var result = await controller.GetSites("bk5");
|
|
|
|
var ok = result.Should().BeOfType<OkObjectResult>().Subject;
|
|
var data = ok.Value.Should().BeAssignableTo<IReadOnlyList<SiteOptionDTO>>().Subject;
|
|
|
|
data.Should().ContainSingle();
|
|
data[0].Code.Should().Be("BK5");
|
|
}
|
|
|
|
[Fact]
|
|
public async Task GetSites_FiltersByCity()
|
|
{
|
|
await using var ctx = NewContext();
|
|
await SeedSitesAsync(ctx);
|
|
var controller = NewController(ctx);
|
|
|
|
var result = await controller.GetSites("Dallas");
|
|
|
|
var ok = result.Should().BeOfType<OkObjectResult>().Subject;
|
|
var data = ok.Value.Should().BeAssignableTo<IReadOnlyList<SiteOptionDTO>>().Subject;
|
|
|
|
data.Should().HaveCount(2);
|
|
data.Select(s => s.Code).Should().BeEquivalentTo("BK5", "DFW8");
|
|
}
|
|
}
|