mirror of
https://github.com/Sea-Haven-Industries/shoc-backend.git
synced 2026-09-30 11:53:12 +00:00
* refactor(api): enforce service and data-service boundaries * refactor(api): complete feature service boundaries * refactor(identity): enforce service and data boundaries * refactor(vendors): enforce service and data boundaries * refactor(workorders): enforce service and data boundaries * refactor(backend): enforce architecture and optimize dispatch * style(backend): format changed architecture files * fix(architecture): address backend review follow-ups * fix(backend): sanitize exception disclosure in changed API endpoints Replace raw exception-message disclosure (ex.Message) returned to API callers with a stable sanitized public message plus correlated structured internal logging, across the endpoints changed in this PR. - Add SanitizedErrors helper: logs the original exception at Error with a generated correlation id and returns a stable public message referencing it so support can trace without exposing internals. - Inject ILogger<T> into the 14 changed controllers and route every ex.Message/dbex.Message disclosure through the helper, preserving status codes, response shapes, and business data (e.g. OpenWorkOrders). - Leave FluentValidation (vex.Errors) and existing fixed-message catches untouched; out-of-scope controllers (Account/Contact/Employee/Asset/ PMSchedule) are unchanged. - Add focused tests proving internal exception text is not returned and that Error logging carrying the original exception is invoked. * fix(architecture): abstract job run state access * style: format board update service * test: use collection assertion idiom
103 lines
3.8 KiB
C#
103 lines
3.8 KiB
C#
using Data.SeaHavenIndustries;
|
|
using Data.SeaHavenIndustries.Enums;
|
|
using Microsoft.EntityFrameworkCore;
|
|
using SeaHaven.DataServices.Implementation;
|
|
using SeaHaven.Services.DTOs;
|
|
using SeaHaven.Services.Implementation;
|
|
using SeaHaven.Services.Interfaces;
|
|
using SeaHaven.Services.Validation;
|
|
|
|
namespace SeaHavenIndustries.Tests;
|
|
|
|
public class WorkOrderBoardCreateSyncLockTests
|
|
{
|
|
[Fact]
|
|
public async Task AfterShocCreate_SyncRejectsLockedSiteCode()
|
|
{
|
|
var options = new DbContextOptionsBuilder<ApplicationDbContext>()
|
|
.UseInMemoryDatabase(Guid.NewGuid().ToString())
|
|
.Options;
|
|
await using var context = new ApplicationDbContext(options);
|
|
|
|
var boardData = new WorkOrderBoardDataService(context);
|
|
var mutationData = new WorkOrderBoardMutationDataService(context);
|
|
var boardService = new WorkOrderBoardService(boardData);
|
|
var fieldLocks = new WorkOrderFieldLockService(new WorkOrderFieldLockDataService(context));
|
|
var audit = new WorkOrderAuditService(new WorkOrderAuditDataService(context), fieldLocks);
|
|
var createService = new WorkOrderBoardCreateService(
|
|
boardData,
|
|
mutationData,
|
|
boardService,
|
|
audit,
|
|
new WorkOrderBoardCreateValidation());
|
|
var policy = new SyncFieldMergePolicy(fieldLocks);
|
|
|
|
await createService.CreateAsync(new WorkOrderBoardCreateRequestDto
|
|
{
|
|
WorkOrderType = WorkOrderType.PM,
|
|
SiteCode = "BK5"
|
|
}, "dispatcher-1");
|
|
|
|
var wo = await context.workOrders.SingleAsync();
|
|
var syncContext = new WorkOrderSyncContext
|
|
{
|
|
WorkOrder = wo,
|
|
FieldLocks = fieldLocks,
|
|
Audit = audit
|
|
};
|
|
|
|
var applied = await policy.TryApplyAsync(syncContext, "SiteCode", "SYNC-SITE");
|
|
|
|
Assert.False(applied);
|
|
Assert.Equal("BK5", wo.SiteCode);
|
|
|
|
var rejected = await context.WorkOrderAuditLogs
|
|
.SingleAsync(l => l.Action == "SyncRejected" && l.FieldName == "SiteCode");
|
|
Assert.Equal("SYNC-SITE", rejected.NewValue);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task AfterShocCreate_SyncCanUpdateUnlockedField_NotInShocSet()
|
|
{
|
|
var options = new DbContextOptionsBuilder<ApplicationDbContext>()
|
|
.UseInMemoryDatabase(Guid.NewGuid().ToString())
|
|
.Options;
|
|
await using var context = new ApplicationDbContext(options);
|
|
|
|
var boardData = new WorkOrderBoardDataService(context);
|
|
var mutationData = new WorkOrderBoardMutationDataService(context);
|
|
var boardService = new WorkOrderBoardService(boardData);
|
|
var fieldLocks = new WorkOrderFieldLockService(new WorkOrderFieldLockDataService(context));
|
|
var audit = new WorkOrderAuditService(new WorkOrderAuditDataService(context), fieldLocks);
|
|
var createService = new WorkOrderBoardCreateService(
|
|
boardData,
|
|
mutationData,
|
|
boardService,
|
|
audit,
|
|
new WorkOrderBoardCreateValidation());
|
|
var policy = new SyncFieldMergePolicy(fieldLocks);
|
|
|
|
await createService.CreateAsync(new WorkOrderBoardCreateRequestDto
|
|
{
|
|
WorkOrderType = WorkOrderType.PM,
|
|
SiteCode = "BK5"
|
|
}, "dispatcher-1");
|
|
|
|
var wo = await context.workOrders.SingleAsync();
|
|
wo.Customer = "Original";
|
|
await context.SaveChangesAsync();
|
|
|
|
var syncContext = new WorkOrderSyncContext
|
|
{
|
|
WorkOrder = wo,
|
|
FieldLocks = fieldLocks,
|
|
Audit = audit
|
|
};
|
|
|
|
// Customer is not in SyncFieldMergePolicy apply switch — use Description which wasn't set on create
|
|
var applied = await policy.TryApplyAsync(syncContext, "Description", "From sync");
|
|
|
|
Assert.True(applied);
|
|
Assert.Equal("From sync", wo.Description);
|
|
}
|
|
}
|