mirror of
https://github.com/Sea-Haven-Industries/shoc-backend.git
synced 2026-09-30 21:13:12 +00:00
* refactor(api): enforce service and data-service boundaries * refactor(api): complete feature service boundaries * refactor(identity): enforce service and data boundaries * refactor(vendors): enforce service and data boundaries * refactor(workorders): enforce service and data boundaries * refactor(backend): enforce architecture and optimize dispatch * style(backend): format changed architecture files * fix(architecture): address backend review follow-ups * fix(backend): sanitize exception disclosure in changed API endpoints Replace raw exception-message disclosure (ex.Message) returned to API callers with a stable sanitized public message plus correlated structured internal logging, across the endpoints changed in this PR. - Add SanitizedErrors helper: logs the original exception at Error with a generated correlation id and returns a stable public message referencing it so support can trace without exposing internals. - Inject ILogger<T> into the 14 changed controllers and route every ex.Message/dbex.Message disclosure through the helper, preserving status codes, response shapes, and business data (e.g. OpenWorkOrders). - Leave FluentValidation (vex.Errors) and existing fixed-message catches untouched; out-of-scope controllers (Account/Contact/Employee/Asset/ PMSchedule) are unchanged. - Add focused tests proving internal exception text is not returned and that Error logging carrying the original exception is invoked. * fix(architecture): abstract job run state access * style: format board update service * test: use collection assertion idiom
95 lines
4.1 KiB
C#
95 lines
4.1 KiB
C#
using Api.SeaHavenIndustries.Helper;
|
|
using Data.SeaHavenIndustries;
|
|
using Microsoft.AspNetCore.Authorization;
|
|
using Microsoft.AspNetCore.Mvc;
|
|
using Microsoft.Extensions.Logging;
|
|
using SeaHaven.Services.DTOs;
|
|
using SeaHaven.Services.Interfaces;
|
|
|
|
namespace Api.SeaHavenIndustries.Controllers
|
|
{
|
|
[Authorize]
|
|
[ApiController]
|
|
[Route("api/[controller]")]
|
|
[Route("api/uplifts")]
|
|
public class UpliftController : Controller
|
|
{
|
|
private readonly IUpliftService _upliftService;
|
|
private readonly ILogger<UpliftController> _logger;
|
|
|
|
public UpliftController(IUpliftService upliftService, ILogger<UpliftController> logger)
|
|
{
|
|
_upliftService = upliftService;
|
|
_logger = logger;
|
|
}
|
|
|
|
[HttpGet]
|
|
public async Task<IActionResult> List([FromQuery] string? status = "Pending", [FromQuery] int? tier = null, [FromQuery] int page = 1, [FromQuery] int pageSize = 25, CancellationToken cancellationToken = default)
|
|
{
|
|
var result = await _upliftService.ListAsync(User, status, tier, page, pageSize, cancellationToken);
|
|
return Ok(new DataResponse { Status = "Success", Data = result });
|
|
}
|
|
|
|
[HttpGet("dispatch/{dispatchId:int}")]
|
|
public async Task<IActionResult> ListForDispatch(int dispatchId, CancellationToken cancellationToken = default)
|
|
{
|
|
var items = await _upliftService.ListForDispatchAsync(User, dispatchId, cancellationToken);
|
|
return Ok(new DataResponse { Status = "Success", Data = items });
|
|
}
|
|
|
|
[HttpPost("{id:int}/approve")]
|
|
public async Task<IActionResult> Approve(int id, [FromBody] DecisionRequest? body, CancellationToken cancellationToken = default)
|
|
{
|
|
try
|
|
{
|
|
var result = await _upliftService.ApproveAsync(User, id, body?.Note, cancellationToken);
|
|
return Ok(new DataResponse { Status = "Success", Data = result });
|
|
}
|
|
catch (KeyNotFoundException ex)
|
|
{
|
|
return NotFound(new Response { Status = "Error", Message = _logger.Sanitize(ex, "Uplift request not found") });
|
|
}
|
|
catch (UpliftForbiddenException ex)
|
|
{
|
|
return StatusCode(403, new Response { Status = "Error", Message = _logger.Sanitize(ex, "You are not authorized to perform this action on this uplift request") });
|
|
}
|
|
catch (InvalidOperationException ex)
|
|
{
|
|
return BadRequest(new Response { Status = "Error", Message = _logger.Sanitize(ex, "This uplift request cannot be modified in its current state") });
|
|
}
|
|
}
|
|
|
|
[HttpPost("{id:int}/deny")]
|
|
public async Task<IActionResult> Deny(int id, [FromBody] DecisionRequest? body, CancellationToken cancellationToken = default)
|
|
{
|
|
try
|
|
{
|
|
var result = await _upliftService.DenyAsync(User, id, body?.Note, cancellationToken);
|
|
return Ok(new DataResponse { Status = "Success", Data = result });
|
|
}
|
|
catch (KeyNotFoundException ex)
|
|
{
|
|
return NotFound(new Response { Status = "Error", Message = _logger.Sanitize(ex, "Uplift request not found") });
|
|
}
|
|
catch (UpliftForbiddenException ex)
|
|
{
|
|
return StatusCode(403, new Response { Status = "Error", Message = _logger.Sanitize(ex, "You are not authorized to perform this action on this uplift request") });
|
|
}
|
|
catch (InvalidOperationException ex)
|
|
{
|
|
return BadRequest(new Response { Status = "Error", Message = _logger.Sanitize(ex, "This uplift request cannot be modified in its current state") });
|
|
}
|
|
}
|
|
|
|
[HttpGet("can-approve")]
|
|
public IActionResult CanApprove([FromQuery] int tier)
|
|
{
|
|
return Ok(new DataResponse { Status = "Success", Data = new { canApprove = _upliftService.CanApprove(User, tier) } });
|
|
}
|
|
|
|
public class DecisionRequest
|
|
{
|
|
public string? Note { get; set; }
|
|
}
|
|
}
|
|
}
|