mirror of
https://github.com/Sea-Haven-Industries/shoc-backend.git
synced 2026-09-30 09:33:13 +00:00
* refactor(api): enforce service and data-service boundaries * refactor(api): complete feature service boundaries * refactor(identity): enforce service and data boundaries * refactor(vendors): enforce service and data boundaries * refactor(workorders): enforce service and data boundaries * refactor(backend): enforce architecture and optimize dispatch * style(backend): format changed architecture files * fix(architecture): address backend review follow-ups * fix(backend): sanitize exception disclosure in changed API endpoints Replace raw exception-message disclosure (ex.Message) returned to API callers with a stable sanitized public message plus correlated structured internal logging, across the endpoints changed in this PR. - Add SanitizedErrors helper: logs the original exception at Error with a generated correlation id and returns a stable public message referencing it so support can trace without exposing internals. - Inject ILogger<T> into the 14 changed controllers and route every ex.Message/dbex.Message disclosure through the helper, preserving status codes, response shapes, and business data (e.g. OpenWorkOrders). - Leave FluentValidation (vex.Errors) and existing fixed-message catches untouched; out-of-scope controllers (Account/Contact/Employee/Asset/ PMSchedule) are unchanged. - Add focused tests proving internal exception text is not returned and that Error logging carrying the original exception is invoked. * fix(architecture): abstract job run state access * style: format board update service * test: use collection assertion idiom
139 lines
5.5 KiB
C#
139 lines
5.5 KiB
C#
using Api.SeaHavenIndustries.DTOs;
|
|
using Data.SeaHavenIndustries;
|
|
using Data.SeaHavenIndustries.Enums;
|
|
using Microsoft.AspNetCore.Authorization;
|
|
using Microsoft.AspNetCore.Mvc;
|
|
using SeaHaven.Services.DTOs;
|
|
using SeaHaven.Services.Exceptions;
|
|
using SeaHaven.Services.Interfaces;
|
|
using System.Security.Claims;
|
|
|
|
namespace Api.SeaHavenIndustries.Controllers
|
|
{
|
|
[Authorize]
|
|
[ApiController]
|
|
[Route("api/WorkOrder")]
|
|
[Route("api/workorders")]
|
|
public class WorkOrderCompletionController : Controller
|
|
{
|
|
private readonly IWorkOrderCompletionService _workOrderCompletionService;
|
|
private readonly IFileStoragePort _fileStorage;
|
|
|
|
public WorkOrderCompletionController(
|
|
IWorkOrderCompletionService workOrderCompletionService,
|
|
IFileStoragePort fileStorage)
|
|
{
|
|
_workOrderCompletionService = workOrderCompletionService;
|
|
_fileStorage = fileStorage;
|
|
}
|
|
|
|
[HttpGet("completion-templates")]
|
|
public async Task<IActionResult> GetCompletionTemplates(
|
|
[FromQuery] string? serviceKey = null,
|
|
[FromQuery] WorkOrderType? workOrderType = null)
|
|
{
|
|
var templates = await _workOrderCompletionService.GetTemplatesAsync(serviceKey, workOrderType);
|
|
return Ok(templates);
|
|
}
|
|
|
|
[HttpGet("completion-templates/{id:int}")]
|
|
public async Task<IActionResult> GetCompletionTemplate(int id)
|
|
{
|
|
var template = await _workOrderCompletionService.GetTemplateByIdAsync(id);
|
|
if (template == null)
|
|
return NotFound(new Response { Status = "Error", Message = "Template not found." });
|
|
return Ok(template);
|
|
}
|
|
|
|
[Authorize(Roles = "Admin")]
|
|
[HttpPost("completion-templates")]
|
|
public async Task<IActionResult> CreateCompletionTemplate([FromBody] CompletionDocTemplateCreateDto request)
|
|
{
|
|
try
|
|
{
|
|
var created = await _workOrderCompletionService.CreateTemplateAsync(request);
|
|
return Ok(created);
|
|
}
|
|
catch (WorkOrderBoardValidationException ex)
|
|
{
|
|
return UnprocessableEntity(new WorkOrderBoardValidationErrorDto { Code = ex.Code, Message = ex.Message });
|
|
}
|
|
}
|
|
|
|
[Authorize(Roles = "Admin")]
|
|
[HttpPut("completion-templates/{id:int}")]
|
|
public async Task<IActionResult> UpdateCompletionTemplate(int id, [FromBody] CompletionDocTemplateCreateDto request)
|
|
{
|
|
try
|
|
{
|
|
var updated = await _workOrderCompletionService.UpdateTemplateAsync(id, request);
|
|
return Ok(updated);
|
|
}
|
|
catch (WorkOrderBoardValidationException ex) when (ex.Code == "NotFound")
|
|
{
|
|
return NotFound(new WorkOrderBoardValidationErrorDto { Code = ex.Code, Message = ex.Message });
|
|
}
|
|
catch (WorkOrderBoardValidationException ex)
|
|
{
|
|
return UnprocessableEntity(new WorkOrderBoardValidationErrorDto { Code = ex.Code, Message = ex.Message });
|
|
}
|
|
}
|
|
|
|
[Authorize(Roles = "Admin")]
|
|
[HttpDelete("completion-templates/{id:int}")]
|
|
public async Task<IActionResult> DeleteCompletionTemplate(int id)
|
|
{
|
|
try
|
|
{
|
|
await _workOrderCompletionService.DeleteTemplateAsync(id);
|
|
return NoContent();
|
|
}
|
|
catch (WorkOrderBoardValidationException ex) when (ex.Code == "NotFound")
|
|
{
|
|
return NotFound(new WorkOrderBoardValidationErrorDto { Code = ex.Code, Message = ex.Message });
|
|
}
|
|
}
|
|
|
|
[HttpPost("{id:int}/completion-doc")]
|
|
[RequestSizeLimit(30_000_000)]
|
|
public async Task<IActionResult> UploadCompletionDoc(
|
|
int id,
|
|
[FromForm] IFormFile file,
|
|
[FromForm] string? signOffName = null,
|
|
[FromForm] string? signOffSignature = null,
|
|
[FromForm] string? workOrderVersion = null)
|
|
{
|
|
if (file == null || file.Length == 0)
|
|
return BadRequest(new Response { Status = "Error", Message = "file is required." });
|
|
|
|
try
|
|
{
|
|
var actorId = User.FindFirstValue(ClaimTypes.NameIdentifier);
|
|
var fileUrl = await _fileStorage.SaveFileAsync(file);
|
|
var result = await _workOrderCompletionService.UploadCompletionDocAsync(
|
|
id,
|
|
new WorkOrderCompletionDocUploadDto
|
|
{
|
|
SignOffName = signOffName,
|
|
SignOffSignature = signOffSignature,
|
|
WorkOrderVersion = workOrderVersion
|
|
},
|
|
fileUrl,
|
|
actorId);
|
|
return Ok(result);
|
|
}
|
|
catch (WorkOrderBoardValidationException ex) when (ex.Code is "NotFound")
|
|
{
|
|
return NotFound(new WorkOrderBoardValidationErrorDto { Code = ex.Code, Message = ex.Message });
|
|
}
|
|
catch (WorkOrderBoardValidationException ex) when (ex.Code is "ConcurrencyConflict")
|
|
{
|
|
return Conflict(new WorkOrderBoardValidationErrorDto { Code = ex.Code, Message = ex.Message });
|
|
}
|
|
catch (WorkOrderBoardValidationException ex)
|
|
{
|
|
return UnprocessableEntity(new WorkOrderBoardValidationErrorDto { Code = ex.Code, Message = ex.Message });
|
|
}
|
|
}
|
|
}
|
|
}
|