mirror of
https://github.com/Sea-Haven-Industries/shoc-backend.git
synced 2026-10-01 14:33:15 +00:00
* refactor(api): enforce service and data-service boundaries * refactor(api): complete feature service boundaries * refactor(identity): enforce service and data boundaries * refactor(vendors): enforce service and data boundaries * refactor(workorders): enforce service and data boundaries * refactor(backend): enforce architecture and optimize dispatch * style(backend): format changed architecture files * fix(architecture): address backend review follow-ups * fix(backend): sanitize exception disclosure in changed API endpoints Replace raw exception-message disclosure (ex.Message) returned to API callers with a stable sanitized public message plus correlated structured internal logging, across the endpoints changed in this PR. - Add SanitizedErrors helper: logs the original exception at Error with a generated correlation id and returns a stable public message referencing it so support can trace without exposing internals. - Inject ILogger<T> into the 14 changed controllers and route every ex.Message/dbex.Message disclosure through the helper, preserving status codes, response shapes, and business data (e.g. OpenWorkOrders). - Leave FluentValidation (vex.Errors) and existing fixed-message catches untouched; out-of-scope controllers (Account/Contact/Employee/Asset/ PMSchedule) are unchanged. - Add focused tests proving internal exception text is not returned and that Error logging carrying the original exception is invoked. * fix(architecture): abstract job run state access * style: format board update service * test: use collection assertion idiom
75 lines
2.9 KiB
C#
75 lines
2.9 KiB
C#
using Api.SeaHavenIndustries.DTOs;
|
|
using Data.SeaHavenIndustries;
|
|
using Microsoft.AspNetCore.Authorization;
|
|
using Microsoft.AspNetCore.Mvc;
|
|
using SeaHaven.Services.DTOs;
|
|
using SeaHaven.Services.Exceptions;
|
|
using SeaHaven.Services.Interfaces;
|
|
using System.Security.Claims;
|
|
|
|
namespace Api.SeaHavenIndustries.Controllers
|
|
{
|
|
[Authorize]
|
|
[ApiController]
|
|
[Route("api/WorkOrder")]
|
|
[Route("api/workorders")]
|
|
public class WorkOrderDetailController : Controller
|
|
{
|
|
private readonly IWorkOrderDetailService _workOrderDetailService;
|
|
private readonly IWorkOrderCommentService _workOrderCommentService;
|
|
|
|
public WorkOrderDetailController(
|
|
IWorkOrderDetailService workOrderDetailService,
|
|
IWorkOrderCommentService workOrderCommentService)
|
|
{
|
|
_workOrderDetailService = workOrderDetailService;
|
|
_workOrderCommentService = workOrderCommentService;
|
|
}
|
|
|
|
[HttpGet("{id:int}/detail")]
|
|
public async Task<IActionResult> GetDetail(int id)
|
|
{
|
|
var detail = await _workOrderDetailService.GetDetailAsync(id);
|
|
if (detail == null)
|
|
return NotFound(new Response { Status = "Error", Message = "Work order not found." });
|
|
return Ok(detail);
|
|
}
|
|
|
|
[HttpGet("{id:int}/audit")]
|
|
public async Task<IActionResult> GetAudit(int id, [FromQuery] int limit = 50)
|
|
{
|
|
var audit = await _workOrderDetailService.GetAuditAsync(id, limit);
|
|
if (audit == null)
|
|
return NotFound(new Response { Status = "Error", Message = "Work order not found." });
|
|
return Ok(audit);
|
|
}
|
|
|
|
[HttpGet("{id:int}/comments")]
|
|
public async Task<IActionResult> GetBoardComments(int id)
|
|
{
|
|
var comments = await _workOrderCommentService.GetCommentsAsync(id);
|
|
if (comments == null)
|
|
return NotFound(new Response { Status = "Error", Message = "Work order not found." });
|
|
return Ok(comments);
|
|
}
|
|
|
|
[HttpPost("{id:int}/comments")]
|
|
public async Task<IActionResult> AddBoardComment(int id, [FromBody] WorkOrderCommentCreateDto request)
|
|
{
|
|
try
|
|
{
|
|
var actorId = User.FindFirstValue(ClaimTypes.NameIdentifier);
|
|
var comment = await _workOrderCommentService.AddCommentAsync(id, request, actorId);
|
|
return Ok(comment);
|
|
}
|
|
catch (WorkOrderBoardValidationException ex) when (ex.Code == "NotFound")
|
|
{
|
|
return NotFound(new WorkOrderBoardValidationErrorDto { Code = ex.Code, Message = ex.Message });
|
|
}
|
|
catch (WorkOrderBoardValidationException ex)
|
|
{
|
|
return UnprocessableEntity(new WorkOrderBoardValidationErrorDto { Code = ex.Code, Message = ex.Message });
|
|
}
|
|
}
|
|
}
|
|
}
|