mirror of
https://github.com/Sea-Haven-Industries/shoc-backend.git
synced 2026-10-04 05:33:19 +00:00
* refactor(api): enforce service and data-service boundaries * refactor(api): complete feature service boundaries * refactor(identity): enforce service and data boundaries * refactor(vendors): enforce service and data boundaries * refactor(workorders): enforce service and data boundaries * refactor(backend): enforce architecture and optimize dispatch * style(backend): format changed architecture files * fix(architecture): address backend review follow-ups * fix(backend): sanitize exception disclosure in changed API endpoints Replace raw exception-message disclosure (ex.Message) returned to API callers with a stable sanitized public message plus correlated structured internal logging, across the endpoints changed in this PR. - Add SanitizedErrors helper: logs the original exception at Error with a generated correlation id and returns a stable public message referencing it so support can trace without exposing internals. - Inject ILogger<T> into the 14 changed controllers and route every ex.Message/dbex.Message disclosure through the helper, preserving status codes, response shapes, and business data (e.g. OpenWorkOrders). - Leave FluentValidation (vex.Errors) and existing fixed-message catches untouched; out-of-scope controllers (Account/Contact/Employee/Asset/ PMSchedule) are unchanged. - Add focused tests proving internal exception text is not returned and that Error logging carrying the original exception is invoked. * fix(architecture): abstract job run state access * style: format board update service * test: use collection assertion idiom
63 lines
2.2 KiB
C#
63 lines
2.2 KiB
C#
using Api.SeaHavenIndustries.Controllers;
|
|
using Data.SeaHavenIndustries;
|
|
using FluentAssertions;
|
|
using Microsoft.AspNetCore.Http;
|
|
using Microsoft.AspNetCore.Mvc;
|
|
using Moq;
|
|
using SeaHaven.DataServices.Interfaces;
|
|
using SeaHaven.Services.DTOs;
|
|
using SeaHaven.Services.Helpers;
|
|
using SeaHaven.Services.Implementation;
|
|
using SeaHaven.Services.Interfaces;
|
|
using Xunit;
|
|
|
|
namespace Api.SeaHavenIndustries.Tests;
|
|
|
|
public class WorkOrderControllerSearchTests
|
|
{
|
|
private static WorkOrderBoardController NewController(IWorkOrderAdvancedSearchService advancedSearch)
|
|
{
|
|
var controller = new WorkOrderBoardController(
|
|
Mock.Of<IWorkOrderBoardService>(),
|
|
Mock.Of<IWorkOrderBoardUpdateService>(),
|
|
Mock.Of<IWorkOrderBoardCreateService>(),
|
|
Mock.Of<IWorkOrderBoardCancelService>(),
|
|
advancedSearch);
|
|
|
|
controller.ControllerContext = new ControllerContext
|
|
{
|
|
HttpContext = new DefaultHttpContext
|
|
{
|
|
User = new System.Security.Claims.ClaimsPrincipal(
|
|
new System.Security.Claims.ClaimsIdentity(
|
|
new[]
|
|
{
|
|
new System.Security.Claims.Claim(
|
|
System.Security.Claims.ClaimTypes.NameIdentifier,
|
|
"test-user")
|
|
},
|
|
"Test"))
|
|
}
|
|
};
|
|
|
|
return controller;
|
|
}
|
|
|
|
[Fact]
|
|
public async Task SearchBoard_WhenCustomPresetMissingDates_ReturnsBadRequest()
|
|
{
|
|
var advancedSearch = new WorkOrderAdvancedSearchService(
|
|
Mock.Of<IWorkOrderAdvancedSearchDataService>());
|
|
var controller = NewController(advancedSearch);
|
|
|
|
var result = await controller.SearchBoard(new WorkOrderAdvancedSearchQueryDto
|
|
{
|
|
DatePreset = WorkOrderAdvancedSearchDatePreset.Custom
|
|
});
|
|
|
|
var badRequest = result.Should().BeOfType<BadRequestObjectResult>().Subject;
|
|
var body = badRequest.Value.Should().BeOfType<Response>().Subject;
|
|
body.Status.Should().Be("Error");
|
|
body.Message.Should().Contain("dateFrom");
|
|
}
|
|
}
|