mirror of
https://github.com/Sea-Haven-Industries/shoc-backend.git
synced 2026-10-02 06:13:23 +00:00
7d245eb717
* refactor(api): enforce service and data-service boundaries * refactor(api): complete feature service boundaries * refactor(identity): enforce service and data boundaries * refactor(vendors): enforce service and data boundaries * refactor(workorders): enforce service and data boundaries * refactor(backend): enforce architecture and optimize dispatch * style(backend): format changed architecture files * fix(architecture): address backend review follow-ups * fix(backend): sanitize exception disclosure in changed API endpoints Replace raw exception-message disclosure (ex.Message) returned to API callers with a stable sanitized public message plus correlated structured internal logging, across the endpoints changed in this PR. - Add SanitizedErrors helper: logs the original exception at Error with a generated correlation id and returns a stable public message referencing it so support can trace without exposing internals. - Inject ILogger<T> into the 14 changed controllers and route every ex.Message/dbex.Message disclosure through the helper, preserving status codes, response shapes, and business data (e.g. OpenWorkOrders). - Leave FluentValidation (vex.Errors) and existing fixed-message catches untouched; out-of-scope controllers (Account/Contact/Employee/Asset/ PMSchedule) are unchanged. - Add focused tests proving internal exception text is not returned and that Error logging carrying the original exception is invoked. * fix(architecture): abstract job run state access * style: format board update service * test: use collection assertion idiom
51 lines
1.2 KiB
YAML
51 lines
1.2 KiB
YAML
name: Architecture and changed-file quality
|
|
|
|
on:
|
|
pull_request:
|
|
branches: [main, dev]
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
jobs:
|
|
architecture:
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@v4
|
|
with:
|
|
fetch-depth: 0
|
|
|
|
- name: Set up .NET
|
|
uses: actions/setup-dotnet@v4
|
|
with:
|
|
dotnet-version: "8.0.x"
|
|
|
|
- name: Restore
|
|
run: dotnet restore SeaHavenIndustries.sln
|
|
|
|
- name: Verify architecture boundaries
|
|
run: >-
|
|
dotnet test
|
|
Api.SeaHavenIndustries.Tests/Api.SeaHavenIndustries.Tests.csproj
|
|
--no-restore
|
|
--filter FullyQualifiedName~ArchitectureTests
|
|
|
|
- name: Verify formatting of changed C# files
|
|
shell: bash
|
|
run: |
|
|
mapfile -t files < <(
|
|
git diff --name-only --diff-filter=ACMR \
|
|
"${{ github.event.pull_request.base.sha }}" \
|
|
"${{ github.event.pull_request.head.sha }}" \
|
|
-- '*.cs'
|
|
)
|
|
|
|
if (( ${#files[@]} == 0 )); then
|
|
exit 0
|
|
fi
|
|
|
|
dotnet format SeaHavenIndustries.sln \
|
|
--no-restore \
|
|
--verify-no-changes \
|
|
--include "${files[@]}"
|