mirror of
https://github.com/Sea-Haven-Industries/shoc-backend.git
synced 2026-09-30 09:33:13 +00:00
* refactor(api): enforce service and data-service boundaries * refactor(api): complete feature service boundaries * refactor(identity): enforce service and data boundaries * refactor(vendors): enforce service and data boundaries * refactor(workorders): enforce service and data boundaries * refactor(backend): enforce architecture and optimize dispatch * style(backend): format changed architecture files * fix(architecture): address backend review follow-ups * fix(backend): sanitize exception disclosure in changed API endpoints Replace raw exception-message disclosure (ex.Message) returned to API callers with a stable sanitized public message plus correlated structured internal logging, across the endpoints changed in this PR. - Add SanitizedErrors helper: logs the original exception at Error with a generated correlation id and returns a stable public message referencing it so support can trace without exposing internals. - Inject ILogger<T> into the 14 changed controllers and route every ex.Message/dbex.Message disclosure through the helper, preserving status codes, response shapes, and business data (e.g. OpenWorkOrders). - Leave FluentValidation (vex.Errors) and existing fixed-message catches untouched; out-of-scope controllers (Account/Contact/Employee/Asset/ PMSchedule) are unchanged. - Add focused tests proving internal exception text is not returned and that Error logging carrying the original exception is invoked. * fix(architecture): abstract job run state access * style: format board update service * test: use collection assertion idiom
94 lines
3.3 KiB
C#
94 lines
3.3 KiB
C#
using Api.SeaHavenIndustries.DTOs;
|
|
using Api.SeaHavenIndustries.Helper;
|
|
using Microsoft.AspNetCore.Authorization;
|
|
using Microsoft.AspNetCore.Mvc;
|
|
using Microsoft.Extensions.Logging;
|
|
using SeaHaven.Services.DTOs;
|
|
using SeaHaven.Services.Interfaces;
|
|
|
|
namespace Api.SeaHavenIndustries.Controllers
|
|
{
|
|
[Authorize]
|
|
[ApiController]
|
|
[Route("api/[controller]")]
|
|
public class DropdownOptionsController : Controller
|
|
{
|
|
private readonly IDropdownOptionsService _dropdownOptionsService;
|
|
private readonly ILogger<DropdownOptionsController> _logger;
|
|
|
|
public DropdownOptionsController(IDropdownOptionsService dropdownOptionsService, ILogger<DropdownOptionsController> logger)
|
|
{
|
|
_dropdownOptionsService = dropdownOptionsService;
|
|
_logger = logger;
|
|
}
|
|
|
|
[HttpGet]
|
|
public async Task<IActionResult> GetAll([FromQuery] string? category = null, CancellationToken cancellationToken = default)
|
|
{
|
|
var data = await _dropdownOptionsService.GetAllAsync(category, cancellationToken);
|
|
return Ok(data);
|
|
}
|
|
|
|
[HttpGet("ByCategory/{category}")]
|
|
public async Task<IActionResult> GetByCategory(string category, [FromQuery] string? parent = null, CancellationToken cancellationToken = default)
|
|
{
|
|
var data = await _dropdownOptionsService.GetByCategoryAsync(category, parent, cancellationToken);
|
|
return Ok(data);
|
|
}
|
|
|
|
[HttpPost]
|
|
public async Task<IActionResult> Create([FromBody] DropdownOption_DTO model, CancellationToken cancellationToken)
|
|
{
|
|
try
|
|
{
|
|
var created = await _dropdownOptionsService.CreateAsync(MapToService(model), cancellationToken);
|
|
return Ok(created);
|
|
}
|
|
catch (InvalidOperationException ex)
|
|
{
|
|
return BadRequest(new { message = _logger.Sanitize(ex, "The dropdown option could not be saved") });
|
|
}
|
|
}
|
|
|
|
[HttpPut("{id}")]
|
|
public async Task<IActionResult> Update(int id, [FromBody] DropdownOption_DTO model, CancellationToken cancellationToken)
|
|
{
|
|
try
|
|
{
|
|
var updated = await _dropdownOptionsService.UpdateAsync(id, MapToService(model), cancellationToken);
|
|
return Ok(updated);
|
|
}
|
|
catch (KeyNotFoundException)
|
|
{
|
|
return NotFound(new { message = "Option not found" });
|
|
}
|
|
}
|
|
|
|
[HttpDelete("{id}")]
|
|
public async Task<IActionResult> Delete(int id, CancellationToken cancellationToken)
|
|
{
|
|
try
|
|
{
|
|
await _dropdownOptionsService.DeleteAsync(id, cancellationToken);
|
|
return Ok(new { message = "Deleted" });
|
|
}
|
|
catch (KeyNotFoundException)
|
|
{
|
|
return NotFound(new { message = "Option not found" });
|
|
}
|
|
}
|
|
|
|
private static DropdownOptionDTO MapToService(DropdownOption_DTO model)
|
|
{
|
|
return new DropdownOptionDTO
|
|
{
|
|
Id = model.Id,
|
|
Category = model.Category,
|
|
Value = model.Value,
|
|
ParentValue = model.ParentValue,
|
|
SortOrder = model.SortOrder,
|
|
IsActive = model.IsActive
|
|
};
|
|
}
|
|
}
|
|
}
|