mirror of
https://github.com/Sea-Haven-Industries/shoc-backend.git
synced 2026-09-30 14:13:12 +00:00
* refactor(api): enforce service and data-service boundaries * refactor(api): complete feature service boundaries * refactor(identity): enforce service and data boundaries * refactor(vendors): enforce service and data boundaries * refactor(workorders): enforce service and data boundaries * refactor(backend): enforce architecture and optimize dispatch * style(backend): format changed architecture files * fix(architecture): address backend review follow-ups * fix(backend): sanitize exception disclosure in changed API endpoints Replace raw exception-message disclosure (ex.Message) returned to API callers with a stable sanitized public message plus correlated structured internal logging, across the endpoints changed in this PR. - Add SanitizedErrors helper: logs the original exception at Error with a generated correlation id and returns a stable public message referencing it so support can trace without exposing internals. - Inject ILogger<T> into the 14 changed controllers and route every ex.Message/dbex.Message disclosure through the helper, preserving status codes, response shapes, and business data (e.g. OpenWorkOrders). - Leave FluentValidation (vex.Errors) and existing fixed-message catches untouched; out-of-scope controllers (Account/Contact/Employee/Asset/ PMSchedule) are unchanged. - Add focused tests proving internal exception text is not returned and that Error logging carrying the original exception is invoked. * fix(architecture): abstract job run state access * style: format board update service * test: use collection assertion idiom
43 lines
1.7 KiB
C#
43 lines
1.7 KiB
C#
using Data.SeaHavenIndustries;
|
|
using Microsoft.EntityFrameworkCore;
|
|
using SeaHaven.DataServices.Interfaces;
|
|
|
|
namespace SeaHaven.DataServices.Implementation
|
|
{
|
|
public class VendorDocumentDataService : IVendorDocumentDataService
|
|
{
|
|
private readonly ApplicationDbContext _context;
|
|
|
|
public VendorDocumentDataService(ApplicationDbContext context)
|
|
{
|
|
_context = context;
|
|
}
|
|
|
|
public Task<VendorCompletionDocument?> GetLatestForDispatchAsync(int dispatchId, CancellationToken cancellationToken)
|
|
{
|
|
return _context.VendorCompletionDocuments
|
|
.Where(document => document.DispatchId == dispatchId)
|
|
.OrderByDescending(document => document.Version)
|
|
.FirstOrDefaultAsync(cancellationToken);
|
|
}
|
|
|
|
public Task<VendorCompletionDocument?> GetForVendorDispatchAsync(int documentId, int dispatchId, int vendorId, CancellationToken cancellationToken)
|
|
{
|
|
return _context.VendorCompletionDocuments
|
|
.FirstOrDefaultAsync(document => document.Id == documentId
|
|
&& document.DispatchId == dispatchId
|
|
&& document.VendorId == vendorId
|
|
&& (document.IsDeleted == null || document.IsDeleted == false), cancellationToken);
|
|
}
|
|
|
|
public async Task AddAsync(VendorCompletionDocument document, CancellationToken cancellationToken)
|
|
{
|
|
await _context.VendorCompletionDocuments.AddAsync(document, cancellationToken);
|
|
}
|
|
|
|
public Task SaveChangesAsync(CancellationToken cancellationToken)
|
|
{
|
|
return _context.SaveChangesAsync(cancellationToken);
|
|
}
|
|
}
|
|
}
|