mirror of
https://github.com/Sea-Haven-Industries/shoc-backend.git
synced 2026-09-30 09:33:13 +00:00
* refactor(api): enforce service and data-service boundaries * refactor(api): complete feature service boundaries * refactor(identity): enforce service and data boundaries * refactor(vendors): enforce service and data boundaries * refactor(workorders): enforce service and data boundaries * refactor(backend): enforce architecture and optimize dispatch * style(backend): format changed architecture files * fix(architecture): address backend review follow-ups * fix(backend): sanitize exception disclosure in changed API endpoints Replace raw exception-message disclosure (ex.Message) returned to API callers with a stable sanitized public message plus correlated structured internal logging, across the endpoints changed in this PR. - Add SanitizedErrors helper: logs the original exception at Error with a generated correlation id and returns a stable public message referencing it so support can trace without exposing internals. - Inject ILogger<T> into the 14 changed controllers and route every ex.Message/dbex.Message disclosure through the helper, preserving status codes, response shapes, and business data (e.g. OpenWorkOrders). - Leave FluentValidation (vex.Errors) and existing fixed-message catches untouched; out-of-scope controllers (Account/Contact/Employee/Asset/ PMSchedule) are unchanged. - Add focused tests proving internal exception text is not returned and that Error logging carrying the original exception is invoked. * fix(architecture): abstract job run state access * style: format board update service * test: use collection assertion idiom
57 lines
2 KiB
C#
57 lines
2 KiB
C#
using Data.SeaHavenIndustries;
|
|
using Microsoft.AspNetCore.Authorization;
|
|
using Microsoft.AspNetCore.Mvc;
|
|
using SeaHaven.Services.Interfaces;
|
|
|
|
namespace Api.SeaHavenIndustries.Controllers
|
|
{
|
|
[Authorize]
|
|
[ApiController]
|
|
[Route("api/[controller]")]
|
|
[Route("api/dispatches")]
|
|
public class DispatchController : Controller
|
|
{
|
|
private readonly IDispatchService _dispatchService;
|
|
|
|
public DispatchController(IDispatchService dispatchService)
|
|
{
|
|
_dispatchService = dispatchService;
|
|
}
|
|
|
|
[HttpGet]
|
|
public async Task<IActionResult> List(
|
|
[FromQuery] string? search = null,
|
|
[FromQuery] string? status = null,
|
|
[FromQuery] int? vendorId = null,
|
|
[FromQuery] DateTime? dateFrom = null,
|
|
[FromQuery] DateTime? dateTo = null,
|
|
[FromQuery] string? sortBy = "dispatchedAt",
|
|
[FromQuery] string? sortDir = "desc",
|
|
[FromQuery] int page = 1,
|
|
[FromQuery] int pageSize = 25,
|
|
CancellationToken cancellationToken = default)
|
|
{
|
|
var result = await _dispatchService.GetDispatchListAsync(
|
|
search, status, vendorId, dateFrom, dateTo, sortBy, sortDir, page, pageSize, cancellationToken);
|
|
|
|
return Ok(new DataResponse
|
|
{
|
|
Status = "Success",
|
|
Data = new { total = result.Total, page = result.Page, pageSize = result.PageSize, items = result.Items }
|
|
});
|
|
}
|
|
|
|
[HttpGet("{id:int}")]
|
|
public async Task<IActionResult> GetById(int id, CancellationToken cancellationToken)
|
|
{
|
|
var dispatch = await _dispatchService.GetDispatchDetailAsync(id, cancellationToken);
|
|
if (dispatch == null) return NotFound(new Response { Status = "Error", Message = "Dispatch not found" });
|
|
|
|
return Ok(new DataResponse
|
|
{
|
|
Status = "Success",
|
|
Data = dispatch
|
|
});
|
|
}
|
|
}
|
|
}
|