mirror of
https://github.com/Sea-Haven-Industries/shoc-backend.git
synced 2026-09-30 07:13:12 +00:00
* refactor(api): enforce service and data-service boundaries * refactor(api): complete feature service boundaries * refactor(identity): enforce service and data boundaries * refactor(vendors): enforce service and data boundaries * refactor(workorders): enforce service and data boundaries * refactor(backend): enforce architecture and optimize dispatch * style(backend): format changed architecture files * fix(architecture): address backend review follow-ups * fix(backend): sanitize exception disclosure in changed API endpoints Replace raw exception-message disclosure (ex.Message) returned to API callers with a stable sanitized public message plus correlated structured internal logging, across the endpoints changed in this PR. - Add SanitizedErrors helper: logs the original exception at Error with a generated correlation id and returns a stable public message referencing it so support can trace without exposing internals. - Inject ILogger<T> into the 14 changed controllers and route every ex.Message/dbex.Message disclosure through the helper, preserving status codes, response shapes, and business data (e.g. OpenWorkOrders). - Leave FluentValidation (vex.Errors) and existing fixed-message catches untouched; out-of-scope controllers (Account/Contact/Employee/Asset/ PMSchedule) are unchanged. - Add focused tests proving internal exception text is not returned and that Error logging carrying the original exception is invoked. * fix(architecture): abstract job run state access * style: format board update service * test: use collection assertion idiom
56 lines
2 KiB
C#
56 lines
2 KiB
C#
using Data.SeaHavenIndustries;
|
|
using Microsoft.EntityFrameworkCore;
|
|
using SeaHaven.DataServices.Implementation;
|
|
using SeaHaven.Services.Constants;
|
|
using SeaHaven.Services.Implementation;
|
|
|
|
namespace SeaHavenIndustries.Tests;
|
|
|
|
public class WorkOrderFieldLockServiceTests
|
|
{
|
|
private static ApplicationDbContext CreateContext()
|
|
{
|
|
var options = new DbContextOptionsBuilder<ApplicationDbContext>()
|
|
.UseInMemoryDatabase(Guid.NewGuid().ToString())
|
|
.Options;
|
|
return new ApplicationDbContext(options);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task LockFieldAsync_DuplicateCalls_EnqueuesSingleLock()
|
|
{
|
|
await using var context = CreateContext();
|
|
var lockData = new WorkOrderFieldLockDataService(context);
|
|
var locks = new WorkOrderFieldLockService(lockData);
|
|
|
|
await locks.LockFieldAsync(1, WorkOrderFieldNames.Description, "user-1");
|
|
await locks.LockFieldAsync(1, WorkOrderFieldNames.Description, "user-2");
|
|
await context.SaveChangesAsync();
|
|
|
|
var fieldLocks = await context.WorkOrderFieldLocks.ToListAsync();
|
|
Assert.Single(fieldLocks);
|
|
Assert.Equal(WorkOrderFieldNames.Description, fieldLocks[0].FieldName);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task LockFieldAsync_WhenAlreadyPersisted_IsIdempotent()
|
|
{
|
|
await using var context = CreateContext();
|
|
context.WorkOrderFieldLocks.Add(new WorkOrderFieldLock
|
|
{
|
|
WorkOrderId = 2,
|
|
FieldName = WorkOrderFieldNames.AssignTo,
|
|
LockedAt = DateTime.UtcNow,
|
|
LockedByUserId = "user-1"
|
|
});
|
|
await context.SaveChangesAsync();
|
|
|
|
var lockData = new WorkOrderFieldLockDataService(context);
|
|
var locks = new WorkOrderFieldLockService(lockData);
|
|
await locks.LockFieldAsync(2, WorkOrderFieldNames.AssignTo, "user-2");
|
|
await context.SaveChangesAsync();
|
|
|
|
var fieldLocks = await context.WorkOrderFieldLocks.ToListAsync();
|
|
Assert.Single(fieldLocks);
|
|
}
|
|
}
|