mirror of
https://github.com/Sea-Haven-Industries/shoc-backend.git
synced 2026-09-30 06:03:12 +00:00
* refactor(api): enforce service and data-service boundaries * refactor(api): complete feature service boundaries * refactor(identity): enforce service and data boundaries * refactor(vendors): enforce service and data boundaries * refactor(workorders): enforce service and data boundaries * refactor(backend): enforce architecture and optimize dispatch * style(backend): format changed architecture files * fix(architecture): address backend review follow-ups * fix(backend): sanitize exception disclosure in changed API endpoints Replace raw exception-message disclosure (ex.Message) returned to API callers with a stable sanitized public message plus correlated structured internal logging, across the endpoints changed in this PR. - Add SanitizedErrors helper: logs the original exception at Error with a generated correlation id and returns a stable public message referencing it so support can trace without exposing internals. - Inject ILogger<T> into the 14 changed controllers and route every ex.Message/dbex.Message disclosure through the helper, preserving status codes, response shapes, and business data (e.g. OpenWorkOrders). - Leave FluentValidation (vex.Errors) and existing fixed-message catches untouched; out-of-scope controllers (Account/Contact/Employee/Asset/ PMSchedule) are unchanged. - Add focused tests proving internal exception text is not returned and that Error logging carrying the original exception is invoked. * fix(architecture): abstract job run state access * style: format board update service * test: use collection assertion idiom
146 lines
5 KiB
C#
146 lines
5 KiB
C#
using Data.SeaHavenIndustries;
|
|
using FluentAssertions;
|
|
using Microsoft.EntityFrameworkCore;
|
|
using SeaHaven.DataServices.Implementation;
|
|
using SeaHaven.Services.DTOs;
|
|
using SeaHaven.Services.Implementation;
|
|
using Xunit;
|
|
|
|
namespace Api.SeaHavenIndustries.Tests;
|
|
|
|
public class DropdownOptionsServiceTests
|
|
{
|
|
private static ApplicationDbContext NewContext()
|
|
{
|
|
var options = new DbContextOptionsBuilder<ApplicationDbContext>()
|
|
.UseInMemoryDatabase(databaseName: Guid.NewGuid().ToString())
|
|
.Options;
|
|
return new ApplicationDbContext(options);
|
|
}
|
|
|
|
private static DropdownOptionsService NewService(ApplicationDbContext ctx) =>
|
|
new(new DropdownOptionsDataService(ctx));
|
|
|
|
private static DropdownOption Option(string category, string value, string? parent = null, int sort = 0, bool active = true) =>
|
|
new() { Category = category, Value = value, ParentValue = parent, SortOrder = sort, IsActive = active };
|
|
|
|
[Fact]
|
|
public async Task GetAllAsync_FiltersActiveAndOrdersBySortThenValue()
|
|
{
|
|
using var ctx = NewContext();
|
|
ctx.DropdownOptions.AddRange(
|
|
Option("Color", "Red", sort: 2),
|
|
Option("Color", "Blue", sort: 1),
|
|
Option("Color", "Green", sort: 1, active: false),
|
|
Option("Shape", "Circle")
|
|
);
|
|
ctx.SaveChanges();
|
|
|
|
var result = (await NewService(ctx).GetAllAsync(null, CancellationToken.None)).ToList();
|
|
|
|
result.Should().HaveCount(3);
|
|
result.Select(d => d.Value).Should().ContainInOrder("Blue", "Red", "Circle");
|
|
}
|
|
|
|
[Fact]
|
|
public async Task GetByCategoryAsync_FiltersByCategoryAndParent()
|
|
{
|
|
using var ctx = NewContext();
|
|
ctx.DropdownOptions.AddRange(
|
|
Option("State", "TX", parent: "US"),
|
|
Option("State", "CA", parent: "US"),
|
|
Option("State", "ON", parent: "CA")
|
|
);
|
|
ctx.SaveChanges();
|
|
|
|
var result = (await NewService(ctx).GetByCategoryAsync("State", "US", CancellationToken.None)).ToList();
|
|
|
|
result.Select(d => d.Value).Should().BeEquivalentTo(new[] { "TX", "CA" });
|
|
}
|
|
|
|
[Fact]
|
|
public async Task CreateAsync_WhenCategoryOrValueMissing_Throws()
|
|
{
|
|
using var ctx = NewContext();
|
|
var act = () => NewService(ctx).CreateAsync(new DropdownOptionDTO { Category = "", Value = "X" }, CancellationToken.None);
|
|
await act.Should().ThrowAsync<InvalidOperationException>();
|
|
}
|
|
|
|
[Fact]
|
|
public async Task CreateAsync_WhenDuplicate_Throws()
|
|
{
|
|
using var ctx = NewContext();
|
|
ctx.DropdownOptions.Add(Option("Color", "Red", parent: "Primary"));
|
|
ctx.SaveChanges();
|
|
|
|
var act = () => NewService(ctx).CreateAsync(new DropdownOptionDTO { Category = "Color", Value = "Red", ParentValue = "Primary" }, CancellationToken.None);
|
|
|
|
await act.Should().ThrowAsync<InvalidOperationException>();
|
|
}
|
|
|
|
[Fact]
|
|
public async Task CreateAsync_ForcesActiveTrueAndReturnsDtoWithId()
|
|
{
|
|
using var ctx = NewContext();
|
|
var dto = await NewService(ctx).CreateAsync(
|
|
new DropdownOptionDTO { Category = "Color", Value = "Red", IsActive = false }, CancellationToken.None);
|
|
|
|
dto.Id.Should().BeGreaterThan(0);
|
|
dto.IsActive.Should().BeTrue();
|
|
ctx.DropdownOptions.Single().IsActive.Should().BeTrue();
|
|
}
|
|
|
|
[Fact]
|
|
public async Task UpdateAsync_WhenNotFound_ThrowsKeyNotFound()
|
|
{
|
|
using var ctx = NewContext();
|
|
var act = () => NewService(ctx).UpdateAsync(404, new DropdownOptionDTO { Category = "Color", Value = "Red" }, CancellationToken.None);
|
|
await act.Should().ThrowAsync<KeyNotFoundException>();
|
|
}
|
|
|
|
[Fact]
|
|
public async Task UpdateAsync_UpdatesValueParentSortActiveButNotCategory()
|
|
{
|
|
using var ctx = NewContext();
|
|
var existing = Option("Color", "Red");
|
|
ctx.DropdownOptions.Add(existing);
|
|
ctx.SaveChanges();
|
|
|
|
await NewService(ctx).UpdateAsync(existing.Id, new DropdownOptionDTO
|
|
{
|
|
Category = "Ignored",
|
|
Value = "Crimson",
|
|
ParentValue = "Warm",
|
|
SortOrder = 5,
|
|
IsActive = false
|
|
}, CancellationToken.None);
|
|
|
|
var row = ctx.DropdownOptions.Single();
|
|
row.Category.Should().Be("Color");
|
|
row.Value.Should().Be("Crimson");
|
|
row.ParentValue.Should().Be("Warm");
|
|
row.SortOrder.Should().Be(5);
|
|
row.IsActive.Should().BeFalse();
|
|
}
|
|
|
|
[Fact]
|
|
public async Task DeleteAsync_WhenNotFound_ThrowsKeyNotFound()
|
|
{
|
|
using var ctx = NewContext();
|
|
var act = () => NewService(ctx).DeleteAsync(404, CancellationToken.None);
|
|
await act.Should().ThrowAsync<KeyNotFoundException>();
|
|
}
|
|
|
|
[Fact]
|
|
public async Task DeleteAsync_RemovesOption()
|
|
{
|
|
using var ctx = NewContext();
|
|
var existing = Option("Color", "Red");
|
|
ctx.DropdownOptions.Add(existing);
|
|
ctx.SaveChanges();
|
|
|
|
await NewService(ctx).DeleteAsync(existing.Id, CancellationToken.None);
|
|
|
|
ctx.DropdownOptions.Should().BeEmpty();
|
|
}
|
|
}
|