mirror of
https://github.com/Sea-Haven-Industries/shoc-backend.git
synced 2026-09-30 09:33:13 +00:00
* refactor(api): enforce service and data-service boundaries * refactor(api): complete feature service boundaries * refactor(identity): enforce service and data boundaries * refactor(vendors): enforce service and data boundaries * refactor(workorders): enforce service and data boundaries * refactor(backend): enforce architecture and optimize dispatch * style(backend): format changed architecture files * fix(architecture): address backend review follow-ups * fix(backend): sanitize exception disclosure in changed API endpoints Replace raw exception-message disclosure (ex.Message) returned to API callers with a stable sanitized public message plus correlated structured internal logging, across the endpoints changed in this PR. - Add SanitizedErrors helper: logs the original exception at Error with a generated correlation id and returns a stable public message referencing it so support can trace without exposing internals. - Inject ILogger<T> into the 14 changed controllers and route every ex.Message/dbex.Message disclosure through the helper, preserving status codes, response shapes, and business data (e.g. OpenWorkOrders). - Leave FluentValidation (vex.Errors) and existing fixed-message catches untouched; out-of-scope controllers (Account/Contact/Employee/Asset/ PMSchedule) are unchanged. - Add focused tests proving internal exception text is not returned and that Error logging carrying the original exception is invoked. * fix(architecture): abstract job run state access * style: format board update service * test: use collection assertion idiom
75 lines
2.8 KiB
C#
75 lines
2.8 KiB
C#
using System.Reflection;
|
|
using FluentAssertions;
|
|
using Microsoft.Extensions.Configuration;
|
|
using Microsoft.Extensions.DependencyInjection;
|
|
using SeaHaven.DataServices.DependencyInjection;
|
|
using SeaHaven.DataServices.Implementation;
|
|
using SeaHaven.Services.DependencyInjection;
|
|
using SeaHaven.Services.Implementation;
|
|
using Xunit;
|
|
|
|
namespace Api.SeaHavenIndustries.Tests;
|
|
|
|
public class ServiceRegistrationTests
|
|
{
|
|
private static IServiceCollection BuildConventionServices()
|
|
{
|
|
var configuration = new ConfigurationBuilder().Build();
|
|
var services = new ServiceCollection();
|
|
services.AddLogging();
|
|
services.AddSingleton<IConfiguration>(configuration);
|
|
services.AddDataServices();
|
|
services.AddBusinessServices(configuration);
|
|
return services;
|
|
}
|
|
|
|
private static IEnumerable<(Type Implementation, Type Interface)> ConventionCandidates(Assembly assembly)
|
|
{
|
|
return assembly.GetTypes()
|
|
.Where(t => t.IsClass && !t.IsAbstract && !t.IsGenericType)
|
|
.Select(t => (
|
|
Implementation: t,
|
|
Interface: t.GetInterfaces().FirstOrDefault(i => i.Name == $"I{t.Name}")))
|
|
.Where(pair => pair.Interface is not null)!;
|
|
}
|
|
|
|
private static void AssertScopedConventionRegistrations(
|
|
IServiceCollection services,
|
|
IEnumerable<(Type Implementation, Type Interface)> candidates,
|
|
string assemblyLabel)
|
|
{
|
|
var candidateList = candidates.ToList();
|
|
candidateList.Should().NotBeEmpty(
|
|
"expected at least one convention candidate in {0}", assemblyLabel);
|
|
|
|
var missing = candidateList
|
|
.Where(pair => !services.Any(d =>
|
|
d.Lifetime == ServiceLifetime.Scoped &&
|
|
d.ServiceType == pair.Interface &&
|
|
d.ImplementationType == pair.Implementation))
|
|
.ToList();
|
|
|
|
missing.Should().BeEmpty(
|
|
"expected a scoped descriptor mapping each convention candidate interface to its implementation in {0}, missing: {1}",
|
|
assemblyLabel,
|
|
string.Join("; ", missing.Select(p => $"{p.Interface!.FullName} -> {p.Implementation.FullName}")));
|
|
}
|
|
|
|
[Fact]
|
|
public void ConventionDi_RegistersEveryServicesImplementationClassAsScoped()
|
|
{
|
|
var services = BuildConventionServices();
|
|
var candidates = ConventionCandidates(typeof(WorkOrderDispatchService).Assembly);
|
|
|
|
AssertScopedConventionRegistrations(services, candidates, "SeaHaven.Services");
|
|
}
|
|
|
|
[Fact]
|
|
public void ConventionDi_RegistersEveryDataServicesImplementationClassAsScoped()
|
|
{
|
|
var services = BuildConventionServices();
|
|
var candidates = ConventionCandidates(typeof(VendorDataService).Assembly);
|
|
|
|
AssertScopedConventionRegistrations(services, candidates, "SeaHaven.DataServices");
|
|
}
|
|
}
|