mirror of
https://github.com/Sea-Haven-Industries/shoc-backend.git
synced 2026-09-30 07:13:12 +00:00
* refactor(api): enforce service and data-service boundaries * refactor(api): complete feature service boundaries * refactor(identity): enforce service and data boundaries * refactor(vendors): enforce service and data boundaries * refactor(workorders): enforce service and data boundaries * refactor(backend): enforce architecture and optimize dispatch * style(backend): format changed architecture files * fix(architecture): address backend review follow-ups * fix(backend): sanitize exception disclosure in changed API endpoints Replace raw exception-message disclosure (ex.Message) returned to API callers with a stable sanitized public message plus correlated structured internal logging, across the endpoints changed in this PR. - Add SanitizedErrors helper: logs the original exception at Error with a generated correlation id and returns a stable public message referencing it so support can trace without exposing internals. - Inject ILogger<T> into the 14 changed controllers and route every ex.Message/dbex.Message disclosure through the helper, preserving status codes, response shapes, and business data (e.g. OpenWorkOrders). - Leave FluentValidation (vex.Errors) and existing fixed-message catches untouched; out-of-scope controllers (Account/Contact/Employee/Asset/ PMSchedule) are unchanged. - Add focused tests proving internal exception text is not returned and that Error logging carrying the original exception is invoked. * fix(architecture): abstract job run state access * style: format board update service * test: use collection assertion idiom
77 lines
3 KiB
C#
77 lines
3 KiB
C#
using Api.SeaHavenIndustries.Controllers;
|
|
using Data.SeaHavenIndustries;
|
|
using FluentAssertions;
|
|
using Microsoft.AspNetCore.Mvc;
|
|
using Moq;
|
|
using SeaHaven.Services.DTOs;
|
|
using SeaHaven.Services.Interfaces;
|
|
using Xunit;
|
|
|
|
namespace Api.SeaHavenIndustries.Tests;
|
|
|
|
public class DispatchControllerTests
|
|
{
|
|
private static DispatchController NewController(Mock<IDispatchService> service) =>
|
|
new(service.Object);
|
|
|
|
private static object Prop(object source, string name) =>
|
|
source.GetType().GetProperty(name)!.GetValue(source)!;
|
|
|
|
[Fact]
|
|
public async Task List_ReturnsDataResponseWithPaginationShape()
|
|
{
|
|
var service = new Mock<IDispatchService>();
|
|
service.Setup(s => s.GetDispatchListAsync("a", null, null, null, null, "dispatchedAt", "desc", 1, 25, It.IsAny<CancellationToken>()))
|
|
.ReturnsAsync(new DispatchListResultDTO
|
|
{
|
|
Total = 2,
|
|
Page = 1,
|
|
PageSize = 25,
|
|
Items = new List<DispatchListEntryDTO>
|
|
{
|
|
new() { Id = 1, DispatchNumber = "D1" },
|
|
new() { Id = 2, DispatchNumber = "D2" }
|
|
}
|
|
});
|
|
|
|
var result = await NewController(service).List("a", null, null, null, null, "dispatchedAt", "desc", 1, 25, CancellationToken.None);
|
|
|
|
var ok = result.Should().BeOfType<OkObjectResult>().Subject;
|
|
var response = ok.Value.Should().BeOfType<DataResponse>().Subject;
|
|
response.Status.Should().Be("Success");
|
|
object data = response.Data!;
|
|
Prop(data, "total").Should().Be(2);
|
|
Prop(data, "page").Should().Be(1);
|
|
Prop(data, "pageSize").Should().Be(25);
|
|
((System.Collections.IEnumerable)Prop(data, "items")).Cast<object>().Count().Should().Be(2);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task GetById_WhenMissing_ReturnsNotFound()
|
|
{
|
|
var service = new Mock<IDispatchService>();
|
|
service.Setup(s => s.GetDispatchDetailAsync(99, It.IsAny<CancellationToken>()))
|
|
.ReturnsAsync((DispatchDetailResultDTO?)null);
|
|
|
|
var result = await NewController(service).GetById(99, CancellationToken.None);
|
|
|
|
var notFound = result.Should().BeOfType<NotFoundObjectResult>().Subject;
|
|
notFound.Value.Should().BeOfType<Response>().Subject.Message.Should().Be("Dispatch not found");
|
|
}
|
|
|
|
[Fact]
|
|
public async Task GetById_WhenFound_ReturnsDetailAsData()
|
|
{
|
|
var service = new Mock<IDispatchService>();
|
|
var detail = new DispatchDetailResultDTO { Id = 5, DispatchNumber = "D5", Status = "Pending" };
|
|
service.Setup(s => s.GetDispatchDetailAsync(5, It.IsAny<CancellationToken>()))
|
|
.ReturnsAsync(detail);
|
|
|
|
var result = await NewController(service).GetById(5, CancellationToken.None);
|
|
|
|
var ok = result.Should().BeOfType<OkObjectResult>().Subject;
|
|
var response = ok.Value.Should().BeOfType<DataResponse>().Subject;
|
|
response.Status.Should().Be("Success");
|
|
((object?)response.Data).Should().BeSameAs(detail);
|
|
}
|
|
}
|