mirror of
https://github.com/Sea-Haven-Industries/shoc-backend.git
synced 2026-09-30 10:43:13 +00:00
* refactor(api): enforce service and data-service boundaries * refactor(api): complete feature service boundaries * refactor(identity): enforce service and data boundaries * refactor(vendors): enforce service and data boundaries * refactor(workorders): enforce service and data boundaries * refactor(backend): enforce architecture and optimize dispatch * style(backend): format changed architecture files * fix(architecture): address backend review follow-ups * fix(backend): sanitize exception disclosure in changed API endpoints Replace raw exception-message disclosure (ex.Message) returned to API callers with a stable sanitized public message plus correlated structured internal logging, across the endpoints changed in this PR. - Add SanitizedErrors helper: logs the original exception at Error with a generated correlation id and returns a stable public message referencing it so support can trace without exposing internals. - Inject ILogger<T> into the 14 changed controllers and route every ex.Message/dbex.Message disclosure through the helper, preserving status codes, response shapes, and business data (e.g. OpenWorkOrders). - Leave FluentValidation (vex.Errors) and existing fixed-message catches untouched; out-of-scope controllers (Account/Contact/Employee/Asset/ PMSchedule) are unchanged. - Add focused tests proving internal exception text is not returned and that Error logging carrying the original exception is invoked. * fix(architecture): abstract job run state access * style: format board update service * test: use collection assertion idiom
63 lines
2.3 KiB
C#
63 lines
2.3 KiB
C#
using Data.SeaHavenIndustries;
|
|
using Microsoft.EntityFrameworkCore;
|
|
using SeaHaven.DataServices.Implementation;
|
|
using SeaHaven.Services.Constants;
|
|
using SeaHaven.Services.Implementation;
|
|
using SeaHaven.Services.Interfaces;
|
|
|
|
namespace SeaHavenIndustries.Tests;
|
|
|
|
public class WorkOrderAuditServiceTests
|
|
{
|
|
private static ApplicationDbContext CreateContext()
|
|
{
|
|
var options = new DbContextOptionsBuilder<ApplicationDbContext>()
|
|
.UseInMemoryDatabase(Guid.NewGuid().ToString())
|
|
.Options;
|
|
return new ApplicationDbContext(options);
|
|
}
|
|
|
|
private static (WorkOrderAuditService audit, ApplicationDbContext context) CreateAudit(ApplicationDbContext context)
|
|
{
|
|
var lockData = new WorkOrderFieldLockDataService(context);
|
|
var locks = new WorkOrderFieldLockService(lockData);
|
|
var auditData = new WorkOrderAuditDataService(context);
|
|
var audit = new WorkOrderAuditService(auditData, locks);
|
|
return (audit, context);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task LogStatusChanged_CreatesSingleAuditWithManualEventType()
|
|
{
|
|
await using var context = CreateContext();
|
|
context.workOrders.Add(new WorkOrder { Id = 1, Status = "Open" });
|
|
await context.SaveChangesAsync();
|
|
|
|
var (audit, _) = CreateAudit(context);
|
|
|
|
await audit.LogStatusChangedAsync(1, "Open", "In Progress", "user-1");
|
|
|
|
var logs = await context.WorkOrderAuditLogs.ToListAsync();
|
|
Assert.Single(logs);
|
|
Assert.Equal("StatusChanged", logs[0].Action);
|
|
Assert.Equal("Manual", logs[0].EventType);
|
|
Assert.Equal("Dispatcher", logs[0].ActorType);
|
|
Assert.Equal(WorkOrderFieldNames.LifecycleStatus, logs[0].FieldName);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task LogStatusChanged_CreatesFieldLock()
|
|
{
|
|
await using var context = CreateContext();
|
|
context.workOrders.Add(new WorkOrder { Id = 2, Status = "Open" });
|
|
await context.SaveChangesAsync();
|
|
|
|
var (audit, _) = CreateAudit(context);
|
|
|
|
await audit.LogStatusChangedAsync(2, "Open", "Scheduled", "user-1");
|
|
|
|
var fieldLocks = await context.WorkOrderFieldLocks.ToListAsync();
|
|
Assert.Single(fieldLocks);
|
|
Assert.Equal(WorkOrderFieldNames.LifecycleStatus, fieldLocks[0].FieldName);
|
|
}
|
|
}
|