mirror of
https://github.com/Sea-Haven-Industries/shoc-backend.git
synced 2026-09-30 22:23:12 +00:00
* refactor(api): enforce service and data-service boundaries * refactor(api): complete feature service boundaries * refactor(identity): enforce service and data boundaries * refactor(vendors): enforce service and data boundaries * refactor(workorders): enforce service and data boundaries * refactor(backend): enforce architecture and optimize dispatch * style(backend): format changed architecture files * fix(architecture): address backend review follow-ups * fix(backend): sanitize exception disclosure in changed API endpoints Replace raw exception-message disclosure (ex.Message) returned to API callers with a stable sanitized public message plus correlated structured internal logging, across the endpoints changed in this PR. - Add SanitizedErrors helper: logs the original exception at Error with a generated correlation id and returns a stable public message referencing it so support can trace without exposing internals. - Inject ILogger<T> into the 14 changed controllers and route every ex.Message/dbex.Message disclosure through the helper, preserving status codes, response shapes, and business data (e.g. OpenWorkOrders). - Leave FluentValidation (vex.Errors) and existing fixed-message catches untouched; out-of-scope controllers (Account/Contact/Employee/Asset/ PMSchedule) are unchanged. - Add focused tests proving internal exception text is not returned and that Error logging carrying the original exception is invoked. * fix(architecture): abstract job run state access * style: format board update service * test: use collection assertion idiom
101 lines
3.2 KiB
C#
101 lines
3.2 KiB
C#
using Api.SeaHavenIndustries.DTOs;
|
|
using Api.SeaHavenIndustries.Helper;
|
|
using Api.SeaHavenIndustries.Helper.ViewModel;
|
|
using Microsoft.AspNetCore.Authorization;
|
|
using Microsoft.AspNetCore.Mvc;
|
|
using Microsoft.Extensions.Logging;
|
|
using SeaHaven.Services.Interfaces;
|
|
|
|
namespace Api.SeaHavenIndustries.Controllers
|
|
{
|
|
[Authorize]
|
|
[ApiController]
|
|
[Route("[controller]")]
|
|
|
|
public class CommonController : Controller
|
|
{
|
|
private readonly ICommonService _commonService;
|
|
private readonly ILogger<CommonController> _logger;
|
|
|
|
public CommonController(ICommonService commonService, ILogger<CommonController> logger)
|
|
{
|
|
_commonService = commonService;
|
|
_logger = logger;
|
|
}
|
|
|
|
[HttpGet]
|
|
[Route("GetUsers")]
|
|
public async Task<IActionResult> GetUsers(string? search = "", int page = 1, int pageSize = 10, CancellationToken cancellationToken = default)
|
|
{
|
|
try
|
|
{
|
|
var result = await _commonService.GetUsersPagedAsync(search, page, pageSize, cancellationToken);
|
|
|
|
var filteredUsers = result.Users.Select(u => new UserRoleViewModel
|
|
{
|
|
RoleName = u.RoleName,
|
|
Email = u.Email,
|
|
UserName = u.UserName,
|
|
Date = u.Date,
|
|
Status = u.Status,
|
|
Id = u.Id
|
|
}).ToList();
|
|
|
|
var viewModel = new Pagination_DTO
|
|
{
|
|
Data = filteredUsers,
|
|
PageNumber = result.PageNumber,
|
|
PageSize = result.PageSize,
|
|
TotalCount = result.TotalCount,
|
|
TotalPages = result.TotalPages
|
|
};
|
|
return Ok(viewModel);
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
return BadRequest(new { Status = "Error", Message = _logger.Sanitize(ex) });
|
|
}
|
|
}
|
|
|
|
[HttpGet]
|
|
[Route("GetRoles")]
|
|
public async Task<IActionResult> GetRoles(CancellationToken cancellationToken)
|
|
{
|
|
try
|
|
{
|
|
var data = await _commonService.GetRolesAsync(cancellationToken);
|
|
|
|
return Ok(data);
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
return BadRequest(new { Status = "Error", Message = _logger.Sanitize(ex) });
|
|
}
|
|
}
|
|
|
|
|
|
[HttpGet]
|
|
[Route("GetSitesName")]
|
|
public async Task<IActionResult> GetSiteName(CancellationToken cancellationToken)
|
|
{
|
|
var data = await _commonService.GetSiteNamesAsync(cancellationToken);
|
|
return Ok(data);
|
|
}
|
|
|
|
[HttpGet]
|
|
[Route("GetContacts")]
|
|
public async Task<IActionResult> GetContacts(CancellationToken cancellationToken)
|
|
{
|
|
var data = await _commonService.GetContactsAsync(cancellationToken);
|
|
return Ok(data);
|
|
}
|
|
|
|
[HttpGet]
|
|
[Route("GetCategories")]
|
|
public async Task<IActionResult> GetCategories(CancellationToken cancellationToken)
|
|
{
|
|
var data = await _commonService.GetCategoriesAsync(cancellationToken);
|
|
return Ok(data);
|
|
}
|
|
}
|
|
}
|