mirror of
https://github.com/Sea-Haven-Industries/shoc-backend.git
synced 2026-09-30 08:23:12 +00:00
* refactor(api): enforce service and data-service boundaries * refactor(api): complete feature service boundaries * refactor(identity): enforce service and data boundaries * refactor(vendors): enforce service and data boundaries * refactor(workorders): enforce service and data boundaries * refactor(backend): enforce architecture and optimize dispatch * style(backend): format changed architecture files * fix(architecture): address backend review follow-ups * fix(backend): sanitize exception disclosure in changed API endpoints Replace raw exception-message disclosure (ex.Message) returned to API callers with a stable sanitized public message plus correlated structured internal logging, across the endpoints changed in this PR. - Add SanitizedErrors helper: logs the original exception at Error with a generated correlation id and returns a stable public message referencing it so support can trace without exposing internals. - Inject ILogger<T> into the 14 changed controllers and route every ex.Message/dbex.Message disclosure through the helper, preserving status codes, response shapes, and business data (e.g. OpenWorkOrders). - Leave FluentValidation (vex.Errors) and existing fixed-message catches untouched; out-of-scope controllers (Account/Contact/Employee/Asset/ PMSchedule) are unchanged. - Add focused tests proving internal exception text is not returned and that Error logging carrying the original exception is invoked. * fix(architecture): abstract job run state access * style: format board update service * test: use collection assertion idiom
158 lines
5.1 KiB
C#
158 lines
5.1 KiB
C#
using Data.SeaHavenIndustries;
|
|
using Data.SeaHavenIndustries.Enums;
|
|
using Microsoft.EntityFrameworkCore;
|
|
using SeaHaven.DataServices.Implementation;
|
|
using SeaHaven.Services.Constants;
|
|
using SeaHaven.Services.Implementation;
|
|
using SeaHaven.Services.Interfaces;
|
|
|
|
namespace SeaHavenIndustries.Tests;
|
|
|
|
public class SyncFieldMergePolicyTests
|
|
{
|
|
private static ApplicationDbContext CreateContext()
|
|
{
|
|
var options = new DbContextOptionsBuilder<ApplicationDbContext>()
|
|
.UseInMemoryDatabase(Guid.NewGuid().ToString())
|
|
.Options;
|
|
return new ApplicationDbContext(options);
|
|
}
|
|
|
|
private static WorkOrderFieldLockService CreateLocks(ApplicationDbContext context)
|
|
=> new(new WorkOrderFieldLockDataService(context));
|
|
|
|
private static WorkOrderAuditService CreateAudit(ApplicationDbContext context, WorkOrderFieldLockService locks)
|
|
=> new(new WorkOrderAuditDataService(context), locks);
|
|
|
|
[Fact]
|
|
public async Task TryApply_WhenFieldLocked_RejectsAndAudits()
|
|
{
|
|
await using var context = CreateContext();
|
|
var wo = new WorkOrder { Id = 10, Description = "SHOC edited", Status = "Open" };
|
|
context.workOrders.Add(wo);
|
|
context.WorkOrderFieldLocks.Add(new WorkOrderFieldLock
|
|
{
|
|
WorkOrderId = 10,
|
|
FieldName = WorkOrderFieldNames.Description,
|
|
LockedAt = DateTime.UtcNow
|
|
});
|
|
await context.SaveChangesAsync();
|
|
|
|
var locks = CreateLocks(context);
|
|
var audit = CreateAudit(context, locks);
|
|
var policy = new SyncFieldMergePolicy(locks);
|
|
|
|
var syncContext = new WorkOrderSyncContext
|
|
{
|
|
WorkOrder = wo,
|
|
FieldLocks = locks,
|
|
Audit = audit
|
|
};
|
|
|
|
var applied = await policy.TryApplyAsync(syncContext, WorkOrderFieldNames.Description, "Sync value");
|
|
|
|
Assert.False(applied);
|
|
Assert.Equal("SHOC edited", wo.Description);
|
|
|
|
var logs = await context.WorkOrderAuditLogs.ToListAsync();
|
|
Assert.Single(logs);
|
|
Assert.Equal("SyncRejected", logs[0].Action);
|
|
Assert.Equal("Sync", logs[0].EventType);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task TryApply_WhenFieldNotLocked_AppliesValue()
|
|
{
|
|
await using var context = CreateContext();
|
|
var wo = new WorkOrder { Id = 11, Description = "Original" };
|
|
context.workOrders.Add(wo);
|
|
await context.SaveChangesAsync();
|
|
|
|
var locks = CreateLocks(context);
|
|
var audit = CreateAudit(context, locks);
|
|
var policy = new SyncFieldMergePolicy(locks);
|
|
|
|
var syncContext = new WorkOrderSyncContext
|
|
{
|
|
WorkOrder = wo,
|
|
FieldLocks = locks,
|
|
Audit = audit
|
|
};
|
|
|
|
var applied = await policy.TryApplyAsync(syncContext, WorkOrderFieldNames.Description, "From sync");
|
|
|
|
Assert.True(applied);
|
|
Assert.Equal("From sync", wo.Description);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task TryApply_UnsupportedField_ReturnsFalse()
|
|
{
|
|
await using var context = CreateContext();
|
|
var wo = new WorkOrder { Id = 12 };
|
|
context.workOrders.Add(wo);
|
|
await context.SaveChangesAsync();
|
|
|
|
var locks = CreateLocks(context);
|
|
var audit = CreateAudit(context, locks);
|
|
var policy = new SyncFieldMergePolicy(locks);
|
|
|
|
var syncContext = new WorkOrderSyncContext
|
|
{
|
|
WorkOrder = wo,
|
|
FieldLocks = locks,
|
|
Audit = audit
|
|
};
|
|
|
|
var applied = await policy.TryApplyAsync(syncContext, "NotARealField", "value");
|
|
|
|
Assert.False(applied);
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData(WorkOrderFieldNames.LifecycleStatus, LifecycleStatus.Scheduled)]
|
|
[InlineData(WorkOrderFieldNames.Service, "PM")]
|
|
[InlineData(WorkOrderFieldNames.DueDate, "2026-07-01T10:00:00Z")]
|
|
public async Task TryApply_ShocOwnedFields_AppliesValue(string fieldName, object incomingValue)
|
|
{
|
|
await using var context = CreateContext();
|
|
var wo = new WorkOrder { Id = 13 };
|
|
context.workOrders.Add(wo);
|
|
await context.SaveChangesAsync();
|
|
|
|
var locks = CreateLocks(context);
|
|
var audit = CreateAudit(context, locks);
|
|
var policy = new SyncFieldMergePolicy(locks);
|
|
|
|
var syncContext = new WorkOrderSyncContext
|
|
{
|
|
WorkOrder = wo,
|
|
FieldLocks = locks,
|
|
Audit = audit
|
|
};
|
|
|
|
var applied = await policy.TryApplyAsync(syncContext, fieldName, incomingValue);
|
|
|
|
Assert.True(applied);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task CanSyncOverwriteAsync_WhenLocked_ReturnsFalse()
|
|
{
|
|
await using var context = CreateContext();
|
|
context.WorkOrderFieldLocks.Add(new WorkOrderFieldLock
|
|
{
|
|
WorkOrderId = 20,
|
|
FieldName = WorkOrderFieldNames.AssignTo,
|
|
LockedAt = DateTime.UtcNow
|
|
});
|
|
await context.SaveChangesAsync();
|
|
|
|
var locks = CreateLocks(context);
|
|
var policy = new SyncFieldMergePolicy(locks);
|
|
|
|
var canOverwrite = await policy.CanSyncOverwriteAsync(20, WorkOrderFieldNames.AssignTo);
|
|
|
|
Assert.False(canOverwrite);
|
|
}
|
|
}
|