mirror of
https://github.com/Sea-Haven-Industries/shoc-backend.git
synced 2026-09-30 23:33:10 +00:00
* refactor(api): enforce service and data-service boundaries * refactor(api): complete feature service boundaries * refactor(identity): enforce service and data boundaries * refactor(vendors): enforce service and data boundaries * refactor(workorders): enforce service and data boundaries * refactor(backend): enforce architecture and optimize dispatch * style(backend): format changed architecture files * fix(architecture): address backend review follow-ups * fix(backend): sanitize exception disclosure in changed API endpoints Replace raw exception-message disclosure (ex.Message) returned to API callers with a stable sanitized public message plus correlated structured internal logging, across the endpoints changed in this PR. - Add SanitizedErrors helper: logs the original exception at Error with a generated correlation id and returns a stable public message referencing it so support can trace without exposing internals. - Inject ILogger<T> into the 14 changed controllers and route every ex.Message/dbex.Message disclosure through the helper, preserving status codes, response shapes, and business data (e.g. OpenWorkOrders). - Leave FluentValidation (vex.Errors) and existing fixed-message catches untouched; out-of-scope controllers (Account/Contact/Employee/Asset/ PMSchedule) are unchanged. - Add focused tests proving internal exception text is not returned and that Error logging carrying the original exception is invoked. * fix(architecture): abstract job run state access * style: format board update service * test: use collection assertion idiom
92 lines
3.4 KiB
C#
92 lines
3.4 KiB
C#
using Data.SeaHavenIndustries;
|
|
using SeaHaven.DataServices.Interfaces;
|
|
using SeaHaven.Services.DTOs;
|
|
using SeaHaven.Services.Interfaces;
|
|
|
|
namespace SeaHaven.Services.Implementation
|
|
{
|
|
public class TaskListTemplateService : ITaskListTemplateService
|
|
{
|
|
private readonly ITaskListTemplateDataService _dataService;
|
|
|
|
public TaskListTemplateService(ITaskListTemplateDataService dataService)
|
|
{
|
|
_dataService = dataService;
|
|
}
|
|
|
|
public async Task<IEnumerable<TaskListTemplateDTO>> GetAllAsync(CancellationToken cancellationToken)
|
|
{
|
|
var templates = await _dataService.GetActiveTemplatesWithItemsAsync(cancellationToken);
|
|
return templates.Select(MapToDTO);
|
|
}
|
|
|
|
public async Task<TaskListTemplateDTO?> GetByIdAsync(int id, CancellationToken cancellationToken)
|
|
{
|
|
var template = await _dataService.GetTemplateWithItemsReadOnlyAsync(id, cancellationToken);
|
|
return template == null ? null : MapToDTO(template);
|
|
}
|
|
|
|
public async Task<int> CreateAsync(TaskListTemplateInput input, CancellationToken cancellationToken)
|
|
{
|
|
var template = new TaskListTemplate
|
|
{
|
|
Name = input.Name,
|
|
Description = input.Description,
|
|
IsActive = input.IsActive,
|
|
Items = input.Items.Select((item, idx) => new TaskListTemplateItem
|
|
{
|
|
ItemText = item.ItemText,
|
|
SortOrder = item.SortOrder > 0 ? item.SortOrder : idx
|
|
}).ToList()
|
|
};
|
|
|
|
var created = await _dataService.AddTemplateAsync(template, cancellationToken);
|
|
return created.Id;
|
|
}
|
|
|
|
public async Task<bool> UpdateAsync(int id, TaskListTemplateInput input, CancellationToken cancellationToken)
|
|
{
|
|
var template = await _dataService.GetTemplateWithItemsForUpdateAsync(id, cancellationToken);
|
|
if (template == null)
|
|
return false;
|
|
|
|
template.Name = input.Name;
|
|
template.Description = input.Description;
|
|
template.IsActive = input.IsActive;
|
|
|
|
var newItems = input.Items.Select((item, idx) => new TaskListTemplateItem
|
|
{
|
|
TaskListTemplateId = id,
|
|
ItemText = item.ItemText,
|
|
SortOrder = item.SortOrder > 0 ? item.SortOrder : idx
|
|
}).ToList();
|
|
|
|
await _dataService.ReplaceTemplateItemsAsync(template, newItems, cancellationToken);
|
|
return true;
|
|
}
|
|
|
|
public async Task<bool> DeleteAsync(int id, CancellationToken cancellationToken)
|
|
{
|
|
return await _dataService.DeactivateTemplateAsync(id, cancellationToken);
|
|
}
|
|
|
|
private static TaskListTemplateDTO MapToDTO(TaskListTemplate template)
|
|
{
|
|
return new TaskListTemplateDTO
|
|
{
|
|
Id = template.Id,
|
|
Name = template.Name,
|
|
Description = template.Description,
|
|
IsActive = template.IsActive,
|
|
Items = (template.Items ?? new List<TaskListTemplateItem>())
|
|
.OrderBy(i => i.SortOrder)
|
|
.Select(i => new TaskListTemplateItemDTO
|
|
{
|
|
Id = i.Id,
|
|
ItemText = i.ItemText,
|
|
SortOrder = i.SortOrder
|
|
}).ToList()
|
|
};
|
|
}
|
|
}
|
|
}
|