Merge pull request #190 from Sea-Haven-Industries/fix/ab/wo-created-utc

fix(data): stamp audit times in UTC and keep a work order's creation time

Api.SeaHavenIndustries.Tests/CalendarServiceTests.cs

@@ -44,7 +44,7 @@ public class CalendarServiceTests
             StartDate = startDate,
             EndDate = startDate,
             IsDeleted = isDeleted,
-            CreatedDate = DateTime.Now
+            CreatedDate = DateTime.UtcNow
         };
         ctx.Events.Add(ev);
         ctx.SaveChanges();
@@ -64,6 +64,7 @@ public class CalendarServiceTests
         saved.Title.Should().Be("Standup");
         saved.IsDeleted.Should().Be(false);
         saved.CreatedDate.Should().NotBeNull();
+        saved.CreatedDate!.Value.Kind.Should().Be(DateTimeKind.Utc);
     }
 
     [Fact]
@@ -97,6 +98,7 @@ public class CalendarServiceTests
         var updated = ctx.Events.Single();
         updated.Title.Should().Be("New");
         updated.LastModificationTime.Should().NotBeNull();
+        updated.LastModificationTime!.Value.Kind.Should().Be(DateTimeKind.Utc);
     }
 
     [Fact]
@@ -134,6 +136,7 @@ public class CalendarServiceTests
         var row = ctx.Events.Single();
         row.IsDeleted.Should().Be(true);
         row.DeletionTime.Should().NotBeNull();
+        row.DeletionTime!.Value.Kind.Should().Be(DateTimeKind.Utc);
     }
 
     [Fact]

Api.SeaHavenIndustries.Tests/WorkOrderDataServiceTimestampTests.cs

@@ -0,0 +1,68 @@
+using Data.SeaHavenIndustries;
+using FluentAssertions;
+using Microsoft.EntityFrameworkCore;
+using SeaHaven.DataServices.Implementation;
+using Xunit;
+
+namespace Api.SeaHavenIndustries.Tests;
+
+/// <summary>
+/// The SLA clock and every "created"/"modified" display read these stamps as UTC, so the data layer
+/// must never write local server time into them.
+/// </summary>
+public class WorkOrderDataServiceTimestampTests
+{
+    private static ApplicationDbContext NewContext()
+    {
+        var options = new DbContextOptionsBuilder<ApplicationDbContext>()
+            .UseInMemoryDatabase(Guid.NewGuid().ToString())
+            .Options;
+        return new ApplicationDbContext(options);
+    }
+
+    private static WorkOrder NewWorkOrder() =>
+        new() { InternalWONumber = "WO-1", WorkerOrderTitle = "Leak", LocationId = 100 };
+
+    [Fact]
+    public async Task AddAsync_KeepsTheCreationTimeTheCallerSet()
+    {
+        await using var context = NewContext();
+        var createdAt = new DateTime(2026, 9, 25, 14, 0, 0, DateTimeKind.Utc);
+        var workOrder = NewWorkOrder();
+        workOrder.CreatedDate = createdAt;
+
+        var saved = await new WorkOrderDataService(context).AddAsync(workOrder);
+
+        saved.CreatedDate.Should().Be(createdAt);
+        saved.CreatedDate!.Value.Kind.Should().Be(DateTimeKind.Utc);
+        (await context.workOrders.SingleAsync()).CreatedDate.Should().Be(createdAt);
+    }
+
+    [Fact]
+    public async Task AddAsync_StampsUtcWhenTheCallerSetNoCreationTime()
+    {
+        await using var context = NewContext();
+        var before = DateTime.UtcNow;
+
+        var saved = await new WorkOrderDataService(context).AddAsync(NewWorkOrder());
+
+        saved.CreatedDate.Should().NotBeNull();
+        saved.CreatedDate!.Value.Kind.Should().Be(DateTimeKind.Utc);
+        saved.CreatedDate.Value.Should().BeOnOrAfter(before).And.BeOnOrBefore(DateTime.UtcNow);
+    }
+
+    [Fact]
+    public async Task UpdateAsync_StampsTheModificationTimeInUtc()
+    {
+        await using var context = NewContext();
+        var service = new WorkOrderDataService(context);
+        var saved = await service.AddAsync(NewWorkOrder());
+        var before = DateTime.UtcNow;
+
+        await service.UpdateAsync(saved);
+
+        saved.LastModificationTime.Should().NotBeNull();
+        saved.LastModificationTime!.Value.Kind.Should().Be(DateTimeKind.Utc);
+        saved.LastModificationTime.Value.Should().BeOnOrAfter(before).And.BeOnOrBefore(DateTime.UtcNow);
+    }
+}

README.md

@@ -21,6 +21,12 @@ Both run in `us-east-1` on the .NET 8 Amazon Linux 2023 platform. Terraform in
 `terraform/live/` owns the environments; GitHub Actions owns the application
 versions. There is no production environment yet.
 
+Stored created, modified and deletion times are UTC: the API stamps them with
+`DateTime.UtcNow`, whatever the host's time zone. The API has only ever run on
+Linux Elastic Beanstalk hosts left at their UTC default (nothing in Terraform,
+`.ebextensions` or `.platform` sets a time zone), so rows written before the
+switch from `DateTime.Now` are already UTC and need no backfill.
+
 ## Architecture
 
 ```text

SeaHaven.DataServices/Implementation/AccountDataService.cs

@@ -64,7 +64,7 @@ namespace SeaHaven.DataServices.Implementation
 
         public async Task<Accounts> AddAsync(Accounts account)
         {
-            account.CreatedDate = DateTime.Now;
+            account.CreatedDate = DateTime.UtcNow;
             await _context.Accounts.AddAsync(account);
             await _context.SaveChangesAsync();
             return account;
@@ -72,7 +72,7 @@ namespace SeaHaven.DataServices.Implementation
 
         public async Task UpdateAsync(Accounts account)
         {
-            account.LastModificationTime = DateTime.Now;
+            account.LastModificationTime = DateTime.UtcNow;
             _context.Accounts.Update(account);
             await _context.SaveChangesAsync();
         }

SeaHaven.DataServices/Implementation/AssetDataService.cs

@@ -72,7 +72,7 @@ namespace SeaHaven.DataServices.Implementation
 
         public async Task<Assets> AddAsync(Assets asset)
         {
-            asset.CreatedDate = DateTime.Now;
+            asset.CreatedDate = DateTime.UtcNow;
             await _context.Assets.AddAsync(asset);
             await _context.SaveChangesAsync();
             return asset;
@@ -80,7 +80,7 @@ namespace SeaHaven.DataServices.Implementation
 
         public async Task UpdateAsync(Assets asset)
         {
-            asset.LastModificationTime = DateTime.Now;
+            asset.LastModificationTime = DateTime.UtcNow;
             _context.Assets.Update(asset);
             await _context.SaveChangesAsync();
         }

SeaHaven.DataServices/Implementation/CategoryDataService.cs

@@ -25,7 +25,7 @@ namespace SeaHaven.DataServices.Implementation
 
         public async Task<Category> AddAsync(Category category)
         {
-            category.CreatedDate = DateTime.Now;
+            category.CreatedDate = DateTime.UtcNow;
             await _context.Categories.AddAsync(category);
             await _context.SaveChangesAsync();
             return category;
@@ -33,7 +33,7 @@ namespace SeaHaven.DataServices.Implementation
 
         public async Task UpdateAsync(Category category)
         {
-            category.LastModificationTime = DateTime.Now;
+            category.LastModificationTime = DateTime.UtcNow;
             _context.Categories.Update(category);
             await _context.SaveChangesAsync();
         }

SeaHaven.DataServices/Implementation/ContactDataService.cs

@@ -100,7 +100,7 @@ namespace SeaHaven.DataServices.Implementation
 
         public async Task<Contacts> AddAsync(Contacts contact)
         {
-            contact.CreatedDate = DateTime.Now;
+            contact.CreatedDate = DateTime.UtcNow;
             await _context.Contacts.AddAsync(contact);
             await _context.SaveChangesAsync();
             return contact;
@@ -108,7 +108,7 @@ namespace SeaHaven.DataServices.Implementation
 
         public async Task UpdateAsync(Contacts contact)
         {
-            contact.LastModificationTime = DateTime.Now;
+            contact.LastModificationTime = DateTime.UtcNow;
             _context.Contacts.Update(contact);
             await _context.SaveChangesAsync();
         }

SeaHaven.DataServices/Implementation/DispatchDataService.cs

@@ -85,7 +85,7 @@ namespace SeaHaven.DataServices.Implementation
 
         public async Task<Dispatch> AddAsync(Dispatch dispatch)
         {
-            dispatch.CreatedDate = DateTime.Now;
+            dispatch.CreatedDate = DateTime.UtcNow;
             await _context.Dispatches.AddAsync(dispatch);
             await _context.SaveChangesAsync();
             return dispatch;
@@ -93,7 +93,7 @@ namespace SeaHaven.DataServices.Implementation
 
         public async Task UpdateAsync(Dispatch dispatch)
         {
-            dispatch.LastModificationTime = DateTime.Now;
+            dispatch.LastModificationTime = DateTime.UtcNow;
             _context.Dispatches.Update(dispatch);
             await _context.SaveChangesAsync();
         }

SeaHaven.DataServices/Implementation/EmployeeDataService.cs

@@ -72,7 +72,7 @@ namespace SeaHaven.DataServices.Implementation
 
         public async Task<Employee> AddAsync(Employee employee)
         {
-            employee.CreatedDate = DateTime.Now;
+            employee.CreatedDate = DateTime.UtcNow;
             await _context.Employees.AddAsync(employee);
             await _context.SaveChangesAsync();
             return employee;
@@ -80,7 +80,7 @@ namespace SeaHaven.DataServices.Implementation
 
         public async Task UpdateAsync(Employee employee)
         {
-            employee.LastModificationTime = DateTime.Now;
+            employee.LastModificationTime = DateTime.UtcNow;
             _context.Employees.Update(employee);
             await _context.SaveChangesAsync();
         }

SeaHaven.DataServices/Implementation/FollowUpDataService.cs

@@ -88,7 +88,7 @@ namespace SeaHaven.DataServices.Implementation
 
         public async Task<FollowUps> AddAsync(FollowUps followUp)
         {
-            followUp.CreatedDate = DateTime.Now;
+            followUp.CreatedDate = DateTime.UtcNow;
             await _context.FollowUps.AddAsync(followUp);
             await _context.SaveChangesAsync();
             return followUp;
@@ -96,7 +96,7 @@ namespace SeaHaven.DataServices.Implementation
 
         public async Task UpdateAsync(FollowUps followUp)
         {
-            followUp.LastModificationTime = DateTime.Now;
+            followUp.LastModificationTime = DateTime.UtcNow;
             _context.FollowUps.Update(followUp);
             await _context.SaveChangesAsync();
         }
@@ -218,7 +218,7 @@ namespace SeaHaven.DataServices.Implementation
 
         public async Task<FollowUps> AddAsync(FollowUps followUp, CancellationToken cancellationToken)
         {
-            followUp.CreatedDate = DateTime.Now;
+            followUp.CreatedDate = DateTime.UtcNow;
             await _context.FollowUps.AddAsync(followUp, cancellationToken);
             await _context.SaveChangesAsync(cancellationToken);
             return followUp;
@@ -226,7 +226,7 @@ namespace SeaHaven.DataServices.Implementation
 
         public async Task UpdateAsync(FollowUps followUp, CancellationToken cancellationToken)
         {
-            followUp.LastModificationTime = DateTime.Now;
+            followUp.LastModificationTime = DateTime.UtcNow;
             _context.FollowUps.Update(followUp);
             await _context.SaveChangesAsync(cancellationToken);
         }
@@ -238,7 +238,7 @@ namespace SeaHaven.DataServices.Implementation
                 return false;
 
             entity.Status = status;
-            entity.LastModificationTime = DateTime.Now;
+            entity.LastModificationTime = DateTime.UtcNow;
             await _context.SaveChangesAsync(cancellationToken);
             return true;
         }

SeaHaven.DataServices/Implementation/LocationDataService.cs

@@ -100,7 +100,7 @@ namespace SeaHaven.DataServices.Implementation
 
         public async Task<Locations> AddAsync(Locations location)
         {
-            location.CreatedDate = DateTime.Now;
+            location.CreatedDate = DateTime.UtcNow;
             await _context.Locations.AddAsync(location);
             await _context.SaveChangesAsync();
             return location;
@@ -108,7 +108,7 @@ namespace SeaHaven.DataServices.Implementation
 
         public async Task UpdateAsync(Locations location)
         {
-            location.LastModificationTime = DateTime.Now;
+            location.LastModificationTime = DateTime.UtcNow;
             _context.Locations.Update(location);
             await _context.SaveChangesAsync();
         }
@@ -232,7 +232,7 @@ namespace SeaHaven.DataServices.Implementation
 
         public async Task<Locations> AddAsync(Locations location, CancellationToken cancellationToken)
         {
-            location.CreatedDate = DateTime.Now;
+            location.CreatedDate = DateTime.UtcNow;
             await _context.Locations.AddAsync(location, cancellationToken);
             await _context.SaveChangesAsync(cancellationToken);
             return location;
@@ -240,7 +240,7 @@ namespace SeaHaven.DataServices.Implementation
 
         public async Task UpdateAsync(Locations location, CancellationToken cancellationToken)
         {
-            location.LastModificationTime = DateTime.Now;
+            location.LastModificationTime = DateTime.UtcNow;
             _context.Locations.Update(location);
             await _context.SaveChangesAsync(cancellationToken);
         }

SeaHaven.DataServices/Implementation/PMScheduleDataService.cs

@@ -64,7 +64,7 @@ namespace SeaHaven.DataServices.Implementation
 
         public async Task<PMSchedules> AddAsync(PMSchedules schedule)
         {
-            schedule.CreatedDate = DateTime.Now;
+            schedule.CreatedDate = DateTime.UtcNow;
             await _context.PMSchedules.AddAsync(schedule);
             await _context.SaveChangesAsync();
             return schedule;
@@ -72,7 +72,7 @@ namespace SeaHaven.DataServices.Implementation
 
         public async Task UpdateAsync(PMSchedules schedule)
         {
-            schedule.LastModificationTime = DateTime.Now;
+            schedule.LastModificationTime = DateTime.UtcNow;
             _context.PMSchedules.Update(schedule);
             await _context.SaveChangesAsync();
         }

SeaHaven.DataServices/Implementation/WorkOrderDataService.cs

@@ -193,7 +193,7 @@ namespace SeaHaven.DataServices.Implementation
 
         public async Task<WorkOrder> AddAsync(WorkOrder workOrder)
         {
-            workOrder.CreatedDate = DateTime.Now;
+            workOrder.CreatedDate ??= DateTime.UtcNow;
             await _context.workOrders.AddAsync(workOrder);
             await _context.SaveChangesAsync();
             return workOrder;
@@ -201,7 +201,7 @@ namespace SeaHaven.DataServices.Implementation
 
         public async Task UpdateAsync(WorkOrder workOrder)
         {
-            workOrder.LastModificationTime = DateTime.Now;
+            workOrder.LastModificationTime = DateTime.UtcNow;
             _context.workOrders.Update(workOrder);
             await _context.SaveChangesAsync();
         }

SeaHaven.Services/Implementation/CalendarService.cs

@@ -31,7 +31,7 @@ namespace SeaHaven.Services.Implementation
                 EndDate = input.EndDate,
                 EndTime = input.EndTime,
                 AllDay = input.AllDay,
-                CreatedDate = DateTime.Now,
+                CreatedDate = DateTime.UtcNow,
                 IsDeleted = false
             };
 
@@ -57,7 +57,7 @@ namespace SeaHaven.Services.Implementation
             model.EndDate = input.EndDate;
             model.EndTime = input.EndTime;
             model.AllDay = input.AllDay;
-            model.LastModificationTime = DateTime.Now;
+            model.LastModificationTime = DateTime.UtcNow;
 
             await _dataService.UpdateEventAsync(model, cancellationToken);
             return true;
@@ -76,7 +76,7 @@ namespace SeaHaven.Services.Implementation
                 return false;
 
             model.IsDeleted = true;
-            model.DeletionTime = DateTime.Now;
+            model.DeletionTime = DateTime.UtcNow;
 
             await _dataService.UpdateEventAsync(model, cancellationToken);
             return true;

SeaHaven.Services/Implementation/ContactService.cs

@@ -104,7 +104,7 @@ namespace SeaHaven.Services.Implementation
                 ContactType = dto.Type,
                 AccountId = dto.AccountId,
                 createdby = userId,
-                CreatedDate = DateTime.Now
+                CreatedDate = DateTime.UtcNow
             };
 
             var savedContact = await _contactDataService.AddAsync(contact);
@@ -151,7 +151,7 @@ namespace SeaHaven.Services.Implementation
             if (dto.AccountId.HasValue)
                 existingContact.AccountId = dto.AccountId;
 
-            existingContact.LastModificationTime = DateTime.Now;
+            existingContact.LastModificationTime = DateTime.UtcNow;
 
             await _contactDataService.UpdateAsync(existingContact);
 

SeaHaven.Services/Implementation/LocationService.cs

@@ -579,7 +579,7 @@ namespace SeaHaven.Services.Implementation
         {
             ThrowOnInvalidContacts(contacts);
 
-            var now = DateTime.Now;
+            var now = DateTime.UtcNow;
             var siteContacts = contacts
                 .Select((row, index) => new Contacts
                 {
@@ -634,7 +634,7 @@ namespace SeaHaven.Services.Implementation
                     existing.PhoneNumber = phone;
                     existing.SiteContactOrder = i;
                     existing.AccountId = location.AccountId;
-                    existing.LastModificationTime = DateTime.Now;
+                    existing.LastModificationTime = DateTime.UtcNow;
                 }
                 else
                 {
@@ -647,7 +647,7 @@ namespace SeaHaven.Services.Implementation
                         PhoneNumber = phone,
                         SiteContactOrder = i,
                         AccountId = location.AccountId,
-                        CreatedDate = DateTime.Now,
+                        CreatedDate = DateTime.UtcNow,
                         createdby = actorId
                     });
                 }
@@ -655,7 +655,7 @@ namespace SeaHaven.Services.Implementation
 
             // Rows omitted from the request are soft deleted so historical
             // WorkOrderContacts keep rendering.
-            var now = DateTime.Now;
+            var now = DateTime.UtcNow;
             foreach (var existing in existingById.Values)
             {
                 if (keptIds.Contains(existing.Id) || existing.IsDeleted == true)

SeaHaven.Services/Implementation/UserService.cs

@@ -72,7 +72,7 @@ namespace SeaHaven.Services.Implementation
             {
                 model.EmailConfirmed = true;
                 model.UserName = model.Email;
-                model.CreatedDate = DateTime.Now;
+                model.CreatedDate = DateTime.UtcNow;
                 model.UniqueName = "Active";
                 model.PhoneNumber = dto.Role;
 
@@ -152,7 +152,7 @@ namespace SeaHaven.Services.Implementation
             exist.Email = dto.Email;
             exist.NormalizedEmail = dto.Email.ToUpperInvariant();
             exist.NormalizedUserName = dto.Email.ToUpperInvariant();
-            exist.CreatedDate = DateTime.Now;
+            exist.CreatedDate = DateTime.UtcNow;
             exist.UniqueName = "Active";
             exist.PhoneNumber = dto.Role;
             exist.AccountId = dto.AccountId;